@ -72,14 +72,6 @@ namespace EntityFrameworkCore.Jet.Query.Sql.Internal
// workaround.
// workaround.
// Should be kept in sync with the base class.
// Should be kept in sync with the base class.
if ( IsNonComposedSetOperation ( selectExpression ) )
{
// Naked set operation
GenerateSetOperation ( ( SetOperationBase ) selectExpression . Tables [ 0 ] ) ;
return selectExpression ;
}
IDisposable ? subQueryIndent = null ;
IDisposable ? subQueryIndent = null ;
if ( selectExpression . Alias ! = null )
if ( selectExpression . Alias ! = null )
@ -88,202 +80,212 @@ namespace EntityFrameworkCore.Jet.Query.Sql.Internal
subQueryIndent = Sql . Indent ( ) ;
subQueryIndent = Sql . Indent ( ) ;
}
}
Sql . Append ( "SELECT " ) ;
if ( ! TryGenerateWithoutWrappingSelect ( selectExpression ) )
if ( selectExpression . IsDistinct )
{
{
Sql . Append ( "DISTINCT " ) ;
}
if ( selectExpression . Tags . Contains ( "DeepSkip" ) )
Sql . Append ( "SELECT " ) ;
{
}
if ( selectExpression . IsDistinct )
else
{
{
Sql . Append ( "DISTINCT " ) ;
GenerateTop ( selectExpression ) ;
}
}
if ( selectExpression . Projection . Any ( ) )
{
GenerateList ( selectExpression . Projection , e = > Visit ( e ) ) ;
}
else
{
Sql . Append ( "1" ) ;
}
List < ColumnExpression > colexp = new List < ColumnExpression > ( ) ;
if ( selectExpression . Tags . Contains ( "DeepSkip" ) )
// Implement Jet's non-standard JOIN syntax and DUAL table workaround.
{
// TODO: This does not properly handle all cases (especially when cross joins are involved).
if ( selectExpression . Tables . Any ( ) )
{
Sql . AppendLine ( )
. Append ( "FROM " ) ;
const int maxTablesWithoutBrackets = 2 ;
}
else
{
GenerateTop ( selectExpression ) ;
}
Sql . Append (
new string (
'(' ,
Math . Max (
0 ,
selectExpression
. Tables
. Count ( t = > ! ( t is CrossJoinExpression | | t is CrossApplyExpression ) ) -
maxTablesWithoutBrackets ) ) ) ;
for ( var index = 0 ; index < selectExpression . Tables . Count ; index + + )
if ( selectExpression . Projection . Any ( ) )
{
{
var tableExpression = selectExpression . Tables [ index ] ;
GenerateList ( selectExpression . Projection , e = > Visit ( e ) ) ;
}
else
{
Sql . Append ( "1" ) ;
}
var isApplyExpression = tableExpression is CrossApplyExpression | |
List < ColumnExpression > colexp = new List < ColumnExpression > ( ) ;
tableExpression is OuterApplyExpression ;
// Implement Jet's non-standard JOIN syntax and DUAL table workaround.
// TODO: This does not properly handle all cases (especially when cross joins are involved).
if ( selectExpression . Tables . Any ( ) )
{
Sql . AppendLine ( )
. Append ( "FROM " ) ;
const int maxTablesWithoutBrackets = 2 ;
Sql . Append (
new string (
'(' ,
Math . Max (
0 ,
selectExpression
. Tables
. Count ( t = > ! ( t is CrossJoinExpression | | t is CrossApplyExpression ) ) -
maxTablesWithoutBrackets ) ) ) ;
for ( var index = 0 ; index < selectExpression . Tables . Count ; index + + )
{
var tableExpression = selectExpression . Tables [ index ] ;
var isCrossExpression = tableExpression is CrossJoinExpression | |
var isApplyExpression = tableExpression is CrossApply Expression | |
tableExpression is CrossApplyExpression ;
tableExpression is Outer ApplyExpression;
if ( isApplyExpression )
var isCrossExpression = tableExpression is CrossJoinExpression | |
{
tableExpression is CrossApplyExpression ;
throw new InvalidOperationException (
"Jet does not support APPLY statements. Switch to client evaluation explicitly by inserting a call to either AsEnumerable(), AsAsyncEnumerable(), ToList(), or ToListAsync() if needed." ) ;
}
if ( index > 0 )
if ( isApplyExpression )
{
if ( isCrossExpression )
{
{
Sql . Append ( "," ) ;
throw new InvalidOperationException (
}
"Jet does not support APPLY statements. Switch to client evaluation explicitly by inserting a call to either AsEnumerable(), AsAsyncEnumerable(), ToList(), or ToListAsync() if needed." ) ;
else if ( index > = maxTablesWithoutBrackets )
{
Sql . Append ( ")" ) ;
}
}
Sql . AppendLine ( ) ;
if ( index > 0 )
}
List < ColumnExpression > tempcolexp ;
if ( tableExpression is InnerJoinExpression expression )
{
SqlBinaryExpression ? binaryJoin = expression . JoinPredicate as SqlBinaryExpression ;
tempcolexp = ExtractColumnExpressions ( binaryJoin ! ) ;
bool refrencesfirsttable = false ;
foreach ( ColumnExpression col in tempcolexp )
{
{
if ( col. Table = = selectExpression . Tables [ 0 ] )
if ( isCrossExpression )
{
{
refrencesfirsttable = true ;
Sql . Append ( "," ) ;
break ;
}
else if ( index > = maxTablesWithoutBrackets )
{
Sql . Append ( ")" ) ;
}
}
}
if ( refrencesfirsttable )
Sql . AppendLine ( ) ;
{
Visit ( tableExpression ) ;
continue ;
}
}
else
{
List < ColumnExpression > tempcolexp ;
colexp . AddRange ( tempcolexp ) ;
if ( tableExpression is InnerJoinExpression expression )
}
/ * if ( expression . JoinPredicate is SqlBinaryExpression { Left : ColumnExpression left , Right : ColumnExpression right } )
{
{
var lt = left . Table = = selectExpression . Tables [ 0 ] ;
SqlBinaryExpression ? binaryJoin = expression . JoinPredicate as SqlBinaryExpression ;
var rt = right . Table = = selectExpression . Tables [ 0 ] ;
tempcolexp = ExtractColumnExpressions ( binaryJoin ! ) ;
if ( lt | | rt )
bool refrencesfirsttable = false ;
foreach ( ColumnExpression col in tempcolexp )
{
if ( col . Table = = selectExpression . Tables [ 0 ] )
{
refrencesfirsttable = true ;
break ;
}
}
if ( refrencesfirsttable )
{
{
Visit ( tableExpression ) ;
Visit ( tableExpression ) ;
continue ;
continue ;
}
}
else
else
{
{
colexp . Add ( left ) ;
colexp . AddRange ( tempcolexp ) ;
colexp . Add ( right ) ;
}
}
} * /
Sql . Append ( "LEFT JOIN " ) ;
/ * if ( expression . JoinPredicate is SqlBinaryExpression { Left : ColumnExpression left , Right : ColumnExpression right } )
Visit ( expression . Table ) ;
{
Sql . Append ( " ON " ) ;
var lt = left . Table = = selectExpression . Tables [ 0 ] ;
Visit ( expression . JoinPredicate ) ;
var rt = right . Table = = selectExpression . Tables [ 0 ] ;
}
if ( lt | | rt )
else
{
{
Visit ( tableExpression ) ;
Visit ( tableExpression ) ;
continue ;
}
else
{
colexp . Add ( left ) ;
colexp . Add ( right ) ;
}
} * /
Sql . Append ( "LEFT JOIN " ) ;
Visit ( expression . Table ) ;
Sql . Append ( " ON " ) ;
Visit ( expression . JoinPredicate ) ;
}
else
{
Visit ( tableExpression ) ;
}
}
}
}
}
}
else
else
{
GeneratePseudoFromClause ( ) ;
}
if ( selectExpression . Predicate ! = null | | colexp . Count > 0 )
{
Sql . AppendLine ( )
. Append ( "WHERE " ) ;
if ( selectExpression . Predicate ! = null )
{
{
if ( colexp . Count > 0 ) Sql . Append ( "(" ) ;
GeneratePseudoFromClause ( ) ;
Visit ( selectExpression . Predicate ) ;
if ( colexp . Count > 0 ) Sql . Append ( ")" ) ;
}
}
if ( selectExpression . Predicate ! = null && colexp . Count > 0 )
if ( selectExpression . Predicate ! = null | | colexp . Count > 0 )
{
{
Sql . Append ( " AND (" ) ;
Sql . AppendLine ( )
}
. Append ( "WHERE " ) ;
if ( colexp . Count > 0 )
if ( selectExpression . Predicate ! = null )
{
int ct = 0 ;
foreach ( var exp in colexp )
{
{
if ( ! string . IsNullOrEmpty ( exp . TableAlias ) )
if ( colexp . Count > 0 ) Sql . Append ( "(" ) ;
{
Visit ( selectExpression . Predicate ) ;
Sql . Append ( $"`{exp.TableAlias}`." ) ;
if ( colexp . Count > 0 ) Sql . Append ( ")" ) ;
}
}
Sql . Append ( $"`{exp.Name}` IS NOT NULL" ) ;
if ( ct < colexp . Count - 1 )
if ( selectExpression . Predicate ! = null & & colexp . Count > 0 )
{
Sql . Append ( " AND (" ) ;
}
if ( colexp . Count > 0 )
{
int ct = 0 ;
foreach ( var exp in colexp )
{
{
ct + + ;
if ( ! string . IsNullOrEmpty ( exp . TableAlias ) )
Sql . Append ( " AND " ) ;
{
Sql . Append ( $"`{exp.TableAlias}`." ) ;
}
Sql . Append ( $"`{exp.Name}` IS NOT NULL" ) ;
if ( ct < colexp . Count - 1 )
{
ct + + ;
Sql . Append ( " AND " ) ;
}
}
}
}
}
if ( selectExpression . Predicate ! = null & & colexp . Count > 0 )
{
Sql . Append ( ")" ) ;
}
}
}
if ( selectExpression . Predicate ! = null & & colexp . Count > 0 )
if ( selectExpression . GroupBy . Count > 0 )
{
{
Sql . Append ( ")" ) ;
Sql . AppendLine ( )
. Append ( "GROUP BY " ) ;
GenerateList ( selectExpression . GroupBy , e = > Visit ( e ) ) ;
}
}
}
if ( selectExpression . GroupBy. Count > 0 )
if ( selectExpression . Having ! = null )
{
{
Sql . AppendLine ( )
Sql . AppendLine ( )
. Append ( " GROUP BY ") ;
. Append ( " HAVIN G ") ;
GenerateList ( selectExpression . GroupBy , e = > Visit ( e ) ) ;
Visit ( selectExpression . Having ) ;
}
}
if ( selectExpression . Having ! = null )
GenerateOrderings ( selectExpression ) ;
{
GenerateLimitOffset ( selectExpression ) ;
Sql . AppendLine ( )
. Append ( "HAVING " ) ;
Visit ( selectExpression . Having ) ;
}
}
GenerateOrderings ( selectExpression ) ;
GenerateLimitOffset ( selectExpression ) ;
if ( selectExpression . Alias ! = null )
if ( selectExpression . Alias ! = null )
{
{
subQueryIndent ! . Dispose ( ) ;
subQueryIndent ! . Dispose ( ) ;
Sql . AppendLine ( )
Sql . AppendLine ( )
. Append ( ")" + AliasSeparator + _sqlGenerationHelper . DelimitIdentifier ( selectExpression . Alias ) ) ;
. Append ( ")" )
. Append ( AliasSeparator )
. Append ( _sqlGenerationHelper . DelimitIdentifier ( selectExpression . Alias ) ) ;
}
}
return selectExpression ;
return selectExpression ;
Christopher Jolly
2 years ago