Commit Graph

1199 Commits (fbc48fafb0b90d6586c15b642a36c139f3c1685e)

Author SHA1 Message Date
Gabriel Dos Reis 520087569f Merge pull request #943 from galik/fix_unique_target_case
Fix case of unique anchors to match others
9 years ago
Bledson Kivy d240b7611e `#include`d instead of `#included` 9 years ago
Zachary Henkel 3c867e5079 Final style changes 9 years ago
Zachary Henkel 2ef544d4ad Additional formatting 9 years ago
Zachary Henkel abd71982da Another try with the linter 9 years ago
Zachary Henkel ca35984813 Try to make the linter happy 9 years ago
Andrew Pardoe c7733a398a Updating date 9 years ago
galik 7cf5f01bad Fix case if unique anchors to match others
SL.str.5, SL.str.10, SL.str.11, SL.str.12
9 years ago
Gabriel Dos Reis 07d2413d80 Merge pull request #939 from galik/fix_item_tags
Fix various item tags (missing colons)
9 years ago
galik fa50221dd0 Fix various item tags (missing colons)
I.2, C.10, A.1, A.2, A.4, NL.5
9 years ago
Gabriel Dos Reis 9e29780db6 Merge pull request #937 from ProgramMax/add-missing-period
Add missing period
9 years ago
Chris Blume ea50b4ea78 Add missing period 9 years ago
Sergey Zubkov d816cc5705 travis CI fixes 9 years ago
Zachary Henkel 2cd9993ae4 Revise cast guidance following upstream edits 9 years ago
Zachary Henkel 9ef1d51c34 Merge from https://github.com/isocpp/CppCoreGuidelines 9 years ago
Bjarne Stroustrup 6c3620d1e8 minor cleanup 9 years ago
Malcolm Parsons 4dfe88b716 Fix broken links (#935) 9 years ago
Sergey Zubkov 531a8a5ebd travis CI fixes and other typos 9 years ago
Shalom Craimer 5f5d5d8ca6 Fixing link to C.146 to be valid, and a link to ??? to be unlinked (#934)
this fixes links and the issues discovered by travis CI
9 years ago
Bjarne Stroustrup 5975f4d5db more bounds profile reorganization 9 years ago
Bjarne Stroustrup df160f3654 Most of the bounds safety profile 9 years ago
Bjarne Stroustrup 9eb18fdf9e vector exception to {} initializers 9 years ago
Bjarne Stroustrup 9d44e718eb Reorganized the Type safety profile 9 years ago
Andrew Pardoe c721b2c325 Merge pull request #931 from sizeofvoid/master
fix: unsigned int value comment
9 years ago
Bjarne Stroustrup 5da51a9a44 more work on anchors 9 years ago
Bjarne Stroustrup 9d283bc451 anchors for Type.* 9 years ago
Bjarne Stroustrup 986106c63c more Type.* reorganization 9 years ago
Bjarne Stroustrup e2719d035b Reorganize Type.1-3 9 years ago
Bjarne Stroustrup 6e86c182f9 Don't detach, rename raii_thread to joining_thread
Addressing #925 . Please review carefully. #925 is tricky.
9 years ago
Sergey Zubkov 96a41a4a6e travis CI fixes 9 years ago
Bjarne Stroustrup a1f59395bb modifications to C.43
Issue #544
9 years ago
Sergey Zubkov 85cb14703c travis CI fixes 9 years ago
Bjarne Stroustrup aabfe119d3 typo fix 9 years ago
Rafael Sadowski a591b3c279 fix: unsigned int value comment 9 years ago
Bjarne Stroustrup 14ef2cde84 add rules against use of unsigned
addresses #571
9 years ago
Bjarne Stroustrup 50576c0144 issue #841
SF.10: Avoid dependencies on implicitly `#included` names
9 years ago
Bjarne Stroustrup 974fdf4661 improve I.11
as suggested in #552
9 years ago
Bjarne Stroustrup fa1d0e5995 exceptionsand const
Added to E.15
9 years ago
Bjarne Stroustrup 81493f331c Undid untentional change to C.85 9 years ago
Bjarne Stroustrup 7206b618a4 C.86 example accesses private members #541
fixed
9 years ago
Bjarne Stroustrup 9620ea8d43 I.30: Encapsulate rule violations
Fiexed #893 by moving the bad example from ES.28 to a new rule: I.30:
Encapsulate rule violations.

I may inadvertenly have invented a new suppression syntax
9 years ago
Bjarne Stroustrup 17ccab5836 Fix C.139 9 years ago
hsutter b10ffdf55f Reversed order of Lifetime.1 and .2 9 years ago
hsutter ff9bce8035 Add Lifetime.1-3 rules so tools can refer to them 9 years ago
Zachary Henkel f1b348e0db Additional guidance around casts:
- Warn on unnecessary casts
- Avoid casts on arithmetic types
- Add specializations of the rules for Pro-type-reinterpretcast
9 years ago
Sergey Zubkov 17715010a2 travis CI fixes and grammar fix from #920 9 years ago
Andrew Pardoe b09b9ad8b9 Updating date & typos 9 years ago
Andrew Pardoe bec67d690a Merge pull request #914 from AndrewPardoe/issue911
Clarify I.11 with regards to recommending smart pointers/owner<T>.
9 years ago
Andrew Pardoe 52eca9a174 Merge pull request #917 from scraimer/master
C.148 adding Reason and Example
9 years ago
Andrew Pardoe 2e1d9c34d4 Merge pull request #920 from cubbimew/issue899
CP.111 more precise motivation and examples
9 years ago
Andrew Pardoe d5ea1fcc4f Merge pull request #922 from AndrewPardoe/issue-918
Fix anchors in C.147/148
9 years ago
Gabriel Dos Reis 52aa9ba997 Fix #903. 9 years ago
Andrew Pardoe e354279e0e Fix anchors in C.147/148 9 years ago
Bjarne Stroustrup ad6f863152 Added not about notation to Con.2
in response to #902
9 years ago
Sergey Zubkov f41d36ff25 CP.111 more precise motivation and examples 9 years ago
Bledson Kivy 7c90bdba50 Intended heading level?
Following the heading levels throughout the doc, it seems these are typos.
9 years ago
Shalom Craimer 12f0954f66 Fixed the errors detected by Travis CI and @jwakely 9 years ago
Shalom Craimer cdf2e7e5ea Fixed the errors detected by Travis CI and @jwakely 9 years ago
Jonathan Wakely bdb5d27a10 Remove spaces before ptr-declarators in examples 9 years ago
Shalom Craimer 1c53b29a3a C.148 - Fixing Travis-reported errors discovered so far in the code example 9 years ago
Shalom Craimer b6132db539 C.148 adding Reason and Example 9 years ago
Andrew Pardoe 343f40792a Clarify I.11 with regards to recommending smart pointers/owner<T>. 9 years ago
Sergey Zubkov f0239407ad travis fixes 9 years ago
Andrew Pardoe 03c2b4699d Updating date 9 years ago
Jonathan Wakely 32d6313607 Improve example for ES.45
Fixes #895
9 years ago
Andrew Pardoe a96fed9c99 Merge pull request #896 from tlanc007/master
ES.45/ES.46 renamed and reordered to match anchors found later in file
9 years ago
Gabriel Dos Reis 0ff5518dca Merge pull request #905 from ewoudvc/es24_toc_rule_correction
ES.24: have TOC rule match body rule
9 years ago
Andrew Pardoe b41bea68c1 Merge pull request #909 from tvaneerd/patch-2
Note -> Not, are -> is
9 years ago
Gabriel Dos Reis f9f3422ac5 Fix C.183. 9 years ago
Gabriel Dos Reis 918a5695c7 Address C.128: say 'avoid'. 9 years ago
Tony Van Eerd 481996c849 Note -> Not, are -> is 9 years ago
Bjarne Stroustrup e0de4df83b added clarifying note for C.139 9 years ago
Bjarne Stroustrup b3584cfa5f added reference to C.137 9 years ago
Bjarne Stroustrup a6a087dfc5 regular added to glossary 9 years ago
Bjarne Stroustrup 64622d5cca testing
and fixing one "thinko"
9 years ago
ewoudvc caa86ae38b GSL.assert: replace is by are (#908) 9 years ago
Jonathan Wakely e3fe0c5b5e Fix indentation of NR.1 example 9 years ago
Ewoud Van Craeynest 10805fb7a1 ES.24: have TOC rule match body rule 9 years ago
Sergey Zubkov 94a7a3fd46 travis CI fixes, one more time 9 years ago
Bjarne Stroustrup 046d62c51e minor improvements to SL.io 9 years ago
Sergey Zubkov c99a366bba travis CI fixes 9 years ago
Bjarne Stroustrup 4f9a6c89be banning exception specifications
a bit more abut exceptions; the beginnings of I/O
9 years ago
Bjarne Stroustrup 1e38eb8ae7 ban longjmp 9 years ago
Bjarne Stroustrup 5397c9c5fe very minor typo
testing
9 years ago
Bjarne Stroustrup 1b7d217cd1 nothing 9 years ago
Tal Lancaster 5306795214 ES.45/ES.46: renamed and reordered to match jump tags
The anchors later in the file were using 46 for narrowing and 45 for
magic.  Renamed and reordered the tags in the TOC to match.
9 years ago
Sergey Zubkov 2a098a2b39 travis CI fixes 9 years ago
Bjarne Stroustrup df8a441dcf fix bug in C.9 example
a real-world example would be an improvement
9 years ago
Bjarne Stroustrup d1ff56d07e date 9 years ago
Bjarne Stroustrup cfa2fec1f2 C.137 9 years ago
Bjarne Stroustrup 6987bfd2f0 C.9 and C.133 9 years ago
Bjarne Stroustrup 05118054f6 NL.11 literals 9 years ago
Bjarne Stroustrup e30bb60320 more xrefs 9 years ago
Louis Brandy 540c393501 Merge pull request #892 from lbrandy/master
Example of an inheritance hierarchy for C.120.
9 years ago
Sergey Zubkov 04537cdb11 travis CI fixes 9 years ago
Sergey Zubkov 74ab713700 travis CI and some typo fixes
had to drop runtime/printf from the checks because it bans strcpy
9 years ago
Bjarne Stroustrup 54f57d8d1b more language feature xrefs
These xrefs are menat part as teasers to get language-feature obsessed
programmers to look at the guidelines and partly to cover topics that
appears in several places. They are not meant to be complete
9 years ago
Bjarne Stroustrup 6fa4cb32cd more language feature xrefs 9 years ago
Bjarne Stroustrup e144bd4f9b minor 9 years ago
Louis Brandy 29fdd0d30c Attempt to add an example (that is as non-controversial as possible) of an inheritance hierarchy to C.120 9 years ago
Andrew Pardoe f1d3846300 updating date 9 years ago
hsutter 0ff543fe19 Addresses #568 9 years ago
hsutter 323912e609 A pass at improving F.52. Closes #884 9 years ago
Bjarne Stroustrup 6d01cfd99b more language term examples 9 years ago
Bjarne Stroustrup c46bebc58f idea for language feature xref 9 years ago
Bjarne Stroustrup 1b5f6d0c97 change "concepts lite" to "concepts" 9 years ago
Bjarne Stroustrup 098dd3ee90 add example to NR.1 9 years ago
Bjarne Stroustrup 13ee61a3cb start of impact statements for profiles 9 years ago
Bjarne Stroustrup fc5222ca26 Added a first cut of string guidelines 9 years ago
Bjarne Stroustrup 6bcfaa4fbe Clarify that finally() is a last resort
E.6 and E.19
9 years ago
Andrew Pardoe a8572ad328 Update link to iso.org per #888 9 years ago
Sergey Zubkov d71d95a4b6 travis CI fixes 9 years ago
Bjarne Stroustrup 0b58d04fde ES.84 9 years ago
Bjarne Stroustrup 6a3d61fd8d a few more fix-ups in ES.* 9 years ago
Bjarne Stroustrup 26d56a2f54 More changes to ES.*
break and continue
goto
fallthrough
when to use "default"
order of evaluation (C++17)
9 years ago
Bjarne Stroustrup 1f948653bb Cleanup of ES.7*
also ES.10: structured binding
and ES.28: eliminating an owning reference
9 years ago
Andrew Pardoe 960f6dad1c updating date 9 years ago
Andrew Pardoe 0aa9994e54 whitespace for formatting 9 years ago
Andrew Pardoe 5b1043104c Resolving issue #662 9 years ago
Bjarne Stroustrup fbeff91d05 typos 9 years ago
Bjarne Stroustrup cbb3de625e add example to F.21 9 years ago
Neil MacIntosh b0cd06aa2e Updated note in C.131 to add clarity. 9 years ago
Bjarne Stroustrup 45e11be0ad added example to C.136 9 years ago
Bjarne Stroustrup 13d6eff946 improving SF.6
In respose to  #725
9 years ago
Bjarne Stroustrup 5080166d3c fix ES.10 9 years ago
Sergey Zubkov 83566ba7d1 travis fixes 9 years ago
Jonathan Wakely 65aa60fe10 Clarify that synchronized_value is not standardised yet 9 years ago
Jonathan Wakely 85543a94e9 Replace invalid uses of defer_lock in C.21 with adopt_lock 9 years ago
Anthony Williams 1b51c917d0 Expanded CP.50 to reference synchronized_value<T> 9 years ago
Anthony Williams f15d001ba0 Added note about detached threads racing with global destructors 9 years ago
Anthony Williams ce93de647a Added reference to variadic scoped_lock to CP.21 9 years ago
Andrew Pardoe 795efa71f7 missed one space 9 years ago
Andrew Pardoe f9f35c78bc adding space after includes per #769 9 years ago
Andrew Pardoe 49abfa6509 Merge pull request #780 from zingsheim/T.84.Link_base
T.84 Correction of Example: Change type of suc and pre to Link_base
9 years ago
Neil MacIntosh 907de2aa4c Corrected mistake in enforcement for R.3. 9 years ago
Neil MacIntosh deb47c0c47 Corrected obsolete syntax in span examples. 9 years ago
Andrew Pardoe 8caa0fe007 updating date 9 years ago
Andrew Pardoe de099e2b57 adding punctuation 9 years ago
Andrew Pardoe cc284d260f Merge remote-tracking branch 'refs/remotes/origin/master' 9 years ago
Andrew Pardoe e19aed0ef3 Update glossary per issue 820 9 years ago
Neil MacIntosh 33098ab31e Updated guidance on noexcept on destructors (#814) 9 years ago
hsutter 38a6acc1c0 Closes #827
Stated the main two reasons why functions with lots of parameters exist:
Because they're missing an abstraction, or because the function is
trying to do more than one job.
Added explicit coverage of those reasons and another example
illustrating that.
9 years ago
Andrew Pardoe b8b178e98a Merge pull request #867 from tkruse/fix-warnings
Fix travis warnings, includes other PRS
9 years ago
Neil MacIntosh c6f8afc931 Updated example of enforcement suppression. 9 years ago
Jacob Langley 2c8b34653d Add a line to help remark identify code block inside bullet list 9 years ago
Jacob Langley a2dba2e78b Fix cpplint issues
Rconc-create0.cpp:20:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
Res-always5.cpp:15:  Missing space after ,  [whitespace/comma] [3]
Rp-lib0.cpp:15:  Missing space after ,  [whitespace/comma] [3]
Rs-using-directive0.cpp:25:  Extra space after ( in function call  [whitespace/parens] [4]
Rs-using-directive0.cpp:25:  Extra space before )  [whitespace/parens] [2]
9 years ago
Jacob Langley 48b40df328 Fix markdown lint errors
11979:3          warning  Incorrect indentation before bullet: remove 1 space  list-item-bullet-indent
19412:1-19462:23   warning  Missing blank line before block node                 no-missing-blank-lines
9 years ago
Jacob Langley 04fd2a5807 Fix spellcheck errors
Line 1037: analyser -> analyses
Line 2399: yu -> yew
Line 3745: funtions -> functions
Line 3748: multimethods -> multi methods
Line 6652: mixins -> mixing
Line 11991: unittests -> unittest
9 years ago
Kevin Kennedy b9a1ed62e9 Change Unicode EN SPACE (U+2002) characters to SPACE (U+0020) so that Pandoc-generated LaTeX can compile without Error 9 years ago
Andrew Pardoe 5408dd3e75 updating date 9 years ago
hsutter ba3c4b5692 Updated example for Con.1
The original example was good, but it used a reference where the point
of Con.1 is about declaring objects themselves const
9 years ago
hsutter dfb2a5b1fe Minor consistency cleanup
- Fixed an inconsistent title (section ToC and actual guideline title
differed)
- Can't reseat a reference, so changed it to pointer
- Removed what I think is a stray/outdated rule against passing
move-only types (unique_ptr) by &&
- Reordered a three-line example for logical flow
9 years ago
hsutter 55780020c1 Added lifetime profile placeholder 9 years ago
hsutter 398d3a7400 Added Bounds.* section index 9 years ago
hsutter e436db0a0e Type.5.1 actually belongs after Type.4
So making it Type.4.1 for now
9 years ago
hsutter 901b301b1f Updated refresh date 9 years ago
hsutter 42da80ef76 Fixed numbering in Type section
There were two Type.7's. Renumbered one of them to .5.1 for now, and
fixed the section table of contents.
9 years ago
hsutter 0af5e31eb2 Closes #836 9 years ago
hsutter 33adf1eede Elaborated on #835.
Incorporating @cubbimew's comments. Thanks!
9 years ago
hsutter 3b3148d99c Closes #835
We do not encourage `owner<T&>`.
9 years ago
hsutter 0bb2de37a0 Closed 856 and 857
Added C++17-specific text in ES.6 for `if` and `switch` initializers.

Note that the Guidelines assume C++14, so the "Enforcement" clauses for
C++17-specific rules will be separate until we assume people have broad
access to C++17 features in their compilers. Once that happens we can
roll the C++17-specific parts into the main text.
9 years ago
Jonathan Wakely c7c5614a42 Fix spelling typos 9 years ago
Jonathan Wakely 464870c7d3 Fix some markdown warnings seen in the Travis CI checks 9 years ago
Andrew Pardoe 52ad087bb3 Merge pull request #845 from jacobl-at-ms/jacobl.macbuild
Enable building directly on a mac
9 years ago
Herb Sutter 3f2e675f7d Merge pull request #763 from Eliyahu-Ravuna/patch-1
Exception of CP.100 refined to include the "sequentially consistent memory model" only
9 years ago
Gabriel Dos Reis 2b6d208d58 Merge pull request #777 from cubbimew/nvi
dropping NVI from proto-rules due to no consensus on #768
9 years ago
Bjarne Stroustrup bd5f0c34db Merge branch 'master' into bs-local-1 9 years ago
Bjarne Stroustrup c5cecf1e88 new rule F.9; unused parameters
Issue #808
9 years ago
Bjarne Stroustrup 631bbbbaf8 typos MI and membership 9 years ago
Jacob Langley eb4be01970 Fix spelling errors 9 years ago
Bjarne Stroustrup 87bb531080 tools and library rules
in philosophy
9 years ago
Andrew Pardoe 47e5764e6e Update date 9 years ago
Andrew Pardoe 9ddb9e1648 Merge parts of PR #787 9 years ago
Andrew Pardoe 20403c8d6d Merge branch 'thread-tooling' of https://github.com/tituswinters/CppCoreGuidelines into tituswinters-thread-tooling 9 years ago
Andrew Pardoe 11e5e00f23 Merge pull request #818 from cubbimew/c138
C.138 initial content
9 years ago
Bjarne Stroustrup f2dfcfc438 minor cleanup 9 years ago
Jonathan Wakely 14f67ae8dd Fix typos from commit 9858685786 9 years ago
hsutter 8f2ecf0665 Closed #557
Added example from the issue
9 years ago
hsutter 51b4cddbca Closed #810
Added an example to SF.7
Clarified SF.6 and SF.7 that "using-directive" means "using namespace"
9 years ago
Andrew Pardoe 9858685786 Clarifying title per issue 793 9 years ago
teassy000 8a9bb3bc61 fix c.127 example issue. (#789)
auto will deduce as unique_ptr<D> and the correct destructor will call. Anyway, this should be a bad example.
9 years ago
Sergey Zubkov 4d86abfdb4 When the title of ES.56 was changed, its entry in the ES ToC wasn't (#831) 9 years ago
Sergey Zubkov 0b4b815d0b uncross links to the self-assignment rules (#830) 9 years ago
Andrew Pardoe 51191c13d2 Merge pull request #825 from johelegp/interfaces_non_trivial_fixes
I: Enforcement fixes/completion
9 years ago
Gabriel Dos Reis dd7275623d Merge pull request #834 from cubbimew/c131-constify
C.131: getters should be const member functions
9 years ago
Sergey Zubkov bee5e87e90 C.131: getters should be const member functions 9 years ago
Sergey Zubkov 808d304687 C.127 should not claim that there is a defined behavior 9 years ago
mancoast 63582c929e Rework of English Language style 9 years ago
Gabriel Dos Reis 655bbcafa8 Merge pull request #824 from johelegp/interfaces_fixes
I: Grammar, spacing and typo fixes
9 years ago
Gabriel Dos Reis 94fdad103d Merge pull request #823 from johelegp/gsl_concept_dead_link_fix
GSL.concept: Dead link fix
9 years ago
Gabriel Dos Reis c040dfab55 Merge pull request #822 from johelegp/gsl_fixes
GSL: Grammar, spacing and markdown fixes
9 years ago
Johel Ernesto Guerrero Peña 2b3e249cff I: Grammar, spacing and typo fixes 9 years ago
Johel Ernesto Guerrero Peña 5f95cb2734 I: Enforcement fixes/completion 9 years ago
Johel Ernesto Guerrero Peña 3bb9192d66 GSL: Grammar, spacing and markdown fixes 9 years ago
Johel Ernesto Guerrero Peña bb4202ed92 GSL.concept: Dead link fix
Described in #407, 4a9e41d7 added the section but didn't fix the links.
9 years ago
Johel Ernesto Guerrero Peña d30134b150 P: Grammar, correction and typo fixes 9 years ago
Sergey Zubkov a968af59d0 C.138 initial content 9 years ago
Andrew Pardoe 9cfa3eafd7 Updating date 9 years ago
Andrew Pardoe 4f2a64b920 Per our discussion, C.42 enforcement belongs to C.41 9 years ago
hsutter 882d88ebe5 Closed #809. 9 years ago