f6ba91e90a
update date
9 years ago
5ffabce718
Fix Inconsistent definition of czstring in comments
...
Comments in sections SL.str.3 and GSL.view disagree on whether czstring may be the nullptr.
This PR fixes the first comment definition in SL.str.3 that czstring `is a C-style string that is not the nullptr`
### SL.str.3: Use zstring or czstring to refer to a C-style, zero-terminated, sequence of characters
```
void f1(zstring s); // s is a C-style string or the nullptr
void f1(czstring s); // s is a C-style string that is not the nullptr
```
### GSL.view: Views
`zstring` // a `char*` supposed to be a C-style string; that is, a zero-terminated sequence of `char` or `nullptr`
`czstring` // a `const char*` supposed to be a C-style string; that is, a zero-terminated sequence of const `char` or `nullptr`
9 years ago
0b1b5bbac8
Fix if statement for checking error condition
...
Example mentions that it handles error, and errors are commonly non-zero values.
Closes #970
9 years ago
66fc5d4f5c
Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines
9 years ago
7ba2317992
Updating date
9 years ago
a3860f3cc2
Merge pull request #971 from tkruse/style-fixes2
...
Style fixes for compile-time, run-time and similar
9 years ago
d13bfcda64
Consistent hyphenation of ajectives like lock-free, well-defined, old-style,...
9 years ago
015ee8df10
make 'non-' prefix spelling consistent
9 years ago
9159315d8c
make non-`const` spelling consistent
9 years ago
ba82be70bd
make 'side effect' vs. 'side-effect' spelling consistent
9 years ago
172520b570
make 'reuse' vs. 're-use' spelling consistent
9 years ago
d14067a5b4
make 'error-prone' usage consistent
9 years ago
9aa9e8fc9f
fix hyphenation of ...-allocated adcjectives
9 years ago
95b001c0d8
fix hyphenation of open-source
9 years ago
00f9e9ae50
fix bad hyphen for standard-library as adjective
9 years ago
d28a46983e
Fix missing comma
9 years ago
b4c1e30743
Make usage of run-time, compile-time, lifetime, real-time and hard-real-time consistent
9 years ago
f70ca3ee9e
Consistent formatting of interval ranges
9 years ago
69d2341c1e
Fixing edit fail
9 years ago
b3b329f937
Fixing up suggestions from Issues 505 and 496
9 years ago
2bd4a7c9ad
Fix Enforcement for C.151 after PR #952
9 years ago
8c0f764b77
Merge pull request #952 from tkruse/code-fixes
...
small issues found trying to compile examples
9 years ago
24fa6d4b00
Added break to each case in switch statement
9 years ago
b02eb91b84
code fixes
9 years ago
22c305fdee
travis fixes and a typo
9 years ago
70655d1131
Fix typos and change spellcheck call to not check URLs ( #961 )
9 years ago
e12e73e670
ES.34 Add alternative example.
9 years ago
03dc7d3f44
Updating date
9 years ago
9472111c6c
Talk materials list
...
Issue #929 .
It would be nice to have more material, and I haven't yet uploaded all
slides.
9 years ago
8cc76e2c38
Fix Enum.4 example
...
Issue #716
9 years ago
5393fab88f
labels missing
...
#938 . I have inserted a temporary fix. We need to re-work the whole
discussions section
9 years ago
5e2f9064b2
Merge pull request #927 from ZachHenkel/master
...
Additional guidance around casts:
9 years ago
19da9a1d03
Merge pull request #950 from cubbimew/pimpl
...
New rule: I.27 Pimpl
9 years ago
0048b15ead
fix mismatch between title and toc for F.22
9 years ago
5205a4e567
updating date
9 years ago
c0b1ea189f
Merge pull request #958 from xfix/patch-1
...
Rename rnd to round in I.1
9 years ago
18e8e91745
Merge pull request #957 from eliaskosunen/master
...
Add braces to for loop in P.1 example
9 years ago
ba3bdb1f40
Merge pull request #949 from robert-andrzejuk/patch-2
...
Minor typo (I think)
9 years ago
7367e07598
Rename rnd to round in I.1
...
At first, I assumed that this is "rand" function, not "round" function,
and was confused why exactly is it a problem that this returns
different values. While it's easy to notice when actually reading the
code, this slows down the comprehension, and bad function naming is
not point of that particular guideline.
9 years ago
7763b97b52
Add braces to for loop in P.1 example
...
`for` with no `block-statement` as its `statement` is bad practice and should not be shown in an example. This example is meant to demonstrate code duplication and expessiveness, not to show poor usage of braces or lack thereof.
9 years ago
6907911089
Updating date
9 years ago
d5667c5f8a
Minor typo
...
I think a minor typo got itself in ... the second 'string_span' should be string_view.
9 years ago
974d6a2090
Fix link to constructor virtual
9 years ago
d4d48ec772
Fix tense, semantic error
9 years ago
fe9861d98a
New rule: I.27 Pimpl
9 years ago
906ae347f3
travis CI fixes
9 years ago
c355df948f
reorganize the lifetime profile description
9 years ago
11e92eb4c5
Fix Markdown rendering failure
...
Use of <iostream> without backticks causes the Markdown render to fail
from this point onwards on GitHub pages.
9 years ago
f3ff5bae6d
Clarify "unnecessary cast" by decomposing the class into identity casts and implicit casts.
9 years ago
9cc50836bd
Diverse style fixes
...
Remove whitespace at end of line
fix code indent
whitepsace between operators
align comments
add method name to fix syntax highlighting
typo: start with capital letter
Apply snake-case naming for unctions (for consistency)
9 years ago
520087569f
Merge pull request #943 from galik/fix_unique_target_case
...
Fix case of unique anchors to match others
9 years ago
d240b7611e
`#include`d instead of `#included`
9 years ago
3c867e5079
Final style changes
9 years ago
2ef544d4ad
Additional formatting
9 years ago
abd71982da
Another try with the linter
9 years ago
ca35984813
Try to make the linter happy
9 years ago
c7733a398a
Updating date
9 years ago
7cf5f01bad
Fix case if unique anchors to match others
...
SL.str.5, SL.str.10, SL.str.11, SL.str.12
9 years ago
07d2413d80
Merge pull request #939 from galik/fix_item_tags
...
Fix various item tags (missing colons)
9 years ago
fa50221dd0
Fix various item tags (missing colons)
...
I.2, C.10, A.1, A.2, A.4, NL.5
9 years ago
9e29780db6
Merge pull request #937 from ProgramMax/add-missing-period
...
Add missing period
9 years ago
ea50b4ea78
Add missing period
9 years ago
d816cc5705
travis CI fixes
9 years ago
2cd9993ae4
Revise cast guidance following upstream edits
9 years ago
9ef1d51c34
Merge from https://github.com/isocpp/CppCoreGuidelines
9 years ago
6c3620d1e8
minor cleanup
9 years ago
4dfe88b716
Fix broken links ( #935 )
9 years ago
531a8a5ebd
travis CI fixes and other typos
9 years ago
5f5d5d8ca6
Fixing link to C.146 to be valid, and a link to ??? to be unlinked ( #934 )
...
this fixes links and the issues discovered by travis CI
9 years ago
5975f4d5db
more bounds profile reorganization
9 years ago
df160f3654
Most of the bounds safety profile
9 years ago
9eb18fdf9e
vector exception to {} initializers
9 years ago
9d44e718eb
Reorganized the Type safety profile
9 years ago
c721b2c325
Merge pull request #931 from sizeofvoid/master
...
fix: unsigned int value comment
9 years ago
5da51a9a44
more work on anchors
9 years ago
9d283bc451
anchors for Type.*
9 years ago
986106c63c
more Type.* reorganization
9 years ago
e2719d035b
Reorganize Type.1-3
9 years ago
6e86c182f9
Don't detach, rename raii_thread to joining_thread
...
Addressing #925 . Please review carefully. #925 is tricky.
9 years ago
96a41a4a6e
travis CI fixes
9 years ago
a1f59395bb
modifications to C.43
...
Issue #544
9 years ago
85cb14703c
travis CI fixes
9 years ago
aabfe119d3
typo fix
9 years ago
a591b3c279
fix: unsigned int value comment
9 years ago
14ef2cde84
add rules against use of unsigned
...
addresses #571
9 years ago
50576c0144
issue #841
...
SF.10: Avoid dependencies on implicitly `#included` names
9 years ago
974fdf4661
improve I.11
...
as suggested in #552
9 years ago
fa1d0e5995
exceptionsand const
...
Added to E.15
9 years ago
81493f331c
Undid untentional change to C.85
9 years ago
7206b618a4
C.86 example accesses private members #541
...
fixed
9 years ago
9620ea8d43
I.30: Encapsulate rule violations
...
Fiexed #893 by moving the bad example from ES.28 to a new rule: I.30:
Encapsulate rule violations.
I may inadvertenly have invented a new suppression syntax
9 years ago
17ccab5836
Fix C.139
9 years ago
b10ffdf55f
Reversed order of Lifetime.1 and .2
9 years ago
ff9bce8035
Add Lifetime.1-3 rules so tools can refer to them
9 years ago
f1b348e0db
Additional guidance around casts:
...
- Warn on unnecessary casts
- Avoid casts on arithmetic types
- Add specializations of the rules for Pro-type-reinterpretcast
9 years ago
17715010a2
travis CI fixes and grammar fix from #920
9 years ago
b09b9ad8b9
Updating date & typos
9 years ago
bec67d690a
Merge pull request #914 from AndrewPardoe/issue911
...
Clarify I.11 with regards to recommending smart pointers/owner<T>.
9 years ago
52eca9a174
Merge pull request #917 from scraimer/master
...
C.148 adding Reason and Example
9 years ago
2e1d9c34d4
Merge pull request #920 from cubbimew/issue899
...
CP.111 more precise motivation and examples
9 years ago
d5ea1fcc4f
Merge pull request #922 from AndrewPardoe/issue-918
...
Fix anchors in C.147/148
9 years ago
52aa9ba997
Fix #903 .
9 years ago
e354279e0e
Fix anchors in C.147/148
9 years ago
ad6f863152
Added not about notation to Con.2
...
in response to #902
9 years ago
f41d36ff25
CP.111 more precise motivation and examples
9 years ago
7c90bdba50
Intended heading level?
...
Following the heading levels throughout the doc, it seems these are typos.
9 years ago
12f0954f66
Fixed the errors detected by Travis CI and @jwakely
9 years ago
cdf2e7e5ea
Fixed the errors detected by Travis CI and @jwakely
9 years ago
bdb5d27a10
Remove spaces before ptr-declarators in examples
9 years ago
1c53b29a3a
C.148 - Fixing Travis-reported errors discovered so far in the code example
9 years ago
b6132db539
C.148 adding Reason and Example
9 years ago
343f40792a
Clarify I.11 with regards to recommending smart pointers/owner<T>.
9 years ago
f0239407ad
travis fixes
9 years ago
03c2b4699d
Updating date
9 years ago
32d6313607
Improve example for ES.45
...
Fixes #895
9 years ago
a96fed9c99
Merge pull request #896 from tlanc007/master
...
ES.45/ES.46 renamed and reordered to match anchors found later in file
9 years ago
0ff5518dca
Merge pull request #905 from ewoudvc/es24_toc_rule_correction
...
ES.24: have TOC rule match body rule
9 years ago
b41bea68c1
Merge pull request #909 from tvaneerd/patch-2
...
Note -> Not, are -> is
9 years ago
f9f3422ac5
Fix C.183.
9 years ago
918a5695c7
Address C.128: say 'avoid'.
9 years ago
481996c849
Note -> Not, are -> is
9 years ago
e0de4df83b
added clarifying note for C.139
9 years ago
b3584cfa5f
added reference to C.137
9 years ago
a6a087dfc5
regular added to glossary
9 years ago
64622d5cca
testing
...
and fixing one "thinko"
9 years ago
caa86ae38b
GSL.assert: replace is by are ( #908 )
9 years ago
e3fe0c5b5e
Fix indentation of NR.1 example
9 years ago
10805fb7a1
ES.24: have TOC rule match body rule
9 years ago
94a7a3fd46
travis CI fixes, one more time
9 years ago
046d62c51e
minor improvements to SL.io
9 years ago
c99a366bba
travis CI fixes
9 years ago
4f9a6c89be
banning exception specifications
...
a bit more abut exceptions; the beginnings of I/O
9 years ago
1e38eb8ae7
ban longjmp
9 years ago
5397c9c5fe
very minor typo
...
testing
9 years ago
1b7d217cd1
nothing
9 years ago
5306795214
ES.45/ES.46: renamed and reordered to match jump tags
...
The anchors later in the file were using 46 for narrowing and 45 for
magic. Renamed and reordered the tags in the TOC to match.
9 years ago
2a098a2b39
travis CI fixes
9 years ago
df8a441dcf
fix bug in C.9 example
...
a real-world example would be an improvement
9 years ago
d1ff56d07e
date
9 years ago
cfa2fec1f2
C.137
9 years ago
6987bfd2f0
C.9 and C.133
9 years ago
05118054f6
NL.11 literals
9 years ago
e30bb60320
more xrefs
9 years ago
540c393501
Merge pull request #892 from lbrandy/master
...
Example of an inheritance hierarchy for C.120.
9 years ago
04537cdb11
travis CI fixes
9 years ago
74ab713700
travis CI and some typo fixes
...
had to drop runtime/printf from the checks because it bans strcpy
9 years ago
54f57d8d1b
more language feature xrefs
...
These xrefs are menat part as teasers to get language-feature obsessed
programmers to look at the guidelines and partly to cover topics that
appears in several places. They are not meant to be complete
9 years ago
6fa4cb32cd
more language feature xrefs
9 years ago
e144bd4f9b
minor
9 years ago
29fdd0d30c
Attempt to add an example (that is as non-controversial as possible) of an inheritance hierarchy to C.120
9 years ago
Andrew Pardoe
Will Wray
Vincas Dargis
Andrew Pardoe
Thibault Kruse
Rory Jaffe
Sergey Zubkov
Thibault Kruse
Jacob Taylor Hindle
Bjarne Stroustrup
Konrad Borowski
Elias Kosunen
Robert Andrzejuk
Tom Isaacson
Florin
Abigail
Zachary Henkel
Gabriel Dos Reis
Bledson Kivy
galik
Chris Blume
Malcolm Parsons
Shalom Craimer
Rafael Sadowski
hsutter
Gabriel Dos Reis
Shalom Craimer
Jonathan Wakely
Tony Van Eerd
ewoudvc
Tal Lancaster
Louis Brandy
Louis Brandy