0d02b7e8bf
C.9: Capitalize first word of title
9 years ago
edb59eea86
C.8: Fix typo in text
9 years ago
b516c49efc
C.8: Fix typo in title and capitalize first word
9 years ago
c6071b8add
CP.41: Fix typo in code example
9 years ago
09d76d93fc
Merge pull request #791 from severinmeyer/P.9-Typo
...
P.9: Fix typo in code example
9 years ago
c3ee965a28
P.9: Fix typo in code example
9 years ago
17c7ba9b8b
Fixed missing `
9 years ago
3768e82fc3
Fix spelling / expand dictionary.
9 years ago
e8ecae3171
Added some example tooling discussion.
9 years ago
53bc78fd49
Fix broken anchor link
9 years ago
d86a82f1eb
Fix typo ( #782 )
9 years ago
98f1e46602
C.146 Compare pb2->id() instead of pb2
...
Fixes #504
9 years ago
db85ec865d
ES.7 Fix typo, "i" -> "current_element_index"
9 years ago
aab97d9e48
C.32 Fix typo, "aide" -> "aid"
9 years ago
6767413118
Merge pull request #760 from derekxgl/patch-1
...
P.11 call vector reserve(100) instead of vector(100)
9 years ago
38772fc251
Correct spelling of nullptr
9 years ago
6c29e226d8
P.11 call vector reserve(100) instead of vector(100)
9 years ago
7b4a1903ec
Merge pull request #745 from kks32/master
...
Fixes wrong order of type and function name in naming scheme - master branch
9 years ago
804964d653
Merge pull request #758 from Eliyahu-Ravuna/patch-22
...
Short string optimization example for C.180
9 years ago
52c4376433
Short string optimization example for C.180
...
Extra blank lines removed
strcpy replaced with strcpy_s to get rid of Travis CI warnings
Note: strcpy_s is defined in the Annex K of the C++11 standard.
Gabriel's comments incorporated
- No need for braces for a single statement.
- Comment to explain why buffer_size is 16.
Bracing style made consistent with the rest of the examples
Bracing style made consistent with the rest of the examples
braces made consistent with the rest of the examples
9 years ago
f6dd6159f8
Fix issue #747
9 years ago
f66d9aea46
Fix 798177568e
9 years ago
798177568e
Merge pull request #754 from Eliyahu-Ravuna/patch-21
...
CP.110 & CP.111: Double-checked locking
9 years ago
b149a50faf
Merge pull request #756 from pepsiman/patch-1
...
P.5 Correct case of Int alias
9 years ago
4d45c6bb1d
Merge pull request #755 from pepsiman/executionpolicy
...
P.3 Split execution policy and container
9 years ago
ec2f23781d
CP.110 renamed as "Do not write your own double-checked locking"
...
CP.110 renamed as "Do not write your own double-checked locking".
Explanation and two examples added.
Added exception
Double-checked locking may be legitimately used in lock-free programming. However, see the rule [CP.100: Don't use lock-free programming unless you absolutely have to](#Rconc-lockfree).
Title made clearer and a conventional pattern has been added
* Title made clearer
* A correct example of double-checked locking has been added
Casing fixed
Casing fixed
Extra whitespace deleted
CP.110 and CP.111 separated
- CP.110: Do not write your own double-checked locking for initialization
- CP.111: Use a conventional pattern if you really need double-checked locking
Whitespace removed
Example simplified
Whitespace issue fixed.
punctuation fixed.
9 years ago
71df1537b3
P.5 Correct case of Int alias
...
Revert d9562f683d9590bb94b1
9 years ago
e66f5bb28e
P.3 Split execution policy and container
9 years ago
2a000ac21a
In: Grammar and correction fixes
...
We use letters to identify the first part of a rule "number", not just one letter.
The rest are grammar fixes.
9 years ago
e0abec4259
Remove mode string from ifstream constructor in R.12
9 years ago
7f872a9d50
Fixes wrong order of type and function name in naming scheme
9 years ago
8aaf6e1b76
Correct glossary entry order
9 years ago
138da22db4
Fix glossary definitions and grammar
...
A class isn't abstract for having a protected constructor, but for only having protected constructors.
9 years ago
8be1869663
Update C.128 to remove override from destructors
...
Clang Tidy has a a check called (modernize-use-override) that explicitly verifies that `override` be placed on destructors of derived classes whose base class is `virtual` as seen [here](https://github.com/Microsoft/clang-tools-extra/blob/master/test/clang-tidy/modernize-use-override.cpp#L48 ). This issue was brought up by @jaredgrubb in the following [ticket](https://github.com/isocpp/CppCoreGuidelines/issues/721#issuecomment-246627077 ) and was also seen [here](https://github.com/Bareflank/hypervisor/issues/208 ) as well. @gdr-at-ms closed the ticket stating that the C++ Core Guideline Editors have decided that `override` should not be placed on destructors, but the documentation makes no mention of this decision. The following PR addresses this issue. With the documentation updated, an issue ticket can be generated for Clang Tidy to have the destructor check modified to reflect the C++ Core Guidance.
9 years ago
3f33bd9c89
Merge pull request #730 from olafdietsche/spelling
...
Minor spelling fixes
9 years ago
729c515a2b
Merge pull request #703 from amdn/master
...
T.44: Added `s` suffix to string literal
9 years ago
c4a19c99b2
Merge pull request #706 from tkruse/fix-examples2
...
Fix examples2
9 years ago
97503abeaa
Merge pull request #700 from tkruse/fix-examples
...
fix code examples
9 years ago
2b80bc92a5
T.65: fix code examples
9 years ago
bb2e744c3f
Minor spelling fixes
9 years ago
1c0e2b7d11
fix invalid code
9 years ago
25e3ec4652
improve code example, use() function makes little sense with void results of f() and g()
9 years ago
7c991f0e7e
fix varname
9 years ago
a361c37f5e
unique funIds
9 years ago
9590bb94b1
fix code examples
9 years ago
2db47928df
fix unnecessary block
9 years ago
6a39a88bf8
Fix initializer list example
9 years ago
3acba2ebae
Merge pull request #726 from tkruse/fix-typos
...
Fix typos
9 years ago
bceec9e494
CP.3: Fix example: function declarations
9 years ago
a11f1f7f53
fix typos
9 years ago
8078b0a1f8
Move whitespace to right place
9 years ago
1e4b13bfb0
fix whitespace after comma
9 years ago
9c148afad3
Fix transition of *Excption* to #### Exception in 4d7b1d
9 years ago
254c123c14
fix internal link
9 years ago
13419aa5dd
fix code style
9 years ago
603a1b4286
Fix whitespace inconsistencies, remove tabs
9 years ago
27b585ad71
style issues
9 years ago
0aea7d997b
Added Per.7
...
Design to enable optimization
9 years ago
bf0d7e415f
Fixes the NL.26 link.
9 years ago
b5d5d3f547
Fix order of declarations inside example
...
Fixes #668 .
9 years ago
d1f22ae88d
Fix order of declarations inside example
...
As per #668 , fixing order of declarations in example to match NL.16.
9 years ago
3ca23f1575
fix Enum.4
9 years ago
3ec8cfc5cc
Issue 660
...
Note added
9 years ago
4d7b1d7b63
minor formatting changes
9 years ago
56b4efd430
fixing some bugs in examples
...
#697
9 years ago
4d97aea4c9
fix typos
9 years ago
d7725aa37c
ES.100
...
new example
9 years ago
1d53754694
Union section fleshed out
...
#692 #570
9 years ago
cbad9769de
ES.102 fleshed out
...
response to issue #675
9 years ago
34e719bb36
ES.12: Do not reuse names in nested scopes
...
new rule, and a few minor fixes
9 years ago
ca798a640b
Merge pull request #709 from tkruse/fix-typos
...
Fix typos
9 years ago
83f60b4415
Fix typos
9 years ago
5aea4a1fef
style: fix code indentation
9 years ago
67191255fa
Updates to NR section
9 years ago
d01675876f
Added `s` suffix to string literal
...
As written, the type for "Hamlet" without the `s` suffix will be deduced to `const char*` instead of the intended `std::string`, see example earlier for auto deduced `std::string` for "Ophelia"s with the `s` suffix.
10 years ago
1ddd9cdb7a
typo fix
...
P.11 issue #670
10 years ago
3f0aa7c379
Merge pull request #694 from tkruse/merge-leftovers
...
Bad Merge leftovers
10 years ago
1931fdcff5
Google styleguide now lives on github
10 years ago
a1c248b26f
unique variable names in example
10 years ago
c0bff45961
style fixes
10 years ago
9cf040ebec
Merge branch 'fix-style-classname' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-style-classname
10 years ago
fbe6aac021
Merge pull request #618 from tlanc007/CP.2_617
...
CP.2_617: Changed variable s to a tigher form of span.
10 years ago
6760960e7a
Merge pull request #613 from tlanc007/C.33_610
...
C.33_610: changed owner<T>* to owner<T*> per issue 610
10 years ago
4efa0fb291
Merge pull request #666 from tkruse/dodgy-code
...
Minor dodgy code issues
10 years ago
7cbdb3d356
Merge branch 'fix-unique-anchors' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-unique-anchors
10 years ago
7e34d8880c
Merge pull request #681 from tkruse/rebased-typo-fixes
...
Rebased typo fixes
10 years ago
bfcffb8561
Merge branch 'master' of https://github.com/0x8000-0000/CppCoreGuidelines into 0x8000-0000-master
10 years ago
3f3d80d7ec
Reapplying one fix from 680 after a slightly bad merge
10 years ago
6ba822f535
Merge branch 'upgrade-checkers' of https://github.com/tkruse/CppCoreGuidelines into tkruse-upgrade-checkers
10 years ago
7f510892e5
Merge pull request #680 from tkruse/fix-style
...
style fixes
10 years ago
9a9e958955
Manually fixed PR #657
10 years ago
25044afca0
Correct a few typos.
...
A quick inspection with 'aspell -l en_US'.
10 years ago
be304fedd6
R.1 example: change names according to NL.8
10 years ago
0af83def79
Style: Rename classes with underscore as separator
10 years ago
2bfb860cfe
separate names with underscores
10 years ago
0701c4df62
Style: Consistently name custom classes with initial capital and underscore notation
10 years ago
00cf8d08ff
Fix bad reference
10 years ago
9f2d2645ff
Remove rogue comma from example
10 years ago
04cd9a5d73
fix typo
10 years ago
d084dcef31
Fixed typo shuld -> should, fixed missing words
10 years ago
Severin Meyer
Gabriel Dos Reis
Stéphane Magnenat
Titus Winters
Mustafa Serdar Sanli
Jan Nils Ferner
Jonathan Wakely
Doan Tran Cong Danh
Jonathan Wakely
Malcolm Parsons
Derek Li
Eliyahu Ravuna
Andrew Pardoe
Andrew Pardoe
Johel Ernesto Guerrero Peña
Oleksandr Senkovych
Krishna Kumar
Rian Quinn
Akim Demaille
Olaf Dietsche
Thibault Kruse
Felix Morgner
Bjarne Stroustrup
Jeroen Habraken
Neil MacIntosh
Arturo Martín-de-Nicolás
Andreas Scherer
Sam Bristow
Passw
Robin Degen