Commit Graph

1957 Commits (de20b33dabfda58b1bf210450b2e61d71e552e67)
 

Author SHA1 Message Date
Herb Sutter de20b33dab Restored `*sizeof(int)` after merging PR #1776 5 years ago
Juha Reunanen bf63aca389
A mixed bag of minor fixes, mostly related to language use (I mean English, not C++) (#1776)
* Minor comment fix

* Minor language fix

* Minor language fix

* Minor clarification

* Minor language fix

* Minor language fix

* Remove whitespace for clarity

* Make whitespace consistent (again, it wasn't the "bad" here, right?)

* Minor language fix

* Change weird formatting for emphasis

* Fix (what I believe is) a slightly distracting typo

* Minor language fix

* Suggest to highlight even security vulnerabilities as a possible outcome of concurrency errors

* Minor language fix

* Suggest to add new section for a seemingly unrelated note

* Minor language fix

* Minor language fix (not sure what this intended to say in the first place?)

* Minor language fix

* Add minor remark

* Minor language improvement

* Minor language fix

* Point out a bad example

* Minor fixes

* Minor language fix

* Add missing period (the lack of which doesn't look bad here, but does a bit in the rendered html)

* Minor language fix

* Minor language fix

* Minor typo fix (but is this what was meant?)

* Minor language improvement (?)

* Minor language fix

* Minor language fix (?)

* Add missing closing quotation mark

* Minor language fix

* Minor language fix

* Remove extra dot (or was it supposed to be three dots instead?)

* Minor language fix

* Minor language fix

* Minor language fix

* Minor language fix

* Minor language improvement

* Minor formatting improvements

* Minor improvements

* Minor language fix

* More fixing

* Add missing parentheses (did I get it right?)

* Minor language fix (?)

* Minor language fix

* Minor language fix

* Fix language (but is this what was meant in the first place?)

* Update heading to match content (in particular, the example)

* Remove superfluous whitespace

* Update also the "bad" example to use int*
5 years ago
Bill Rose 8a0053d671
Update change_speed example in P.1 to use user-defined literal syntax (#1778)
Co-authored-by: Bill Rose <neptoess@gmail.com>
5 years ago
Kie 2541e809b6
[I.9] fix typo (#1787) 5 years ago
Juha Reunanen 58f91d7cf1
C.86: Improve language just a bit (#1774) 5 years ago
Juha Reunanen 52b0aa7cdf
C.other: Improve language just a bit (#1773) 5 years ago
Juha Reunanen b933a61940
C.31: Improve language just a bit (#1772) 5 years ago
Juha Reunanen c3baa7ce8b
C.66: Improve language just a bit (#1771) 5 years ago
Juha Reunanen 652b71b2c0
F.20: Improve language just a bit (#1768) 5 years ago
Juha Reunanen 402565d74e
F.52: Improve language just a bit (#1770) 5 years ago
Sergey Zubkov 077a29ee3c CI fixes 5 years ago
Herb Sutter 7849d7e7c4 Added F.56, closes #1752 5 years ago
Herb Sutter 77b4175785 Added C.12 to discourage `const`/reference data members
Would have been nice to put this after C.9 but item numbers are dense
around here.
5 years ago
Herb Sutter 4498e078e7 Refined spec for `narrow` to cover signedness promotions, closes #1726 5 years ago
Herb Sutter c8e72981c4 Fixed misapplied edit for `<=>` 5 years ago
Herb Sutter 4f6e11940e Added bad/good example for C.89, closes #1727 5 years ago
nullptr-cpp 8bdb8fe0dc
Add '<=>' to comparison operators related rules (C.87, C.167) (#1759)
* Add '<=>' to comparison operators related rules (C.87, C.167)

C++20's three-way comparison operator should respect the same rules as other
comparison operators.

* Fix a minor typo

Co-authored-by: Jonathan Wakely <github@kayari.org>

Co-authored-by: Jonathan Wakely <github@kayari.org>
5 years ago
nullptr-cpp 5f75ea4b4b
C.63: Fix a minor typo (#1760)
In accordance with the title at line 4568, use `const&` instead of `const &`.
5 years ago
Sergey Zubkov af44f95577 and another fix to md-split.py for CI 5 years ago
Sergey Zubkov f36b3ccaa4 fix md-split.py for CI 5 years ago
Sergey Zubkov 1dd82988d7 make CI happier 5 years ago
Sergey Zubkov ee28f50025 dict update for CI 5 years ago
Herb Sutter 4f0659fb75 Added CP.coro and CP.51, closes #1756 5 years ago
Herb Sutter ccb7eff4ec CP.1: Made "bad" example consistent with now-updated "good" example 5 years ago
Martin ffeca2a254
Change comparison to use int instead of double (#1758)
This allows the example to remain simple well not misleading a beginner
such a comparison is safe. Including an epsilon comparison or something
similar would overly complicate this example.

Co-authored-by: Martin O'Shea <martin.oshea@native-instruments.com>
5 years ago
JuliusBrueggemann 1caef9a7f1 Use the same phrasing in index and actual rule 5 years ago
Herb Sutter c57e95d1c8 Clarify meaning of "inline" in F.5, closes #1731 5 years ago
Herb Sutter fa56634596 Add local lambdas and variable templates to T.61: Closes #1742 5 years ago
Herb Sutter 64ab13b3d0 Closes #1748 5 years ago
Herb Sutter a97be2d528 Addresses #1732 5 years ago
Sergey Zubkov 3e61563a0c make hunspell happy 5 years ago
Herb Sutter 75cc9a102f Improves I.24 rule wording, closes #1733 5 years ago
Herb Sutter caab79d1e9 Improving the wording of I.25 per #1734 5 years ago
Herb Sutter f46ce437e0 Slightly improved F.20 to highlight the note about const return values 5 years ago
syntroniks a5a4d0b4a2
update Enum.7 note with consistent capitalization (#1739) 5 years ago
Sergey Zubkov f6f1a49a41 typo 5 years ago
Herb Sutter 3c1991b87b Updated T.68 example 5 years ago
Herb Sutter 520ac9c695 Updated the new ES.3
Added xref, massaged summary.
5 years ago
shaneasd 627ed66ce6
Update reference to SF.7 to match text (#1735) 5 years ago
Florian Behrens c142bc9d7e
Improve example in CP.4 to not contradict F.53. (#1724)
Changed the example so that objects are not passed by reference to other thread contexts (though threads are properly synchronized).
5 years ago
peno2 b5412f5922
Add new rule ES.3 Don't repeat yourself (#1715)
* Add new rule ES.3 Don't repeat yourself

* Replace function example with more inclusive/neutral language

Add a reference to topic on libraries.
5 years ago
Sergey Zubkov 2c95a33fef travis CI fixes 5 years ago
David Leal cef2f6bb77
Replace Travis CI with GitHub Actions (#1688) 5 years ago
Niels Dekker e2c0f23ce1
F.60: Remove C-style cast (T&) from example of invalid C++ (#1711) 5 years ago
Herb Sutter a6eb40c5a2 Improved F.7 lifetime note; closes #1698 5 years ago
Herb Sutter 5fdddf821d Added a justification message option for `gsl::suppress`
Closes #1703
5 years ago
Herb Sutter 53aaebb074 Updated Mozilla link and Google style guide C++ version note
Closes #1705
5 years ago
Fernando J. Iglesias García 525d8f225e
Update C.83 with swap for resource mgmt. (#1694)
* Update C.83 with swap for resource mgmt.

The swap is useful to implement assignments idiomatically (e.g. copy-swap idiom).

With the current enforcement, to non-virtual classes, very simple classes (e.g. `trivially_copyable`, a struct encapsulating an stl container) are suggested to have a swap. This suggestion can be argued wrong since for very simple classes copy-swap idiom is not efficient (the creation of a third object on assignment is not needed, which copy-swap does).

* Rework C.83 according to PR comments.
5 years ago
Sergey Zubkov 840fa592ac
merge C.150 in R.23, leaving a redirect behind (#1676) 5 years ago
hsutter dd98129f40 Fixes example in ES.105, closes #1678 5 years ago