f971ad2f17
Fixing tagged union example ( #1301 )
...
It did not compile previously due to missing type specifier on placement new.
7 years ago
d822f80d5d
Fix whitespace errors in code, to make Travis CI pass
7 years ago
a7fc6f6d4e
Fix a typo ( #1300 )
7 years ago
0fe73c966d
Fixed typo
...
Thanks @dalg24!
7 years ago
d6d7d749c3
Minor rewording
7 years ago
334c902a13
Adding suggestion in #1283 comment thread
...
Thanks, Mike!
7 years ago
41b10255c4
date update
7 years ago
6e3d2d2c22
Closes #1297
7 years ago
4fa9d4019f
Minor edits to #1291
7 years ago
407fcc0eac
update to I.4: Make interfaces precisely and strongly typed ( #1291 )
...
* updates to I.4: Make interfaces precisely and strongly typed
* Update enforcement list
* address PR feedback from blakehawkins
7 years ago
0181ab40a7
Fix example in C.51 ( #1294 )
...
The example looks like it previously used i to represent date, but now the variable is called d. I updated the use and related parameters to match.
7 years ago
50b9cefe39
travis CI and typo fixes
7 years ago
dd67c99f1f
made C.con a bit less incomplate
...
More will eventually come
7 years ago
1103509895
A philosophical rule/caution
7 years ago
0f61a4be4e
typos
7 years ago
417d512fea
clarifications for #1267
...
references to resource handles
7 years ago
11f58787b8
minor clarifications
...
for #1268 and #1267
7 years ago
2cfcd878c4
fiexed C.49
...
remover contradiction to C.45 (#1092 ) ) and mention string_view
7 years ago
8825798df6
clarify rules for {} initialization
...
in response to #1279
7 years ago
61cdce115e
Improved description of F.3 example
...
The example in F.3 is not really long, but it is complex
7 years ago
3fbc0b35a4
Closes #1265 , make the chaining exception more visible
7 years ago
7733c326b2
No double deletion ( #1278 )
7 years ago
0b275097b6
Fixed a typo within ES.23
7 years ago
e81d770bdc
Fix broken link to Lifetime paper ( #1274 )
7 years ago
30a0e1bef7
closes #1239
7 years ago
8915f05950
travis CI fixes
7 years ago
fa7b1fe41f
Fixed Lifetime.pdf link
7 years ago
f02b24a71a
Update Lifetime profile to 1.0
7 years ago
ecfd61c8d8
Clarify C.128
...
Improved readability of primary paragraph.
Added Discussion section of the classes of errors being addressed.
7 years ago
104cd63a37
Closes #1257
...
Fixed example
7 years ago
60e19d76a4
Closes #1254
7 years ago
5b372a99d8
Fixes Issue #1253 : wrong link in SS-bounds to Res-simple ( #1255 )
...
Replaced Res-simple with Res-ptr.
7 years ago
1e12aba7af
missing a return *this in a copy-assignment
7 years ago
faad9d8b56
one more typo
7 years ago
73057d3b0b
travis CI fixes and typos
7 years ago
b16eb424e9
typo: funct1_tau -> func1_tau
7 years ago
e75a7056c4
Resolving #1146
...
explaining SCARY and referencing the SCARY paper
7 years ago
a0bc2d71ca
resolving #1137
...
clarification
7 years ago
647aa80f0d
applying #1139
...
more references to C++17
7 years ago
79a5b08ad9
resolve #1175
...
I added a note
7 years ago
5cabda84d7
resolve #1185
...
implicit operator functions
7 years ago
d3c3e3aa98
resolve #1209 , #814 , and #167
...
noexcept and destructors
7 years ago
f3e7dbac6e
Resolution of #1228
...
explicitly discouraging the use of # and ##
7 years ago
c11001f0a6
resolving #1238 about style
...
The caveat is added only to the subset of rules where it appears to be
relevant
7 years ago
dd4cae0260
Resolve #1241 about returning T&&
7 years ago
e31a85dc2d
Closes #1251
8 years ago
0c7a349342
Fix example for ES.70 ( #1252 )
...
As per #574 , fixes the example in ES.70 to emphasize good use of a switch over a sequence of if-else-if statements.
8 years ago
d1def3290c
Tweaked PR 1249 post-merge to cover copy assignment too
8 years ago
08f67de9fb
Updated C.67 and C.130 ( #1249 )
...
* Updated C.67 and C.130
This addresses https://github.com/isocpp/CppCoreGuidelines/issues/1246 .
* fixed typeos
* updated dictionary
8 years ago
42f8fa5f84
Use H3 heading for C.140 instead of H2
...
Fixes #1250
8 years ago
513a5fd624
Fix example good in ES.42, count to a.size() ( #1245 )
...
* Fix example good in ES.42, count to a.size()
* Fix typos in ES.64 and Con.1
* Fix Example bad in T.3, no value in subscript
8 years ago
6dd14321c1
GSL grammar fix, added missing plurality in full name ( #1243 )
...
* Renamed all appropriate instances of "guideline support library" to "guidelines support library".
* Renamed additional instances of "guideline support library" to "guidelines support library" in remaining files.
8 years ago
04b2fabb9b
Change 'lifetime profile' to 'lifetime safety profile' and fix the bad/broken links ( #1240 )
...
'lifetime profile' is only used twice with bad/broken links. 'lifetime safety' and 'lifetime safety profile' are used more frequently, and make more sense.
8 years ago
cb08aa24a4
s/more that two/more than two
8 years ago
e0ecfc83b7
Closes 1220
8 years ago
a488f1d8b5
Added F.48, closes #1219
8 years ago
c0a2efdfe8
Closes #1218
8 years ago
1283da9afa
Closes #1216
8 years ago
28e9f02550
Let's =default to avoid an out of line definition question
8 years ago
aa645b0372
Closes #1214
...
Added virtual dtor to make the example standalone
8 years ago
0d0026e61e
Correct Dewhurst link to reference found in discussion for C.47
8 years ago
dea3b94f12
Clarify result of lower_bound
...
The previous formulation made it sound like the return value is always `last` if `val` is not in the range, which might lead to confusion.
8 years ago
4af8321e91
Fix "an reasonable" typo
...
Fixes #1211
8 years ago
599fb02d12
Merge pull request #1208 from mabuchner/1207-cp-31-memory-corruption-from-example
...
Pass parameter as reference in CP.31 example
8 years ago
a866b000d3
it's deletion -> its deletion
8 years ago
4e58fb87f7
typo: "nothing to do with sync" -> "nothing to do with stdasync"
8 years ago
7261f5d2fb
Pass parameter as reference in CP.31 example
...
Fixes #1207 .
8 years ago
20d9f42674
Merge pull request #1198 from ianhattendorf/SL-str-12-cpp-14
...
SL.str.12: s suffix is available in C++14
8 years ago
046b2a0833
Merge pull request #1201 from mabuchner/1200-es-102-odd-loop-condition-in-second-example
...
Fix ES.102 odd loop condition in example
8 years ago
46ecdd6830
Merge pull request #1202 from gumb0/patch-1
...
Remove unnecessary comments from C.42 examples
8 years ago
ff4a3069a1
Fix comments in C.42 examples
8 years ago
2ee3fff631
Fix typo in C.44
8 years ago
d49c720e98
Fix typo in error handling intro
8 years ago
69d48f76c7
E.14 an->a is->are fixes
8 years ago
2cedd99f32
Remove whitespace at the end of lines
8 years ago
53c0bd2bd1
Fix ES.102 odd loop condition in example
8 years ago
ee64b7ec17
SL.str.12: s suffix is available in C++14
...
std::literals::string_literals::operator""s is available since C++14
while std::pair class template argument deduction is available since
C++17
8 years ago
1e4dba2c0b
Renamed NL.10 to "prefer underscore_style names"
8 years ago
93ac723f6b
Fixed rest of T.12 example following up #1189
8 years ago
15008e8432
Fix T.12's incorrect usage of vector::begin() ( #1189 )
8 years ago
a5e28d4a61
Updated intro wording
8 years ago
b21b125d42
Capitalization error
8 years ago
b3d2f853f7
Changed "method" to "function" in three places for consistency
8 years ago
cea965f610
Reworded "consume" to "will-move-from" parameters
...
To improve clarity since the wording was causing confusion
8 years ago
99b997b6f0
Merge pull request #1179 from jwakely/issue-1177
...
Fix comment to match code
8 years ago
e5f28e4095
SF.11, Header files should be self-contained ( #1181 )
...
* SF.11 Header files should be self-sufficient added
* PR feedback addressed
* explain more
* update reason baed on PR feedback
* add VS code dir to .gitignore
* more PR feedback
8 years ago
85db0de16c
Merge pull request #1183 from beinhaerter/formatting
...
Formatting in C.46
8 years ago
0cb724fe20
Fixed link for "avoid conversion operators"
8 years ago
b724f71473
Formatting "explicit" as code
8 years ago
c0264f3831
fixed scale factor for millimeters ( #1182 )
8 years ago
e721ee53cb
Fix comment to match code
...
Also fix missing references and add cross-reference to F.22.
Fixes #1177
8 years ago
dbe8bf0207
Fix typo
...
Fixes #1176
8 years ago
9ac22abe0a
Adding note suggested by @jwakely in #1165
8 years ago
b9fe28cc2a
update date
8 years ago
ba25a26294
Rephrase C.21 to talk about declaring not defining ( #1152 )
...
* Rephrase C.21 to talk about declaring not defining
Add examples.
Fixes #870 .
* Define special functions, clarify default constructor effects
8 years ago
ab5f9c18bd
catch by reference in all samples ( #1154 )
8 years ago
2c3d9921b6
Replace erroneous public keyword by private in C.129. ( #1166 )
8 years ago
edf13aabc0
Note that C.46 does not apply for copy/move ctors ( #1169 )
...
* Note that C.46 does not apply for copy/move ctors
* moved Note section before Enforcement section
8 years ago
644e0f5b5e
Merge pull request #1164 from ChrisGuzak/ChrisGuzak-sizeof-not_max
...
use sizeof(buffer) instead of MAX
8 years ago
6ed138076d
Fixed get_string example in F.21 ( #1160 )
...
In the 'all values as return value' example in F.21, the passed istream was not used in the function.
8 years ago
373f4c4808
use sizeof(buffer) instead of MAX
8 years ago
09035eb1e4
Align comment block ( #1162 )
8 years ago
9c4d4247b1
P.5 example read int array size mismatch ( #1161 )
...
Expand comment to clarify problem.
8 years ago
b487f9790a
subject-verb agreement in NL.2
8 years ago
8d5d5e4aeb
To address #1147
...
Changed `.length()` to `.size()` for `span` examples to track
standardization changes.
8 years ago
beed3e97c0
update date
8 years ago
6c55d4eaaf
Bug fix C4 class Foobar ( #1143 )
...
* Fixed bug in example code of C4 Expecptions. In C4, the class function void Foobar::foo(double x) is supposed to call the overloaded void Foobar::foo(int x), but in the call foo(std::round(x)), std::round returns a double. Hence, it will get stuck in an infinite recursive loop. Added static_cast<int>(..) to enforce the call to right overload. Added also keyword public to be more consistent.
* Changed static_cast<int> to narrow_cast<int> following ES.46.
* Modified C4 Foobar class, s.t, std::lround(x) is now called in
void foo(double) and the overload is changed to void foo(long) from (int). Now there is
no need for conversions.
8 years ago
da3b6b98bc
Do Not Check For nullptr Explicitely In Examples ( closes #1142 ) ( #1144 )
8 years ago
9c98f9679c
Copy-Paste-Typo in Comment for ES.87 sample (==0/!=0) ( #1145 )
8 years ago
10c0a8b156
Closes #1119
...
Make C.43 crisper -- the guideline is that default construction is
required for copyable types. A lot of the existing examples then just
fall out, without having to be presented as special cases. This was the
original intent and I think this new text helps make that clearer.
8 years ago
d9f3149e11
Update references to C++17, also typo
8 years ago
73dad7909d
title page/In.sec: reordered and updated titles ( #1135 )
...
* title page: updated titles and unified titles' camel case to sentence case
* In.sec: reordered bullets to match document's workflow, updated titles
* updated several links and link names, modified names to title case
* redirected broken link to new anchor Rf-value-return at 'value return sematic rules' block
* updated links
* reverted unindended broken artistic prose
* updated links, modified "see also's" formatting to comply with the majority
* modified "see also's" formatting to comply with the majority
* fix spellcheck: 'Componentization -> Compartmentalization'
* updated link name
8 years ago
eb534411a7
Should say repository instead of depository ( #1138 )
8 years ago
888067d6ff
fixed spellcheck/lint issues on running make in ./scripts/ ( #1134 )
8 years ago
25d9d12e15
travis CI fixes
8 years ago
f8f396ef3b
Typo fix to NL.5
8 years ago
c5f67599d1
Added another example to NL.5
8 years ago
c10e5503e9
Closes #1104
8 years ago
e3f753ed14
the copy ctor typo and comment fixes from #1125
8 years ago
15ca9d220c
Fixing typo per #1130 & updating date
8 years ago
c1e3cd01cd
Add gsl::index, closes #1098 ( #1115 )
...
* Add gsl::index, closes #1098
And update examples throughout to use `index` as appropriate
* Actually adding `index` to the GSL.util section
* Added `sizeof` to whitelisted signed/unsigned comparisons
Same reason as container `.size()` -- better backward compatibility with
the existing standard
8 years ago
b677b69014
Removed useless "Currently (July 2016)" ( #1123 )
...
* Removed useless "Currently (July 2016)"
* replaced `GCC 6.1` with `GCC 6.1 or later`
* Correct usage of `and/or` in `GCC 6.1 _ later`
8 years ago
2bdd1ae705
add example for R.24 ( #1127 )
...
* add example for R.24
taken from https://cpppatterns.com/patterns/weak-reference.html , where
it's published under CC0 Public Domain Dedication
* improve example for R.24
8 years ago
5c3006b60f
Change "untended" to "unintended" in C.9
8 years ago
59eb77027e
travis CI fixes
8 years ago
8f87a03588
ES.87
...
#1032 comment and example added.
To consider: should integer comparison be broken out as its own rule?
8 years ago
72b9b40a7c
Some examples in Per.11
...
In response to #936 I added some text to Per.11. More would be welcome
8 years ago
edbfc3b8ec
Clarifying (I hope) text and example added
...
addressing #980 and #9777
8 years ago
0df2c26e9a
C.129
...
#1052 added Jonathan's example
8 years ago
ff42e7bbaf
closing #547
...
(now?) we have CP.3 and CP.31. Also CP.mess.
Yes we need more work on CP.mess
8 years ago
ecabc369bb
simplifying ES.20
...
#488
8 years ago
7e5019378b
Fix #493 array myth
...
Added comment about performance to SL.con.1
8 years ago
7cfb1d7961
update date
8 years ago
bd948ee839
Fix example code in F.20. ( #1109 )
8 years ago
044a4b277e
fixed anchor name for T.21 ( #1108 )
8 years ago
7c11ac1acf
fixed a word (should be 'that' not 'the') ( #1107 )
8 years ago
b5a20f10ea
fixed error in code comment ( #1105 )
8 years ago
352e94babe
fixed minor typo: "on the on the" -> "on the" ( #1103 )
8 years ago
d3a523eea8
Typos found at I.* ( #1093 )
...
* Typo: change word compute by inserted code . is the name of a previous function.
* Typo: add missing comma
* Typo: minor period typo
* Typo: form lower to upper case
* Typos found at I.*
Typo: add missing comma
Typo: minor period typo
Typo: form lower to upper case
Typos found at I.*
8 years ago
3667b08ce3
Merge pull request #1095 from brenoguim/hotfix/public-deleted-methods
...
Add public access modifier to examples
8 years ago
fbc48fafb0
Merge pull request #1096 from brenoguim/hotfix/recommend-public-deleted-methods
...
Recommend deleted methods to be public.
8 years ago
6ac3ac940f
Merge pull request #1100 from breyed/patch-1
...
T.concept: Remove comment unnecessary in good example
8 years ago
79dd574a65
Fix #1004
8 years ago
4bbcd758f2
updating date
8 years ago
0931fab3d5
T.concept: Remove comment unnecessary in good example
...
The properly defined `Number` concept used as the template type is fully expressive.
8 years ago
bdc07cc4ef
Fix link to Rt-concepts
...
Fixes #1099
8 years ago
771a75e183
Add note to make deleted methods public
8 years ago
eb0707d7ae
Add public access modifier to examples
8 years ago
e6ac978f3a
Updated due to discussion about #1068
8 years ago
2b4438603c
Updating date
8 years ago
0a6167e1fc
Merge pull request #1066 from brenoguim/hotfix/add-virtual-destructor
...
Add virtual destructor to base class "Device"
8 years ago
0364ecace7
Merge pull request #1073 from martinfinke/hotfix/avoid-magic-constant
...
Avoid magic constant in F.44
8 years ago
b553f02f84
Merge pull request #1075 from Eliyahu-Ravuna/patch-2
...
Link added for function objects and lambdas
8 years ago
16e270dee9
Typo: add missing question mark
8 years ago
7f909cc18e
Typo: add missing comma
8 years ago
27d1c01782
Typo: add missing semicolon
8 years ago
3d4e860bdd
Fixed comment in example code of F.54 ( #1082 )
8 years ago
df68bfdc5b
fixed minor typo: `it this` -> `this` (on master) ( #1079 )
8 years ago
90076b9795
Use correct header level ( #1078 )
8 years ago
eb5f6a5b90
Link added for function objects and lambdas
8 years ago
7be6e7daed
Fix typo in destructor name ( #1074 )
...
Itream -> Istream in I.30: Encapsulate rule violations code snippet
8 years ago
d13ac81e27
Avoid magic constant
8 years ago
8a408d8500
reorder ES.expr and ES.stmt in text
8 years ago
3a320fdf53
Add virtual destructor to base class
8 years ago
165c79b417
Break comment to respect 100 column limit ( #1069 )
8 years ago
768e4620d4
Closes #1055
8 years ago
ab67676e7d
Closes #1048
8 years ago
5b82257e15
Changing date
8 years ago
0a85bd8382
Merge pull request #1059 from luav/example-cp.4
...
Example CP.4 (task vs thread)
8 years ago
7a5ab334a0
Update CppCoreGuidelines.md
8 years ago
a1b3a269fc
Merge pull request #1053 from sgkim126/master
...
Fix typos in example.
8 years ago
19d7fb1421
Update CppCoreGuidelines.md
8 years ago
17f76d0258
Update CppCoreGuidelines.md
8 years ago
3d282d21ed
Merge pull request #1061 from planetchili/master
...
struct -> class to conform to C8
8 years ago
3575bf6d43
Update CppCoreGuidelines.md
8 years ago
a277ba71da
Update forward looking statement.
8 years ago
c4f833ad5c
Simple typo fix. ( #1060 )
8 years ago
74cab35f85
Improve hyperlink text in C.8
8 years ago
ace8d7b279
struct -> class to conform to C8
8 years ago
17fe8a957f
Manual non-async task removed
8 years ago
147f4d2dc3
Spaces in blank lines removed
8 years ago
f8159d26e0
Formatting and grammer fixed
8 years ago
45376bb6b2
Example CP.4 (task vs thread)
8 years ago
e251862408
Adjust "formatting" to pass spellchecking
8 years ago
05c44d23ab
Fix typos in example.
8 years ago
f3596553a5
.\CppCoreGuidelines.md
8 years ago
9cf0fcf19d
#1045 Fix reference to narrow_cast ( #1046 )
8 years ago
58e80fc2c5
Adjust "incomplet and incorrekt" joke.
...
This adjusts it to be closer to the form in the C++ working drafts.
Fixes #1043
8 years ago
6153d69b2c
Fix CI errors due to missing whitespace around operators ( #1037 )
...
Also rephrase comments to avoid overlong lines.
8 years ago
2184c57dd1
reorder sections C.167 and C.168 to be in numerical ascending order ( #1034 )
8 years ago
531952a300
Issue #999 c128 applied to c129 ( #1036 )
8 years ago
d318a68e35
ES.20: Fix typo ( #1033 )
8 years ago
1b2ba25b4b
Closes #997
8 years ago
74c36a43b0
Fixing ES.87
8 years ago
f77fa1ad40
R.1: Fix finally link
8 years ago
6574f05356
added ES.87 about conditions in if-statements
...
#1006 and #1010
8 years ago
1a3de0e9b8
add a cross reference to P.3
8 years ago
2839c87890
add example to R.20
...
addresses #1015
8 years ago
b87d21b662
Merge pull request #1018 from Cleroth/patch-1
...
Avoid `std::endl` :)
8 years ago
6d5a219e66
Merge pull request #1023 from marzojr/master
...
Fixing memory handling in E.5 example
8 years ago
Marzo Sette Torres Junior
Jonathan Wakely
Andriy Berestovskyy
hsutter
Sergey Zubkov
Chris Guzak
Kyle
Bjarne Stroustrup
Alexander Knorre
Martin
tcorbat
beinhaerter
Neil MacIntosh
Andrzej Krzemieński
martysama0134
jeffreylindsey
jeffreyai
Richard Evans
kugelrund
Gabriel Dos Reis
mbuchner
Andrei Maiboroda
Ian Hattendorf
Alexander “weej” Jones
Andrew Pardoe
Werner Henze
Jason Mercer
Jonathan Wakely
fekir
Stephan Weller
echeij
nnaka
Ari Hietanen
Tobias Mende
Dipl.-Ing. Raoul Rubien, BSc
Bernardo Sulzbach
Oleg Artenii
rknuus
Mitch Phillips
michaelz85
Andrew Pardoe
Gabriel Dos Reis
Edward Brey
Breno Rodrigues Guimaraes
Leonardo Perez Pulido
Florian Behrens
Thomas Schaub
Eliyahu Ravuna
Mohit Jain
Martin Finke
Jonas Toth
Jay Bazuzi
Yogendra Singh
chili
luav
Seulgi Kim
Tom Isaacson
Franz Hollerer
Artem Golubikhin
Neil MacIntosh