2b6d208d58
Merge pull request #777 from cubbimew/nvi
...
dropping NVI from proto-rules due to no consensus on #768
9 years ago
bd5f0c34db
Merge branch 'master' into bs-local-1
9 years ago
c5cecf1e88
new rule F.9; unused parameters
...
Issue #808
9 years ago
631bbbbaf8
typos MI and membership
9 years ago
eb4be01970
Fix spelling errors
9 years ago
87bb531080
tools and library rules
...
in philosophy
9 years ago
47e5764e6e
Update date
9 years ago
9ddb9e1648
Merge parts of PR #787
9 years ago
20403c8d6d
Merge branch 'thread-tooling' of https://github.com/tituswinters/CppCoreGuidelines into tituswinters-thread-tooling
9 years ago
11e5e00f23
Merge pull request #818 from cubbimew/c138
...
C.138 initial content
9 years ago
f2dfcfc438
minor cleanup
9 years ago
14f67ae8dd
Fix typos from commit 9858685786
9 years ago
8f2ecf0665
Closed #557
...
Added example from the issue
9 years ago
51b4cddbca
Closed #810
...
Added an example to SF.7
Clarified SF.6 and SF.7 that "using-directive" means "using namespace"
9 years ago
9858685786
Clarifying title per issue 793
9 years ago
8a9bb3bc61
fix c.127 example issue. ( #789 )
...
auto will deduce as unique_ptr<D> and the correct destructor will call. Anyway, this should be a bad example.
9 years ago
4d86abfdb4
When the title of ES.56 was changed, its entry in the ES ToC wasn't ( #831 )
9 years ago
0b4b815d0b
uncross links to the self-assignment rules ( #830 )
9 years ago
51191c13d2
Merge pull request #825 from johelegp/interfaces_non_trivial_fixes
...
I: Enforcement fixes/completion
9 years ago
dd7275623d
Merge pull request #834 from cubbimew/c131-constify
...
C.131: getters should be const member functions
9 years ago
bee5e87e90
C.131: getters should be const member functions
9 years ago
808d304687
C.127 should not claim that there is a defined behavior
9 years ago
63582c929e
Rework of English Language style
9 years ago
655bbcafa8
Merge pull request #824 from johelegp/interfaces_fixes
...
I: Grammar, spacing and typo fixes
9 years ago
94fdad103d
Merge pull request #823 from johelegp/gsl_concept_dead_link_fix
...
GSL.concept: Dead link fix
9 years ago
c040dfab55
Merge pull request #822 from johelegp/gsl_fixes
...
GSL: Grammar, spacing and markdown fixes
9 years ago
2b3e249cff
I: Grammar, spacing and typo fixes
9 years ago
5f95cb2734
I: Enforcement fixes/completion
9 years ago
3bb9192d66
GSL: Grammar, spacing and markdown fixes
9 years ago
bb4202ed92
GSL.concept: Dead link fix
...
Described in #407 , 4a9e41d7
9 years ago
d30134b150
P: Grammar, correction and typo fixes
9 years ago
a968af59d0
C.138 initial content
9 years ago
9cfa3eafd7
Updating date
9 years ago
4f2a64b920
Per our discussion, C.42 enforcement belongs to C.41
9 years ago
882d88ebe5
Closed #809 .
9 years ago
bcd9904ae2
Fix remaining typos mentioned in issue #556
...
ES.23: Correct the Fibonacci series
ES.71: Fix bug in example code
T.61: Use the correct type for the class member
Appendix C: Use an example string that is not identical to a C++ keyword and clarify comment
9 years ago
7fb5621495
Merge pull request #799 from severinmeyer/NL-Typos-squashed
...
Fix typos in section NL: Naming and layout
9 years ago
32368d99c6
Merge pull request #800 from severinmeyer/CP-Typos-squashed
...
Fix typos in section CP: Concurrency
9 years ago
1b259959f6
Merge pull request #801 from severinmeyer/ES-Typos-squashed
...
Fix typos in section ES: Expressions and statements
9 years ago
783ab6c6ca
Merge pull request #802 from severinmeyer/E-Typos-squashed
...
Fix typos in section E: Error handling
9 years ago
6fb7ad6bb5
Fix a few more typos
...
F.22: Fix typos
C.128: Update the title in the ToC, to match the new title from commit f0e29f0
9 years ago
185f70781d
Fix typos in section E: Error handling
...
E.25: Fix several typos
E.25: Add missing comma
E.2: Add missing verb
9 years ago
63f1948962
Fix typos in section NL: Naming and layout
...
NL.1: Add missing period to title in ToC
NL.5: Fix typo
NL.8: Fix several typos
NL.9: Add missing period in title
NL.9: Fix typo
NL.19: Fix typo
9 years ago
efdd83bf9a
Fix typos in section ES: Expressions and statements
...
ES.dcl: Fix typo
ES.25: Use the singular form for the title, to correct it and to match it with the entry in the ToC
ES.30: Fix several typos
ES.40: Fix typo in code comments
ES.61: Capitalize first word of title
ES.63: Fix typo
ES.70: Fix typo and capitalization
ES.74: Fix typo in title
ES.102: Fix typo and add missing comma
9 years ago
c1ed09786d
Fix typos in section CP: Concurrency
...
CP.8: Add missing colon to title
CP.30: In title, close inline code block with backtick
CP.101: Correct saying, Icarus flew to close to the sun, not the wind
9 years ago
9987d835b9
Updating date
9 years ago
7741b8689e
Merge pull request #796 from severinmeyer/C-Typos
...
Fix typos in section C: Classes and class hierarchies
9 years ago
353f8ffc4c
C.140: Fix typo in text
9 years ago
26953e0bf9
C.139: Fix typo in text
9 years ago
fc0999c56e
C.129: Fix typo in text
9 years ago
434f995679
C.128: Fix typo in text
9 years ago
66c0348d19
C.80: Fix typo in text
9 years ago
7070ffa839
C.41: Add missing comma
9 years ago
efb284388f
C.defop: Fix typo in introductory text
9 years ago
db8273d068
C.concrete: Fix typo in introductory text
9 years ago
0d02b7e8bf
C.9: Capitalize first word of title
9 years ago
edb59eea86
C.8: Fix typo in text
9 years ago
b516c49efc
C.8: Fix typo in title and capitalize first word
9 years ago
c6071b8add
CP.41: Fix typo in code example
9 years ago
09d76d93fc
Merge pull request #791 from severinmeyer/P.9-Typo
...
P.9: Fix typo in code example
9 years ago
c3ee965a28
P.9: Fix typo in code example
9 years ago
17c7ba9b8b
Fixed missing `
9 years ago
3768e82fc3
Fix spelling / expand dictionary.
9 years ago
e8ecae3171
Added some example tooling discussion.
9 years ago
53bc78fd49
Fix broken anchor link
9 years ago
d86a82f1eb
Fix typo ( #782 )
9 years ago
84b1d80c61
T.84 Correction of Example: Change type of suc and pre to Link_base
9 years ago
bc41bd6e9f
dropping NVI from proto-rules due to no consensus on #768
9 years ago
98f1e46602
C.146 Compare pb2->id() instead of pb2
...
Fixes #504
9 years ago
db85ec865d
ES.7 Fix typo, "i" -> "current_element_index"
9 years ago
aab97d9e48
C.32 Fix typo, "aide" -> "aid"
9 years ago
5f66e004d8
Exception of CP.100 refined to include the "sequentially consistent memory model" only
...
Atomic variables are safe with the sequentially consistent memory model (memory_order_seq_cst) only. Weakly ordered atomics cannot be considered safe for mainstream use. The exception clause of CP.100 refined to include the "sequentially consistent memory model" only.
cst added to dictionary
For std::memory_order_seq_cst, which is defined in <atomic>.
9 years ago
6767413118
Merge pull request #760 from derekxgl/patch-1
...
P.11 call vector reserve(100) instead of vector(100)
9 years ago
38772fc251
Correct spelling of nullptr
9 years ago
6c29e226d8
P.11 call vector reserve(100) instead of vector(100)
9 years ago
7b4a1903ec
Merge pull request #745 from kks32/master
...
Fixes wrong order of type and function name in naming scheme - master branch
9 years ago
804964d653
Merge pull request #758 from Eliyahu-Ravuna/patch-22
...
Short string optimization example for C.180
9 years ago
52c4376433
Short string optimization example for C.180
...
Extra blank lines removed
strcpy replaced with strcpy_s to get rid of Travis CI warnings
Note: strcpy_s is defined in the Annex K of the C++11 standard.
Gabriel's comments incorporated
- No need for braces for a single statement.
- Comment to explain why buffer_size is 16.
Bracing style made consistent with the rest of the examples
Bracing style made consistent with the rest of the examples
braces made consistent with the rest of the examples
9 years ago
f6dd6159f8
Fix issue #747
9 years ago
f66d9aea46
Fix 798177568e
9 years ago
798177568e
Merge pull request #754 from Eliyahu-Ravuna/patch-21
...
CP.110 & CP.111: Double-checked locking
9 years ago
b149a50faf
Merge pull request #756 from pepsiman/patch-1
...
P.5 Correct case of Int alias
9 years ago
4d45c6bb1d
Merge pull request #755 from pepsiman/executionpolicy
...
P.3 Split execution policy and container
9 years ago
ec2f23781d
CP.110 renamed as "Do not write your own double-checked locking"
...
CP.110 renamed as "Do not write your own double-checked locking".
Explanation and two examples added.
Added exception
Double-checked locking may be legitimately used in lock-free programming. However, see the rule [CP.100: Don't use lock-free programming unless you absolutely have to](#Rconc-lockfree).
Title made clearer and a conventional pattern has been added
* Title made clearer
* A correct example of double-checked locking has been added
Casing fixed
Casing fixed
Extra whitespace deleted
CP.110 and CP.111 separated
- CP.110: Do not write your own double-checked locking for initialization
- CP.111: Use a conventional pattern if you really need double-checked locking
Whitespace removed
Example simplified
Whitespace issue fixed.
punctuation fixed.
9 years ago
71df1537b3
P.5 Correct case of Int alias
...
Revert d9562f683d9590bb94b1
9 years ago
e66f5bb28e
P.3 Split execution policy and container
9 years ago
2a000ac21a
In: Grammar and correction fixes
...
We use letters to identify the first part of a rule "number", not just one letter.
The rest are grammar fixes.
9 years ago
e0abec4259
Remove mode string from ifstream constructor in R.12
9 years ago
7f872a9d50
Fixes wrong order of type and function name in naming scheme
9 years ago
8aaf6e1b76
Correct glossary entry order
9 years ago
138da22db4
Fix glossary definitions and grammar
...
A class isn't abstract for having a protected constructor, but for only having protected constructors.
9 years ago
8be1869663
Update C.128 to remove override from destructors
...
Clang Tidy has a a check called (modernize-use-override) that explicitly verifies that `override` be placed on destructors of derived classes whose base class is `virtual` as seen [here](https://github.com/Microsoft/clang-tools-extra/blob/master/test/clang-tidy/modernize-use-override.cpp#L48 ). This issue was brought up by @jaredgrubb in the following [ticket](https://github.com/isocpp/CppCoreGuidelines/issues/721#issuecomment-246627077 ) and was also seen [here](https://github.com/Bareflank/hypervisor/issues/208 ) as well. @gdr-at-ms closed the ticket stating that the C++ Core Guideline Editors have decided that `override` should not be placed on destructors, but the documentation makes no mention of this decision. The following PR addresses this issue. With the documentation updated, an issue ticket can be generated for Clang Tidy to have the destructor check modified to reflect the C++ Core Guidance.
9 years ago
3f33bd9c89
Merge pull request #730 from olafdietsche/spelling
...
Minor spelling fixes
9 years ago
729c515a2b
Merge pull request #703 from amdn/master
...
T.44: Added `s` suffix to string literal
9 years ago
c4a19c99b2
Merge pull request #706 from tkruse/fix-examples2
...
Fix examples2
9 years ago
97503abeaa
Merge pull request #700 from tkruse/fix-examples
...
fix code examples
9 years ago
2b80bc92a5
T.65: fix code examples
9 years ago
bb2e744c3f
Minor spelling fixes
9 years ago
1c0e2b7d11
fix invalid code
9 years ago
25e3ec4652
improve code example, use() function makes little sense with void results of f() and g()
9 years ago
7c991f0e7e
fix varname
9 years ago
a361c37f5e
unique funIds
9 years ago
9590bb94b1
fix code examples
9 years ago
2db47928df
fix unnecessary block
9 years ago
6a39a88bf8
Fix initializer list example
9 years ago
3acba2ebae
Merge pull request #726 from tkruse/fix-typos
...
Fix typos
9 years ago
bceec9e494
CP.3: Fix example: function declarations
9 years ago
a11f1f7f53
fix typos
9 years ago
8078b0a1f8
Move whitespace to right place
9 years ago
1e4b13bfb0
fix whitespace after comma
9 years ago
9c148afad3
Fix transition of *Excption* to #### Exception in 4d7b1d
9 years ago
254c123c14
fix internal link
9 years ago
13419aa5dd
fix code style
9 years ago
603a1b4286
Fix whitespace inconsistencies, remove tabs
9 years ago
27b585ad71
style issues
9 years ago
0aea7d997b
Added Per.7
...
Design to enable optimization
9 years ago
bf0d7e415f
Fixes the NL.26 link.
9 years ago
b5d5d3f547
Fix order of declarations inside example
...
Fixes #668 .
9 years ago
d1f22ae88d
Fix order of declarations inside example
...
As per #668 , fixing order of declarations in example to match NL.16.
9 years ago
3ca23f1575
fix Enum.4
9 years ago
3ec8cfc5cc
Issue 660
...
Note added
9 years ago
4d7b1d7b63
minor formatting changes
9 years ago
56b4efd430
fixing some bugs in examples
...
#697
9 years ago
4d97aea4c9
fix typos
9 years ago
d7725aa37c
ES.100
...
new example
9 years ago
1d53754694
Union section fleshed out
...
#692 #570
9 years ago
cbad9769de
ES.102 fleshed out
...
response to issue #675
10 years ago
34e719bb36
ES.12: Do not reuse names in nested scopes
...
new rule, and a few minor fixes
10 years ago
ca798a640b
Merge pull request #709 from tkruse/fix-typos
...
Fix typos
10 years ago
83f60b4415
Fix typos
10 years ago
5aea4a1fef
style: fix code indentation
10 years ago
67191255fa
Updates to NR section
10 years ago
d01675876f
Added `s` suffix to string literal
...
As written, the type for "Hamlet" without the `s` suffix will be deduced to `const char*` instead of the intended `std::string`, see example earlier for auto deduced `std::string` for "Ophelia"s with the `s` suffix.
10 years ago
1ddd9cdb7a
typo fix
...
P.11 issue #670
10 years ago
3f0aa7c379
Merge pull request #694 from tkruse/merge-leftovers
...
Bad Merge leftovers
10 years ago
1931fdcff5
Google styleguide now lives on github
10 years ago
a1c248b26f
unique variable names in example
10 years ago
c0bff45961
style fixes
10 years ago
9cf040ebec
Merge branch 'fix-style-classname' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-style-classname
10 years ago
fbe6aac021
Merge pull request #618 from tlanc007/CP.2_617
...
CP.2_617: Changed variable s to a tigher form of span.
10 years ago
6760960e7a
Merge pull request #613 from tlanc007/C.33_610
...
C.33_610: changed owner<T>* to owner<T*> per issue 610
10 years ago
4efa0fb291
Merge pull request #666 from tkruse/dodgy-code
...
Minor dodgy code issues
10 years ago
7cbdb3d356
Merge branch 'fix-unique-anchors' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-unique-anchors
10 years ago
7e34d8880c
Merge pull request #681 from tkruse/rebased-typo-fixes
...
Rebased typo fixes
10 years ago
bfcffb8561
Merge branch 'master' of https://github.com/0x8000-0000/CppCoreGuidelines into 0x8000-0000-master
10 years ago
3f3d80d7ec
Reapplying one fix from 680 after a slightly bad merge
10 years ago
6ba822f535
Merge branch 'upgrade-checkers' of https://github.com/tkruse/CppCoreGuidelines into tkruse-upgrade-checkers
10 years ago
7f510892e5
Merge pull request #680 from tkruse/fix-style
...
style fixes
10 years ago
9a9e958955
Manually fixed PR #657
10 years ago
25044afca0
Correct a few typos.
...
A quick inspection with 'aspell -l en_US'.
10 years ago
Gabriel Dos Reis
Bjarne Stroustrup
Jacob Langley
Andrew Pardoe
Andrew Pardoe
Jonathan Wakely
hsutter
teassy000
Sergey Zubkov
mancoast
Johel Ernesto Guerrero Peña
Severin Meyer
Stéphane Magnenat
Titus Winters
Mustafa Serdar Sanli
Jan Nils Ferner
Frank Zingsheim
Doan Tran Cong Danh
Jonathan Wakely
Eliyahu Ravuna
Malcolm Parsons
Derek Li
Oleksandr Senkovych
Krishna Kumar
Rian Quinn
Akim Demaille
Olaf Dietsche
Thibault Kruse
Felix Morgner
Jeroen Habraken
Neil MacIntosh
Arturo Martín-de-Nicolás
Andreas Scherer