From ab7a424ef45a1872cfa89cc7883aaf56788e0954 Mon Sep 17 00:00:00 2001 From: Christopher Jolly Date: Wed, 12 Oct 2022 18:02:12 +0800 Subject: [PATCH] Fix up Design time services to work properly. Add-Migration command in VS will work now --- .../Design/Internal/JetDesignTimeServices.cs | 7 -- .../Internal/JetStringMethodTranslator.cs | 1 + .../BuiltInDataTypesJetTest.cs | 59 ++++------------- .../EFCore.Jet.FunctionalTests.csproj | 66 ------------------- .../EverythingIsBytesJetTest.cs | 21 ++++-- .../JetEndToEndTest.cs | 2 +- .../Query/FromSqlQueryJetTest.cs | 4 +- .../Query/FunkyDataQueryJetTest.cs | 2 +- .../Query/NorthwindWhereQueryJetTest.cs | 16 ++--- .../Query/QueryBugsTest.cs | 10 +-- .../Model79_CantSaveDecimalValue/JetTest.cs | 2 +- 11 files changed, 50 insertions(+), 140 deletions(-) diff --git a/src/EFCore.Jet/Design/Internal/JetDesignTimeServices.cs b/src/EFCore.Jet/Design/Internal/JetDesignTimeServices.cs index 793fa2b..18ba828 100644 --- a/src/EFCore.Jet/Design/Internal/JetDesignTimeServices.cs +++ b/src/EFCore.Jet/Design/Internal/JetDesignTimeServices.cs @@ -35,16 +35,9 @@ namespace EntityFrameworkCore.Jet.Design.Internal #pragma warning disable EF1001 // Internal EF Core API usage. new EntityFrameworkRelationalDesignServicesBuilder(serviceCollection) .TryAdd() - .TryAdd() - .TryAdd() #pragma warning restore EF1001 // Internal EF Core API usage. .TryAdd() .TryAdd() - .TryAddProviderSpecificServices( - b => b - .TryAddSingleton() - .TryAddSingleton() - .TryAddScoped()) .TryAddCoreServices(); } } diff --git a/src/EFCore.Jet/Query/ExpressionTranslators/Internal/JetStringMethodTranslator.cs b/src/EFCore.Jet/Query/ExpressionTranslators/Internal/JetStringMethodTranslator.cs index 04a89ed..ee04731 100644 --- a/src/EFCore.Jet/Query/ExpressionTranslators/Internal/JetStringMethodTranslator.cs +++ b/src/EFCore.Jet/Query/ExpressionTranslators/Internal/JetStringMethodTranslator.cs @@ -59,6 +59,7 @@ namespace EntityFrameworkCore.Jet.Query.ExpressionTranslators.Internal private static readonly MethodInfo _isNullOrWhiteSpace = typeof(string).GetRuntimeMethod(nameof(string.IsNullOrWhiteSpace), new[] {typeof(string)}); + public JetStringMethodTranslator(ISqlExpressionFactory sqlExpressionFactory) => _sqlExpressionFactory = (JetSqlExpressionFactory)sqlExpressionFactory; diff --git a/test/EFCore.Jet.FunctionalTests/BuiltInDataTypesJetTest.cs b/test/EFCore.Jet.FunctionalTests/BuiltInDataTypesJetTest.cs index 842b461..dfa37aa 100644 --- a/test/EFCore.Jet.FunctionalTests/BuiltInDataTypesJetTest.cs +++ b/test/EFCore.Jet.FunctionalTests/BuiltInDataTypesJetTest.cs @@ -220,9 +220,7 @@ WHERE DATEDIFF(SECOND, `m`.`TimeSpanAsTime`, {AssertSqlHelper.Parameter("@__time CharAsNtext = 'H', CharAsInt = 'I', EnumAsNvarchar20 = StringEnumU16.Value4, - EnumAsVarcharMax = StringEnum16.Value2, - SqlVariantString = "Bang!", - SqlVariantInt = 887876 + EnumAsVarcharMax = StringEnum16.Value2 }); Assert.Equal(1, context.SaveChanges()); @@ -380,11 +378,6 @@ WHERE DATEDIFF(SECOND, `m`.`TimeSpanAsTime`, {AssertSqlHelper.Parameter("@__time StringEnum16? param60 = StringEnum16.Value2; Assert.Same(entity, context.Set().Single(e => e.Int == 999 && e.EnumAsVarcharMax == param60)); - object param61 = "Bang!"; - Assert.Same(entity, context.Set().Single(e => e.Int == 999 && e.SqlVariantString.Equals(param61))); - - object param62 = 887876; - Assert.Same(entity, context.Set().Single(e => e.Int == 999 && e.SqlVariantInt.Equals(param62))); } } @@ -574,11 +567,6 @@ WHERE DATEDIFF(SECOND, `m`.`TimeSpanAsTime`, {AssertSqlHelper.Parameter("@__time StringEnum16? param60 = null; Assert.Same(entity, context.Set().Single(e => e.Int == 911 && e.EnumAsVarcharMax == param60)); - - object param61 = null; - Assert.Same(entity, context.Set().Single(e => e.Int == 911 && e.SqlVariantString == param61)); - object param62 = null; - Assert.Same(entity, context.Set().Single(e => e.Int == 911 && e.SqlVariantInt == param62)); } } @@ -716,8 +704,6 @@ WHERE DATEDIFF(SECOND, `m`.`TimeSpanAsTime`, {AssertSqlHelper.Parameter("@__time Assert.Equal('I', entity.CharAsInt); Assert.Equal(StringEnum16.Value2, entity.EnumAsVarcharMax); Assert.Equal(StringEnumU16.Value4, entity.EnumAsNvarchar20); - Assert.Equal("Bang!", entity.SqlVariantString); - Assert.Equal(887876, entity.SqlVariantInt); } private static MappedDataTypes CreateMappedDataTypes(int id) @@ -772,9 +758,7 @@ WHERE DATEDIFF(SECOND, `m`.`TimeSpanAsTime`, {AssertSqlHelper.Parameter("@__time CharAsNtext = 'H', CharAsInt = 'I', EnumAsNvarchar20 = StringEnumU16.Value4, - EnumAsVarcharMax = StringEnum16.Value2, - SqlVariantString = "Bang!", - SqlVariantInt = 887876 + EnumAsVarcharMax = StringEnum16.Value2 }; [ConditionalFact] @@ -902,8 +886,6 @@ WHERE DATEDIFF(SECOND, `m`.`TimeSpanAsTime`, {AssertSqlHelper.Parameter("@__time Assert.Equal('I', entity.CharAsInt); Assert.Equal(StringEnum16.Value2, entity.EnumAsVarcharMax); Assert.Equal(StringEnumU16.Value4, entity.EnumAsNvarchar20); - Assert.Equal("Bang!", entity.SqlVariantString); - Assert.Equal(887876, entity.SqlVariantInt); } private static MappedNullableDataTypes CreateMappedNullableDataTypes(int id) @@ -958,9 +940,7 @@ WHERE DATEDIFF(SECOND, `m`.`TimeSpanAsTime`, {AssertSqlHelper.Parameter("@__time CharAsNtext = 'H', CharAsInt = 'I', EnumAsNvarchar20 = StringEnumU16.Value4, - EnumAsVarcharMax = StringEnum16.Value2, - SqlVariantString = "Bang!", - SqlVariantInt = 887876 + EnumAsVarcharMax = StringEnum16.Value2 }; [ConditionalFact] @@ -1088,8 +1068,6 @@ WHERE DATEDIFF(SECOND, `m`.`TimeSpanAsTime`, {AssertSqlHelper.Parameter("@__time Assert.Null(entity.CharAsInt); Assert.Null(entity.EnumAsNvarchar20); Assert.Null(entity.EnumAsVarcharMax); - Assert.Null(entity.SqlVariantString); - Assert.Null(entity.SqlVariantInt); } [ConditionalFact] @@ -1525,8 +1503,6 @@ parameters, Assert.Equal('I', entity.CharAsInt); Assert.Equal(StringEnum16.Value2, entity.EnumAsVarcharMax); Assert.Equal(StringEnumU16.Value4, entity.EnumAsNvarchar20); - Assert.Equal("Bang!", entity.SqlVariantString); - Assert.Equal(887876, entity.SqlVariantInt); } private static MappedDataTypesWithIdentity CreateMappedDataTypesWithIdentity(int id) @@ -1581,9 +1557,7 @@ parameters, CharAsNtext = 'H', CharAsInt = 'I', EnumAsNvarchar20 = StringEnumU16.Value4, - EnumAsVarcharMax = StringEnum16.Value2, - SqlVariantString = "Bang!", - SqlVariantInt = 887876 + EnumAsVarcharMax = StringEnum16.Value2 }; [ConditionalFact] @@ -1761,8 +1735,6 @@ parameters, Assert.Equal('I', entity.CharAsInt); Assert.Equal(StringEnum16.Value2, entity.EnumAsVarcharMax); Assert.Equal(StringEnumU16.Value4, entity.EnumAsNvarchar20); - Assert.Equal("Bang!", entity.SqlVariantString); - Assert.Equal(887876, entity.SqlVariantInt); } private static MappedNullableDataTypesWithIdentity CreateMappedNullableDataTypesWithIdentity(int id) @@ -1817,9 +1789,7 @@ parameters, CharAsNtext = 'H', CharAsInt = 'I', EnumAsNvarchar20 = StringEnumU16.Value4, - EnumAsVarcharMax = StringEnum16.Value2, - SqlVariantString = "Bang!", - SqlVariantInt = 887876 + EnumAsVarcharMax = StringEnum16.Value2 }; [ConditionalFact] @@ -1950,8 +1920,6 @@ parameters, Assert.Null(entity.CharAsInt); Assert.Null(entity.EnumAsNvarchar20); Assert.Null(entity.EnumAsVarcharMax); - Assert.Null(entity.SqlVariantString); - Assert.Null(entity.SqlVariantInt); } [ConditionalFact] @@ -3331,11 +3299,11 @@ UnicodeDataTypes.StringUnicode ---> `nullable nvarchar` [MaxLength = -1] [Column(TypeName = "nvarchar(20)")] public StringEnumU16 EnumAsNvarchar20 { get; set; } - [Column(TypeName = "sql_variant")] + /*[Column(TypeName = "sql_variant")] public object SqlVariantString { get; set; } [Column(TypeName = "sql_variant")] - public object SqlVariantInt { get; set; } + public object SqlVariantInt { get; set; }*/ } protected class MappedSizedDataTypes @@ -3598,11 +3566,12 @@ UnicodeDataTypes.StringUnicode ---> `nullable nvarchar` [MaxLength = -1] [Column(TypeName = "nvarchar(20)")] public StringEnumU16? EnumAsNvarchar20 { get; set; } - [Column(TypeName = "sql_variant")] + //no sql_variant for Jet + /*[Column(TypeName = "sql_variant")] public object SqlVariantString { get; set; } [Column(TypeName = "sql_variant")] - public object SqlVariantInt { get; set; } + public object SqlVariantInt { get; set; }*/ } protected class MappedDataTypesWithIdentity @@ -3759,11 +3728,11 @@ UnicodeDataTypes.StringUnicode ---> `nullable nvarchar` [MaxLength = -1] [Column(TypeName = "nvarchar(20)")] public StringEnumU16 EnumAsNvarchar20 { get; set; } - [Column(TypeName = "sql_variant")] + /*[Column(TypeName = "sql_variant")] public object SqlVariantString { get; set; } [Column(TypeName = "sql_variant")] - public object SqlVariantInt { get; set; } + public object SqlVariantInt { get; set; }*/ } protected class MappedSizedDataTypesWithIdentity @@ -4031,11 +4000,11 @@ UnicodeDataTypes.StringUnicode ---> `nullable nvarchar` [MaxLength = -1] [Column(TypeName = "nvarchar(20)")] public StringEnumU16? EnumAsNvarchar20 { get; set; } - [Column(TypeName = "sql_variant")] + /*[Column(TypeName = "sql_variant")] public object SqlVariantString { get; set; } [Column(TypeName = "sql_variant")] - public object SqlVariantInt { get; set; } + public object SqlVariantInt { get; set; }*/ } public class ColumnInfo diff --git a/test/EFCore.Jet.FunctionalTests/EFCore.Jet.FunctionalTests.csproj b/test/EFCore.Jet.FunctionalTests/EFCore.Jet.FunctionalTests.csproj index b173770..77d9cbf 100644 --- a/test/EFCore.Jet.FunctionalTests/EFCore.Jet.FunctionalTests.csproj +++ b/test/EFCore.Jet.FunctionalTests/EFCore.Jet.FunctionalTests.csproj @@ -84,45 +84,12 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -166,45 +133,12 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/test/EFCore.Jet.FunctionalTests/EverythingIsBytesJetTest.cs b/test/EFCore.Jet.FunctionalTests/EverythingIsBytesJetTest.cs index 28da8a3..a3b5491 100644 --- a/test/EFCore.Jet.FunctionalTests/EverythingIsBytesJetTest.cs +++ b/test/EFCore.Jet.FunctionalTests/EverythingIsBytesJetTest.cs @@ -10,6 +10,7 @@ using Microsoft.EntityFrameworkCore.Storage; using Microsoft.EntityFrameworkCore.TestUtilities; using Microsoft.Extensions.DependencyInjection; using Xunit; +using System.Linq; // ReSharper disable InconsistentNaming namespace EntityFrameworkCore.Jet.FunctionalTests @@ -199,6 +200,18 @@ UnicodeDataTypes.StringUnicode ---> `nullable varbinary` [MaxLength = -1] public override DateTime DefaultDateTime => new DateTime(); public override bool PreservesDateTimeKind { get; } + public override string ReallyLargeString + { + get + { + //Jet max is 255 + var res = string.Join("", Enumerable.Repeat("testphrase", 25)); + return res; + } + } + + public override int LongStringLength => 255; + public override DbContextOptionsBuilder AddOptions(DbContextOptionsBuilder builder) => base .AddOptions(builder) @@ -274,14 +287,14 @@ UnicodeDataTypes.StringUnicode ---> `nullable varbinary` [MaxLength = -1] var isFixedLength = mappingInfo.IsFixedLength == true; - var size = mappingInfo.Size ?? (mappingInfo.IsKeyOrIndex ? (int?)900 : null); - if (size > 8000) + var size = mappingInfo.Size ?? (mappingInfo.IsKeyOrIndex ? (int?)255 : null); + if (size > 510) { - size = isFixedLength ? 8000 : (int?)null; + size = isFixedLength ? 510 : (int?)null; } return new JetByteArrayTypeMapping( - "varbinary(" + (size == null ? "max" : size.ToString()) + ")", + "varbinary(" + (size == null ? "510" : size.ToString()) + ")", size, isFixedLength, storeTypePostfix: size == null ? StoreTypePostfix.None : (StoreTypePostfix?)null); diff --git a/test/EFCore.Jet.FunctionalTests/JetEndToEndTest.cs b/test/EFCore.Jet.FunctionalTests/JetEndToEndTest.cs index c4a51ed..a307822 100644 --- a/test/EFCore.Jet.FunctionalTests/JetEndToEndTest.cs +++ b/test/EFCore.Jet.FunctionalTests/JetEndToEndTest.cs @@ -895,7 +895,7 @@ namespace EntityFrameworkCore.Jet.FunctionalTests } } - [ConditionalFact] // Issue #931 + [ConditionalFact(Skip = "Jet does not support Schema")] // Issue #931 public async Task Can_save_and_query_with_schema() { using (var testStore = JetTestStore.CreateInitialized(DatabaseName)) diff --git a/test/EFCore.Jet.FunctionalTests/Query/FromSqlQueryJetTest.cs b/test/EFCore.Jet.FunctionalTests/Query/FromSqlQueryJetTest.cs index 592d159..d186fd7 100644 --- a/test/EFCore.Jet.FunctionalTests/Query/FromSqlQueryJetTest.cs +++ b/test/EFCore.Jet.FunctionalTests/Query/FromSqlQueryJetTest.cs @@ -119,9 +119,9 @@ FROM ( WHERE CHARINDEX('z', `c`.`ContactName`) > 0"); } - public override void FromSqlRaw_queryable_composed_compiled_with_parameter() + public override async Task FromSqlRaw_queryable_composed_compiled_with_parameter(bool async) { - base.FromSqlRaw_queryable_composed_compiled_with_parameter(); + await base.FromSqlRaw_queryable_composed_compiled_with_parameter(async); AssertSql( $@"SELECT `c`.`CustomerID`, `c`.`Address`, `c`.`City`, `c`.`CompanyName`, `c`.`ContactName`, `c`.`ContactTitle`, `c`.`Country`, `c`.`Fax`, `c`.`Phone`, `c`.`PostalCode`, `c`.`Region` diff --git a/test/EFCore.Jet.FunctionalTests/Query/FunkyDataQueryJetTest.cs b/test/EFCore.Jet.FunctionalTests/Query/FunkyDataQueryJetTest.cs index b130f78..0851780 100644 --- a/test/EFCore.Jet.FunctionalTests/Query/FunkyDataQueryJetTest.cs +++ b/test/EFCore.Jet.FunctionalTests/Query/FunkyDataQueryJetTest.cs @@ -116,7 +116,7 @@ WHERE CHARINDEX({AssertSqlHelper.Parameter("@__prm8_0")}, `f`.`FirstName`) <= 0" $@"SELECT `f`.`FirstName` AS `fn`, `f0`.`LastName` AS `ln` FROM `FunkyCustomers` AS `f`, `FunkyCustomers` AS `f0` -WHERE (`f0`.`LastName` = '') OR (CHARINDEX(`f0`.`LastName`, `f`.`FirstName`) > 0)"); +WHERE (INSTR(1, `f`.`FirstName`, `f0`.`LastName`, 0) > 0) OR (`f0`.`LastName` = '')"); } public override async Task String_contains_on_argument_with_wildcard_column_negated(bool isAsync) diff --git a/test/EFCore.Jet.FunctionalTests/Query/NorthwindWhereQueryJetTest.cs b/test/EFCore.Jet.FunctionalTests/Query/NorthwindWhereQueryJetTest.cs index 13bef55..37631ce 100644 --- a/test/EFCore.Jet.FunctionalTests/Query/NorthwindWhereQueryJetTest.cs +++ b/test/EFCore.Jet.FunctionalTests/Query/NorthwindWhereQueryJetTest.cs @@ -508,7 +508,7 @@ WHERE `e`.`EmployeeID` = 1"); AssertSql( $@"SELECT `e`.`EmployeeID`, `e`.`City`, `e`.`Country`, `e`.`FirstName`, `e`.`ReportsTo`, `e`.`Title` FROM `Employees` AS `e` -WHERE False = True"); +WHERE 0 = 1"); // See issue#17498 //Assert.Contains( @@ -535,11 +535,11 @@ WHERE `e`.`EmployeeID` = {AssertSqlHelper.Parameter("@__p_0")}"); AssertSql( $@"SELECT `e`.`EmployeeID`, `e`.`City`, `e`.`Country`, `e`.`FirstName`, `e`.`ReportsTo`, `e`.`Title` FROM `Employees` AS `e` -WHERE False = True", +WHERE 0 = 1", // $@"SELECT `e`.`EmployeeID`, `e`.`City`, `e`.`Country`, `e`.`FirstName`, `e`.`ReportsTo`, `e`.`Title` FROM `Employees` AS `e` -WHERE False = True"); +WHERE 0 = 1"); // See issue#17498 //Assert.Contains( @@ -558,11 +558,11 @@ WHERE False = True"); AssertSql( $@"SELECT `e`.`EmployeeID`, `e`.`City`, `e`.`Country`, `e`.`FirstName`, `e`.`ReportsTo`, `e`.`Title` FROM `Employees` AS `e` -WHERE False = True", +WHERE 0 = 1", // $@"SELECT `e`.`EmployeeID`, `e`.`City`, `e`.`Country`, `e`.`FirstName`, `e`.`ReportsTo`, `e`.`Title` FROM `Employees` AS `e` -WHERE False = True"); +WHERE 0 = 1"); // See issue#17498 //Assert.Contains( @@ -888,7 +888,7 @@ FROM `Customers` AS `c`"); AssertSql( $@"SELECT `c`.`CustomerID`, `c`.`Address`, `c`.`City`, `c`.`CompanyName`, `c`.`ContactName`, `c`.`ContactTitle`, `c`.`Country`, `c`.`Fax`, `c`.`Phone`, `c`.`PostalCode`, `c`.`Region` FROM `Customers` AS `c` -WHERE False = True"); +WHERE 0 = 1"); } public override async Task Where_is_not_null(bool isAsync) @@ -908,7 +908,7 @@ WHERE `c`.`City` IS NOT NULL"); AssertSql( $@"SELECT `c`.`CustomerID`, `c`.`Address`, `c`.`City`, `c`.`CompanyName`, `c`.`ContactName`, `c`.`ContactTitle`, `c`.`Country`, `c`.`Fax`, `c`.`Phone`, `c`.`PostalCode`, `c`.`Region` FROM `Customers` AS `c` -WHERE False = True"); +WHERE 0 = 1"); } public override async Task Where_constant_is_not_null(bool isAsync) @@ -1236,7 +1236,7 @@ FROM `Customers` AS `c`"); AssertSql( $@"SELECT `c`.`CustomerID`, `c`.`Address`, `c`.`City`, `c`.`CompanyName`, `c`.`ContactName`, `c`.`ContactTitle`, `c`.`Country`, `c`.`Fax`, `c`.`Phone`, `c`.`PostalCode`, `c`.`Region` FROM `Customers` AS `c` -WHERE False = True"); +WHERE 0 = 1"); } public override async Task Where_default(bool isAsync) diff --git a/test/EFCore.Jet.FunctionalTests/Query/QueryBugsTest.cs b/test/EFCore.Jet.FunctionalTests/Query/QueryBugsTest.cs index ff2a78b..e709803 100644 --- a/test/EFCore.Jet.FunctionalTests/Query/QueryBugsTest.cs +++ b/test/EFCore.Jet.FunctionalTests/Query/QueryBugsTest.cs @@ -2397,7 +2397,7 @@ WHERE `e`.`Id` IN ( Assert.Equal(3, context.Cache.Count); AssertSql( - $@"{AssertSqlHelper.Declaration("@__name_0='A' (Size = 4000)")} + $@"{AssertSqlHelper.Declaration("@__name_0='A' (Size = 255)")} SELECT `e`.`Id`, `e`.`Name` FROM `Entities` AS `e` @@ -4920,7 +4920,7 @@ ORDER BY `p`.`Id`, `t0`.`Id`"); context.SaveChanges(); AssertSql( - $@"{AssertSqlHelper.Declaration("@p0='BaseEntity13079' (Nullable = false) (Size = 4000)")} + $@"{AssertSqlHelper.Declaration("@p0='BaseEntity13079' (Nullable = false) (Size = 255)")} SET NOCOUNT ON; INSERT INTO `BaseEntities` (`Discriminator`) @@ -6085,7 +6085,7 @@ WHERE `f`.`String` = '1337'"); var query = context.Foos.Where(f => f.String == bar.Value).ToList(); AssertSql( - $@"{AssertSqlHelper.Declaration("@__bar_Value_0='1337' (Size = 4000)")} + $@"{AssertSqlHelper.Declaration("@__bar_Value_0='1337' (Size = 255)")} SELECT `f`.`Id`, `f`.`String` FROM `Foos` AS `f` @@ -6106,7 +6106,7 @@ WHERE `f`.`String` = {AssertSqlHelper.Parameter("@__bar_Value_0")}"); var query = context.Foos.Where(f => f.String == bar.ToString()).ToList(); AssertSql( - $@"{AssertSqlHelper.Declaration("@__ToString_0='1337' (Size = 4000)")} + $@"{AssertSqlHelper.Declaration("@__ToString_0='1337' (Size = 255)")} SELECT `f`.`Id`, `f`.`String` FROM `Foos` AS `f` @@ -6127,7 +6127,7 @@ WHERE `f`.`String` = {AssertSqlHelper.Parameter("@__ToString_0")}"); var query = context.Foos.Where(f => f.String == bar).ToList(); AssertSql( - $@"{AssertSqlHelper.Declaration("@__p_0='1337' (Size = 4000)")} + $@"{AssertSqlHelper.Declaration("@__p_0='1337' (Size = 255)")} SELECT `f`.`Id`, `f`.`String` FROM `Foos` AS `f` diff --git a/test/EFCore.Jet.IntegrationTests/Model79_CantSaveDecimalValue/JetTest.cs b/test/EFCore.Jet.IntegrationTests/Model79_CantSaveDecimalValue/JetTest.cs index 14b89d1..a23a56a 100644 --- a/test/EFCore.Jet.IntegrationTests/Model79_CantSaveDecimalValue/JetTest.cs +++ b/test/EFCore.Jet.IntegrationTests/Model79_CantSaveDecimalValue/JetTest.cs @@ -11,7 +11,7 @@ namespace EntityFrameworkCore.Jet.IntegrationTests.Model79_CantSaveDecimalValue { protected override DbConnection GetConnection() { - return Helpers.GetJetConnection(); + return Helpers.CreateAndOpenJetDatabase(); } } }