how-to
/
CppCoreGuidelines
mirror of https://github.com/isocpp/CppCoreGuidelines.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,191 Commits
14 Branches
4 Tags
184 MiB
master
gh-pages
2170-hs
concrete-terminology
cast-to-void-cleanup
string_span-excision
For-1446
es23-updates
neilmacintosh-ES70-fix
hs-index
travis-errors
t84-example
revert-825-interfaces_non_trivial_fixes
H1
v0.7
v0.6
v0.1
v0.8
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'f52da2b27e'
${ noResults }
Commit Graph

2191 Commits (f52da2b27e03376f4b471b92bfeeb4e07ccda655)
 

Author SHA1 Message Date
nullptr-cpp 8bdb8fe0dc
Add '<=>' to comparison operators related rules (C.87, C.167) (#1759) 
* Add '<=>' to comparison operators related rules (C.87, C.167)

C++20's three-way comparison operator should respect the same rules as other
comparison operators.

* Fix a minor typo

Co-authored-by: Jonathan Wakely <github@kayari.org>

Co-authored-by: Jonathan Wakely <github@kayari.org>
 5 years ago
nullptr-cpp 5f75ea4b4b
C.63: Fix a minor typo (#1760) 
In accordance with the title at line 4568, use `const&` instead of `const &`.
 5 years ago
Sergey Zubkov af44f95577 and another fix to md-split.py for CI 5 years ago
Sergey Zubkov f36b3ccaa4 fix md-split.py for CI 5 years ago
Sergey Zubkov 1dd82988d7 make CI happier 5 years ago
Sergey Zubkov ee28f50025 dict update for CI 5 years ago
Herb Sutter 4f0659fb75 Added CP.coro and CP.51, closes #1756 5 years ago
Herb Sutter ccb7eff4ec CP.1: Made "bad" example consistent with now-updated "good" example 5 years ago
Martin ffeca2a254
Change comparison to use int instead of double (#1758) 
This allows the example to remain simple well not misleading a beginner
such a comparison is safe. Including an epsilon comparison or something
similar would overly complicate this example.

Co-authored-by: Martin O'Shea <martin.oshea@native-instruments.com>
 5 years ago
JuliusBrueggemann 1caef9a7f1 Use the same phrasing in index and actual rule 5 years ago
Herb Sutter c57e95d1c8 Clarify meaning of "inline" in F.5, closes #1731 5 years ago
Herb Sutter fa56634596 Add local lambdas and variable templates to T.61: Closes #1742 5 years ago
Herb Sutter 64ab13b3d0 Closes #1748 5 years ago
Herb Sutter a97be2d528 Addresses #1732 5 years ago
Sergey Zubkov 3e61563a0c make hunspell happy 5 years ago
Herb Sutter 75cc9a102f Improves I.24 rule wording, closes #1733 5 years ago
Herb Sutter caab79d1e9 Improving the wording of I.25 per #1734 5 years ago
Herb Sutter f46ce437e0 Slightly improved F.20 to highlight the note about const return values 5 years ago
syntroniks a5a4d0b4a2
update Enum.7 note with consistent capitalization (#1739) 5 years ago
Sergey Zubkov f6f1a49a41 typo 5 years ago
Herb Sutter 3c1991b87b Updated T.68 example 5 years ago
Herb Sutter 520ac9c695 Updated the new ES.3 
Added xref, massaged summary.
 5 years ago
shaneasd 627ed66ce6
Update reference to SF.7 to match text (#1735) 5 years ago
Florian Behrens c142bc9d7e
Improve example in CP.4 to not contradict F.53. (#1724) 
Changed the example so that objects are not passed by reference to other thread contexts (though threads are properly synchronized).
 5 years ago
peno2 b5412f5922
Add new rule ES.3 Don't repeat yourself (#1715) 
* Add new rule ES.3 Don't repeat yourself

* Replace function example with more inclusive/neutral language

Add a reference to topic on libraries.
 5 years ago
Sergey Zubkov 2c95a33fef travis CI fixes 5 years ago
David Leal cef2f6bb77
Replace Travis CI with GitHub Actions (#1688) 5 years ago
Niels Dekker e2c0f23ce1
F.60: Remove C-style cast (T&) from example of invalid C++ (#1711) 5 years ago
Herb Sutter a6eb40c5a2 Improved F.7 lifetime note; closes #1698 5 years ago
Herb Sutter 5fdddf821d Added a justification message option for `gsl::suppress` 
Closes #1703
 5 years ago
Herb Sutter 53aaebb074 Updated Mozilla link and Google style guide C++ version note 
Closes #1705
 5 years ago
Fernando J. Iglesias García 525d8f225e
Update C.83 with swap for resource mgmt. (#1694) 
* Update C.83 with swap for resource mgmt.

The swap is useful to implement assignments idiomatically (e.g. copy-swap idiom).

With the current enforcement, to non-virtual classes, very simple classes (e.g. `trivially_copyable`, a struct encapsulating an stl container) are suggested to have a swap. This suggestion can be argued wrong since for very simple classes copy-swap idiom is not efficient (the creation of a third object on assignment is not needed, which copy-swap does).

* Rework C.83 according to PR comments.
 5 years ago
Sergey Zubkov 840fa592ac
merge C.150 in R.23, leaving a redirect behind (#1676) 5 years ago
hsutter dd98129f40 Fixes example in ES.105, closes #1678 5 years ago
hsutter 6ad29ce609 Fixes ES.50 example and closes #1682 
Also removes the only use of `decltype` in the Guidelines, FTW.
 5 years ago
Herb Sutter 55bea2089b
Remove string_span, recommend using `std::string_view`, `std:::span,<char>` or `gsl::span<char>` instead (#1680) 5 years ago
Herb Sutter 146864fe89
Cleaned up casting guidance (#1685) 
The various guidelines now have consistent Enforcements.
All C-style casts are now consistently banned, including to `(void)`.
Cast to `(void`)` should be `std::ignore =` instead.
All functional-style casts are now consistently banned,  instead of
`T(x)` use `T{x}`.
 5 years ago
Sergey Zubkov 86102531dc
merge C.151 into R.22, leaving a redirect behind (#1675) 5 years ago
Sergey Zubkov 30b41c32e3
merge R.30 and F.7, closes #1671 (#1674) 5 years ago
hsutter c86be249f3 Revert "Revert "Revert "Removed gsl::string_span, recommend using std::string_view, std::span<char>, or gsl::span<char> instead""" 
This reverts commit 8241609450.
 5 years ago
hsutter 8241609450 Revert "Revert "Removed gsl::string_span, recommend using std::string_view, std::span<char>, or gsl::span<char> instead"" 
This reverts commit f15ee43ad6.
 5 years ago
hsutter f15ee43ad6 Revert "Removed gsl::string_span, recommend using std::string_view, std::span<char>, or gsl::span<char> instead" 
This reverts commit 5257915dee.
 5 years ago
hsutter 5257915dee Removed gsl::string_span, recommend using std::string_view, std::span<char>, or gsl::span<char> instead 5 years ago
Gabriel Dos Reis ab34c8b6b0
Merge pull request #1679 from N-Dekker/E.30-Remove-suggestion-to-use-throw() 
E.30: Remove suggestion to use `throw()`
 5 years ago
Niels Dekker 0d46b2006c E.30: Remove suggestion to use `throw()` 
Removed the suggestion to use `throw()` from E.30 ("Don't use exception specifications"), as it was deprecated by C++11, and is rejected by C++20.
 5 years ago
hsutter 2e3f983971 Restored whitespace after "might" 
Fixing previous commit where we ate the whitespace after "may" in four
places (yay regex search `might[^\s]`)
 5 years ago
hsutter 75406a2db8 Remove "may" except for the month name -- closes #1542 
In English, the word "may" is overloaded and ambiguous. This commit
changes it to "might" wherever possible, otherwise more specific
meanings like "can," "could," or especially "must" ("may not" -> "must
not" when that is intended).
 5 years ago
David B fae4ed3768
ES.103 examples updated, addresses Issue #1656 (#1659) 
* ES.103 examples updated, addresses Issue #1656

* Fix cpplint report: Res-overflow0.cpp:18:  Missing spaces around <=  [whitespace/operators] [3]
 5 years ago
rjhcnf bdccf49849
added minor clarification. (#1672) 
* added minor clarification.

* Update CppCoreGuidelines.md

Updated comment.

* Update CppCoreGuidelines.md
 5 years ago
Gabriel Dos Reis 739dc98dff
Merge pull request #1664 from johnmcfarlane/patch-1 
Add clarifying example to SF.12
 5 years ago