Commit Graph

1222 Commits (e3f753ed14c61dcb0d42b2ce202d4281e888e51a)

Author SHA1 Message Date
Andrew Pardoe 0a85bd8382 Merge pull request #1059 from luav/example-cp.4
Example CP.4 (task vs thread)
8 years ago
Jonathan Wakely 7a5ab334a0 Update CppCoreGuidelines.md 8 years ago
Andrew Pardoe a1b3a269fc Merge pull request #1053 from sgkim126/master
Fix typos in example.
8 years ago
Andrew Pardoe 19d7fb1421 Update CppCoreGuidelines.md 8 years ago
Andrew Pardoe 17f76d0258 Update CppCoreGuidelines.md 8 years ago
Andrew Pardoe 3d282d21ed Merge pull request #1061 from planetchili/master
struct -> class to conform to C8
8 years ago
Andrew Pardoe 3575bf6d43 Update CppCoreGuidelines.md 8 years ago
Jay Bazuzi a277ba71da Update forward looking statement. 8 years ago
Yogendra Singh c4f833ad5c Simple typo fix. (#1060) 8 years ago
Jonathan Wakely 74cab35f85 Improve hyperlink text in C.8 8 years ago
chili ace8d7b279 struct -> class to conform to C8 8 years ago
luav 17fe8a957f Manual non-async task removed 8 years ago
luav 147f4d2dc3 Spaces in blank lines removed 8 years ago
luav f8159d26e0 Formatting and grammer fixed 8 years ago
luav 45376bb6b2 Example CP.4 (task vs thread) 8 years ago
Jonathan Wakely e251862408 Adjust "formatting" to pass spellchecking 8 years ago
Seulgi Kim 05c44d23ab Fix typos in example. 8 years ago
Andrew Pardoe f3596553a5 .\CppCoreGuidelines.md 8 years ago
Tom Isaacson 9cf0fcf19d #1045 Fix reference to narrow_cast (#1046) 8 years ago
Jonathan Wakely 58e80fc2c5 Adjust "incomplet and incorrekt" joke.
This adjusts it to be closer to the form in the C++ working drafts.

Fixes #1043
8 years ago
Jonathan Wakely 6153d69b2c Fix CI errors due to missing whitespace around operators (#1037)
Also rephrase comments to avoid overlong lines.
8 years ago
JonasToth 2184c57dd1 reorder sections C.167 and C.168 to be in numerical ascending order (#1034) 8 years ago
Franz Hollerer 531952a300 Issue #999 c128 applied to c129 (#1036) 8 years ago
Artem Golubikhin d318a68e35 ES.20: Fix typo (#1033) 8 years ago
hsutter 1b2ba25b4b Closes #997 8 years ago
Andrew Pardoe 74c36a43b0 Fixing ES.87 8 years ago
Artem Golubikhin f77fa1ad40 R.1: Fix finally link 8 years ago
Bjarne Stroustrup 6574f05356 added ES.87 about conditions in if-statements
#1006 and #1010
8 years ago
Bjarne Stroustrup 1a3de0e9b8 add a cross reference to P.3 8 years ago
Bjarne Stroustrup 2839c87890 add example to R.20
addresses #1015
8 years ago
Neil MacIntosh b87d21b662 Merge pull request #1018 from Cleroth/patch-1
Avoid `std::endl` :)
8 years ago
Gabriel Dos Reis 6d5a219e66 Merge pull request #1023 from marzojr/master
Fixing memory handling in E.5 example
8 years ago
Gabriel Dos Reis 26f3ee9cfd Fix #998. 8 years ago
Gabriel Dos Reis 7146b55d30 Fix #1008. 8 years ago
Sebastian Valle 9840eefacf CP.2: Fixed a typo in the async example code. (#1030)
span a task -> spawn a task
9 years ago
tg-m 7a3d3c5a29 Fix issue #1026 (#1027) 9 years ago
Ivan Baidakou c2456ccf5b Fix typo: `Public` -> `public` (#1025) 9 years ago
Andrew Pardoe c04e3657fb Updating date 9 years ago
Marzo Sette Torres Junior 0bb69d80e6 Fixing memory handling in E.5 example
Instead of constructing an array, it constructs and deletes a single double, and accesses elements as if it had constructed an array.
9 years ago
Cleroth d51a304e0a Update CppCoreGuidelines.md 9 years ago
TalLancaster e61f111301 Per C.66: a global edit adding noexcept to move constructor/assignment examples (#1016) 9 years ago
Cleroth 43f378c6b3 Avoid `std::endl` :) 9 years ago
Gabriel Dos Reis 4ffab15e77 Merge pull request #1012 from franzhollerer/aligning_case_with_switch
aligning case with switch
9 years ago
Gabriel Dos Reis e5e7082efa Merge pull request #1013 from franzhollerer/opening_brace_in_same_line_as_switch
opening brace in same line with switch statement to be aligned with NL.17
9 years ago
Björn Schäpers 378370e20d Fix typo in ES.84 9 years ago
Franz Hollerer 1cc009bb57 placing opening brace in same line with switch statement to be aligned with NL.17 9 years ago
Franz Hollerer 83561b15eb aligning case with switch 9 years ago
Andrew Pardoe 82755da679 Fixing NL.17 per issue #1002 discussion 9 years ago
Ben 4b6e6eb190 Fix example in C.61 9 years ago
Benoît Blanchon 150744a8d3 Fix example in CP.21 (#1007) 9 years ago
Jonathan Bohren 69f749bf7f Fixing typo / improving language in NR.3 (#1005)
Current text has a plurality typo ("separates" vs "separate"), modified version more precisely conveys the idea.
9 years ago
Jonathan Wakely 9c9d8d2dfc Separate good example from bad
Fixes #1001
9 years ago
Gabriel Dos Reis 8249a49c69 Merge pull request #625 from GlassAndOneHalf/example-update
Issue #624 ES.34 Add Example.
9 years ago
hsutter f0935e33b1 Closes #315 9 years ago
hsutter f01bded2a1 Elminated 's' typo 9 years ago
hsutter a55cd51662 Fixed typos introduced when 'fixing' PR merge 9 years ago
jeanphilippeD 1d8ed2b59e Fix CP.3 to allow local reasoning and compilation without error (#951)
* Fix CP.3 to allow local reasoning and compilation without error

(CP.3: Minimize explicit sharing of writable data)

Use 'ES.28: Use lambdas for complex initialization,
especially of const variables' to ensure we can see from the body
of the function that the function called in async only require const
parameter.

This ensure that if a non local change to the function signature
(making the const parameter non const) it will result in a compilation
error.

Added necessary construct and compiled with https://godbolt.org/g/tjGXbV

* Update CppCoreGuidelines.md
9 years ago
Gabriel Dos Reis 0de765443a Merge pull request #974 from Talkless/patch-1
Fix if statement for checking error condition
9 years ago
Jonathan Wakely 898f819b00 Add [Abrahams01] bibliography entry for exception-safety (#991)
Link to it when talking about the strong and basic exception-safety
guarantees.

Add it to the dictionary.
9 years ago
Gabriel Dos Reis 45fff26517 Merge pull request #976 from willwray/patch-1
Fix Inconsistent definition of czstring in comments
9 years ago
Jonathan Wakely 7e7e1d8926 Move period outside parenthesis 9 years ago
Gabriel Dos Reis cf223f3cb8 Merge pull request #992 from isocpp/broken-links
Replace broken links to #Rf-pass-ref-ref and #Rf-pass-ref-move
9 years ago
Gabriel Dos Reis 2a1472657f Merge pull request #990 from isocpp/issue-989
Remove confusing "copy" in discussion of move ops
9 years ago
Abigail 56df32bd95 Fix typo in C.8 (#985) 9 years ago
Jonathan Wakely 3924087459 Replace broken links to #Rf-pass-ref-ref and #Rf-pass-ref-move 9 years ago
Jonathan Wakely 3a6466f09c Fix anchor links with double hash symbols 9 years ago
Jonathan Wakely 598e6f99b6 Fix cross-references to [C++03] and [C++CS]
Anchors should be #Cplusplus03 and #CplusplusCS not #C++03 and #C++CS.
9 years ago
Jonathan Wakely 498eb97dd2 Remove repetition of "as well"
Fixes #983
9 years ago
Jonathan Wakely 1143bfab79 Remove confusing "copy" in discussion of move ops
Fixes #989
9 years ago
Andrew Pardoe bf7d7da165 updating date 9 years ago
michaelz85 e9b627f209 C.64 fixed typo (#987) 9 years ago
Jonathan Wakely 24b733f0b9 NL.17 fix typo
Fixes #982
9 years ago
Felix Kälberer d26dde2a4f Fix Fibonacci sequence
A number sequence called `fib` should be the Fibonacci sequence or have a different name.

https://en.wikipedia.org/wiki/Fibonacci_number
9 years ago
Andrew Pardoe f6ba91e90a update date 9 years ago
Will Wray 5ffabce718 Fix Inconsistent definition of czstring in comments
Comments in sections  SL.str.3 and GSL.view disagree on whether czstring may be the nullptr.

This PR fixes the first comment definition in SL.str.3 that czstring `is a C-style string that is not the nullptr`

### SL.str.3: Use zstring or czstring to refer to a C-style, zero-terminated, sequence of characters
```
void f1(zstring s);     // s is a C-style string or the nullptr
void f1(czstring s);    // s is a C-style string that is not the nullptr
```
### GSL.view: Views
`zstring` // a `char*` supposed to be a C-style string; that is, a zero-terminated sequence of `char` or `nullptr`
`czstring` // a `const char*` supposed to be a C-style string; that is, a zero-terminated sequence of const `char` or `nullptr`
9 years ago
Vincas Dargis 0b1b5bbac8 Fix if statement for checking error condition
Example mentions that it handles error, and errors are commonly non-zero values.

Closes #970
9 years ago
Andrew Pardoe 66fc5d4f5c Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines 9 years ago
Andrew Pardoe 7ba2317992 Updating date 9 years ago
Andrew Pardoe a3860f3cc2 Merge pull request #971 from tkruse/style-fixes2
Style fixes for compile-time, run-time and similar
9 years ago
Thibault Kruse d13bfcda64 Consistent hyphenation of ajectives like lock-free, well-defined, old-style,... 9 years ago
Thibault Kruse 015ee8df10 make 'non-' prefix spelling consistent 9 years ago
Thibault Kruse 9159315d8c make non-`const` spelling consistent 9 years ago
Thibault Kruse ba82be70bd make 'side effect' vs. 'side-effect' spelling consistent 9 years ago
Thibault Kruse 172520b570 make 'reuse' vs. 're-use' spelling consistent 9 years ago
Thibault Kruse d14067a5b4 make 'error-prone' usage consistent 9 years ago
Thibault Kruse 9aa9e8fc9f fix hyphenation of ...-allocated adcjectives 9 years ago
Thibault Kruse 95b001c0d8 fix hyphenation of open-source 9 years ago
Thibault Kruse 00f9e9ae50 fix bad hyphen for standard-library as adjective 9 years ago
Thibault Kruse d28a46983e Fix missing comma 9 years ago
Thibault Kruse b4c1e30743 Make usage of run-time, compile-time, lifetime, real-time and hard-real-time consistent 9 years ago
Thibault Kruse f70ca3ee9e Consistent formatting of interval ranges 9 years ago
Andrew Pardoe 69d2341c1e Fixing edit fail 9 years ago
Andrew Pardoe b3b329f937 Fixing up suggestions from Issues 505 and 496 9 years ago
Andrew Pardoe 2bd4a7c9ad Fix Enforcement for C.151 after PR #952 9 years ago
Andrew Pardoe 8c0f764b77 Merge pull request #952 from tkruse/code-fixes
small issues found trying to compile examples
9 years ago
Rory Jaffe 24fa6d4b00 Added break to each case in switch statement 9 years ago
Thibault Kruse b02eb91b84 code fixes 9 years ago
Sergey Zubkov 22c305fdee travis fixes and a typo 9 years ago
Thibault Kruse 70655d1131 Fix typos and change spellcheck call to not check URLs (#961) 9 years ago
Jacob Taylor Hindle e12e73e670 ES.34 Add alternative example. 9 years ago