bdc07cc4ef
Fix link to Rt-concepts
...
Fixes #1099
8 years ago
771a75e183
Add note to make deleted methods public
8 years ago
eb0707d7ae
Add public access modifier to examples
8 years ago
e6ac978f3a
Updated due to discussion about #1068
8 years ago
2b4438603c
Updating date
8 years ago
0a6167e1fc
Merge pull request #1066 from brenoguim/hotfix/add-virtual-destructor
...
Add virtual destructor to base class "Device"
8 years ago
0364ecace7
Merge pull request #1073 from martinfinke/hotfix/avoid-magic-constant
...
Avoid magic constant in F.44
8 years ago
b553f02f84
Merge pull request #1075 from Eliyahu-Ravuna/patch-2
...
Link added for function objects and lambdas
8 years ago
16e270dee9
Typo: add missing question mark
8 years ago
7f909cc18e
Typo: add missing comma
8 years ago
27d1c01782
Typo: add missing semicolon
8 years ago
3d4e860bdd
Fixed comment in example code of F.54 ( #1082 )
8 years ago
df68bfdc5b
fixed minor typo: `it this` -> `this` (on master) ( #1079 )
8 years ago
90076b9795
Use correct header level ( #1078 )
8 years ago
eb5f6a5b90
Link added for function objects and lambdas
8 years ago
7be6e7daed
Fix typo in destructor name ( #1074 )
...
Itream -> Istream in I.30: Encapsulate rule violations code snippet
8 years ago
d13ac81e27
Avoid magic constant
8 years ago
8a408d8500
reorder ES.expr and ES.stmt in text
8 years ago
3a320fdf53
Add virtual destructor to base class
8 years ago
165c79b417
Break comment to respect 100 column limit ( #1069 )
8 years ago
768e4620d4
Closes #1055
8 years ago
ab67676e7d
Closes #1048
8 years ago
5b82257e15
Changing date
8 years ago
0a85bd8382
Merge pull request #1059 from luav/example-cp.4
...
Example CP.4 (task vs thread)
8 years ago
7a5ab334a0
Update CppCoreGuidelines.md
8 years ago
a1b3a269fc
Merge pull request #1053 from sgkim126/master
...
Fix typos in example.
8 years ago
19d7fb1421
Update CppCoreGuidelines.md
8 years ago
17f76d0258
Update CppCoreGuidelines.md
8 years ago
3d282d21ed
Merge pull request #1061 from planetchili/master
...
struct -> class to conform to C8
8 years ago
3575bf6d43
Update CppCoreGuidelines.md
8 years ago
a277ba71da
Update forward looking statement.
8 years ago
c4f833ad5c
Simple typo fix. ( #1060 )
8 years ago
74cab35f85
Improve hyperlink text in C.8
8 years ago
ace8d7b279
struct -> class to conform to C8
8 years ago
17fe8a957f
Manual non-async task removed
8 years ago
147f4d2dc3
Spaces in blank lines removed
8 years ago
f8159d26e0
Formatting and grammer fixed
8 years ago
45376bb6b2
Example CP.4 (task vs thread)
8 years ago
e251862408
Adjust "formatting" to pass spellchecking
8 years ago
05c44d23ab
Fix typos in example.
8 years ago
f3596553a5
.\CppCoreGuidelines.md
8 years ago
9cf0fcf19d
#1045 Fix reference to narrow_cast ( #1046 )
8 years ago
58e80fc2c5
Adjust "incomplet and incorrekt" joke.
...
This adjusts it to be closer to the form in the C++ working drafts.
Fixes #1043
8 years ago
6153d69b2c
Fix CI errors due to missing whitespace around operators ( #1037 )
...
Also rephrase comments to avoid overlong lines.
8 years ago
2184c57dd1
reorder sections C.167 and C.168 to be in numerical ascending order ( #1034 )
8 years ago
531952a300
Issue #999 c128 applied to c129 ( #1036 )
8 years ago
d318a68e35
ES.20: Fix typo ( #1033 )
8 years ago
1b2ba25b4b
Closes #997
8 years ago
74c36a43b0
Fixing ES.87
8 years ago
f77fa1ad40
R.1: Fix finally link
8 years ago
6574f05356
added ES.87 about conditions in if-statements
...
#1006 and #1010
8 years ago
1a3de0e9b8
add a cross reference to P.3
8 years ago
2839c87890
add example to R.20
...
addresses #1015
8 years ago
b87d21b662
Merge pull request #1018 from Cleroth/patch-1
...
Avoid `std::endl` :)
8 years ago
6d5a219e66
Merge pull request #1023 from marzojr/master
...
Fixing memory handling in E.5 example
8 years ago
26f3ee9cfd
Fix #998 .
8 years ago
7146b55d30
Fix #1008 .
8 years ago
9840eefacf
CP.2: Fixed a typo in the async example code. ( #1030 )
...
span a task -> spawn a task
9 years ago
7a3d3c5a29
Fix issue #1026 ( #1027 )
9 years ago
c2456ccf5b
Fix typo: `Public` -> `public` ( #1025 )
9 years ago
c04e3657fb
Updating date
9 years ago
0bb69d80e6
Fixing memory handling in E.5 example
...
Instead of constructing an array, it constructs and deletes a single double, and accesses elements as if it had constructed an array.
9 years ago
d51a304e0a
Update CppCoreGuidelines.md
9 years ago
e61f111301
Per C.66: a global edit adding noexcept to move constructor/assignment examples ( #1016 )
9 years ago
43f378c6b3
Avoid `std::endl` :)
9 years ago
4ffab15e77
Merge pull request #1012 from franzhollerer/aligning_case_with_switch
...
aligning case with switch
9 years ago
e5e7082efa
Merge pull request #1013 from franzhollerer/opening_brace_in_same_line_as_switch
...
opening brace in same line with switch statement to be aligned with NL.17
9 years ago
378370e20d
Fix typo in ES.84
9 years ago
1cc009bb57
placing opening brace in same line with switch statement to be aligned with NL.17
9 years ago
83561b15eb
aligning case with switch
9 years ago
82755da679
Fixing NL.17 per issue #1002 discussion
9 years ago
4b6e6eb190
Fix example in C.61
9 years ago
150744a8d3
Fix example in CP.21 ( #1007 )
9 years ago
69f749bf7f
Fixing typo / improving language in NR.3 ( #1005 )
...
Current text has a plurality typo ("separates" vs "separate"), modified version more precisely conveys the idea.
9 years ago
9c9d8d2dfc
Separate good example from bad
...
Fixes #1001
9 years ago
8249a49c69
Merge pull request #625 from GlassAndOneHalf/example-update
...
Issue #624 ES.34 Add Example.
9 years ago
f0935e33b1
Closes #315
9 years ago
f01bded2a1
Elminated 's' typo
9 years ago
a55cd51662
Fixed typos introduced when 'fixing' PR merge
9 years ago
1d8ed2b59e
Fix CP.3 to allow local reasoning and compilation without error ( #951 )
...
* Fix CP.3 to allow local reasoning and compilation without error
(CP.3: Minimize explicit sharing of writable data)
Use 'ES.28: Use lambdas for complex initialization,
especially of const variables' to ensure we can see from the body
of the function that the function called in async only require const
parameter.
This ensure that if a non local change to the function signature
(making the const parameter non const) it will result in a compilation
error.
Added necessary construct and compiled with https://godbolt.org/g/tjGXbV
* Update CppCoreGuidelines.md
9 years ago
0de765443a
Merge pull request #974 from Talkless/patch-1
...
Fix if statement for checking error condition
9 years ago
898f819b00
Add [Abrahams01] bibliography entry for exception-safety ( #991 )
...
Link to it when talking about the strong and basic exception-safety
guarantees.
Add it to the dictionary.
9 years ago
45fff26517
Merge pull request #976 from willwray/patch-1
...
Fix Inconsistent definition of czstring in comments
9 years ago
7e7e1d8926
Move period outside parenthesis
9 years ago
cf223f3cb8
Merge pull request #992 from isocpp/broken-links
...
Replace broken links to #Rf-pass-ref-ref and #Rf-pass-ref-move
9 years ago
2a1472657f
Merge pull request #990 from isocpp/issue-989
...
Remove confusing "copy" in discussion of move ops
9 years ago
56df32bd95
Fix typo in C.8 ( #985 )
9 years ago
3924087459
Replace broken links to #Rf-pass-ref-ref and #Rf-pass-ref-move
9 years ago
3a6466f09c
Fix anchor links with double hash symbols
9 years ago
598e6f99b6
Fix cross-references to [C++03] and [C++CS]
...
Anchors should be #Cplusplus03 and #CplusplusCS not #C++03 and #C++CS.
9 years ago
498eb97dd2
Remove repetition of "as well"
...
Fixes #983
9 years ago
1143bfab79
Remove confusing "copy" in discussion of move ops
...
Fixes #989
9 years ago
bf7d7da165
updating date
9 years ago
e9b627f209
C.64 fixed typo ( #987 )
9 years ago
24b733f0b9
NL.17 fix typo
...
Fixes #982
9 years ago
d26dde2a4f
Fix Fibonacci sequence
...
A number sequence called `fib` should be the Fibonacci sequence or have a different name.
https://en.wikipedia.org/wiki/Fibonacci_number
9 years ago
f6ba91e90a
update date
9 years ago
5ffabce718
Fix Inconsistent definition of czstring in comments
...
Comments in sections SL.str.3 and GSL.view disagree on whether czstring may be the nullptr.
This PR fixes the first comment definition in SL.str.3 that czstring `is a C-style string that is not the nullptr`
### SL.str.3: Use zstring or czstring to refer to a C-style, zero-terminated, sequence of characters
```
void f1(zstring s); // s is a C-style string or the nullptr
void f1(czstring s); // s is a C-style string that is not the nullptr
```
### GSL.view: Views
`zstring` // a `char*` supposed to be a C-style string; that is, a zero-terminated sequence of `char` or `nullptr`
`czstring` // a `const char*` supposed to be a C-style string; that is, a zero-terminated sequence of const `char` or `nullptr`
9 years ago
0b1b5bbac8
Fix if statement for checking error condition
...
Example mentions that it handles error, and errors are commonly non-zero values.
Closes #970
9 years ago
66fc5d4f5c
Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines
9 years ago
7ba2317992
Updating date
9 years ago
a3860f3cc2
Merge pull request #971 from tkruse/style-fixes2
...
Style fixes for compile-time, run-time and similar
9 years ago
d13bfcda64
Consistent hyphenation of ajectives like lock-free, well-defined, old-style,...
9 years ago
015ee8df10
make 'non-' prefix spelling consistent
9 years ago
9159315d8c
make non-`const` spelling consistent
9 years ago
ba82be70bd
make 'side effect' vs. 'side-effect' spelling consistent
9 years ago
172520b570
make 'reuse' vs. 're-use' spelling consistent
9 years ago
d14067a5b4
make 'error-prone' usage consistent
9 years ago
9aa9e8fc9f
fix hyphenation of ...-allocated adcjectives
9 years ago
95b001c0d8
fix hyphenation of open-source
9 years ago
00f9e9ae50
fix bad hyphen for standard-library as adjective
9 years ago
d28a46983e
Fix missing comma
9 years ago
b4c1e30743
Make usage of run-time, compile-time, lifetime, real-time and hard-real-time consistent
9 years ago
f70ca3ee9e
Consistent formatting of interval ranges
9 years ago
69d2341c1e
Fixing edit fail
9 years ago
b3b329f937
Fixing up suggestions from Issues 505 and 496
9 years ago
2bd4a7c9ad
Fix Enforcement for C.151 after PR #952
9 years ago
8c0f764b77
Merge pull request #952 from tkruse/code-fixes
...
small issues found trying to compile examples
9 years ago
24fa6d4b00
Added break to each case in switch statement
9 years ago
b02eb91b84
code fixes
9 years ago
22c305fdee
travis fixes and a typo
9 years ago
70655d1131
Fix typos and change spellcheck call to not check URLs ( #961 )
9 years ago
e12e73e670
ES.34 Add alternative example.
9 years ago
03dc7d3f44
Updating date
9 years ago
9472111c6c
Talk materials list
...
Issue #929 .
It would be nice to have more material, and I haven't yet uploaded all
slides.
9 years ago
8cc76e2c38
Fix Enum.4 example
...
Issue #716
9 years ago
5393fab88f
labels missing
...
#938 . I have inserted a temporary fix. We need to re-work the whole
discussions section
9 years ago
5e2f9064b2
Merge pull request #927 from ZachHenkel/master
...
Additional guidance around casts:
9 years ago
19da9a1d03
Merge pull request #950 from cubbimew/pimpl
...
New rule: I.27 Pimpl
9 years ago
0048b15ead
fix mismatch between title and toc for F.22
9 years ago
5205a4e567
updating date
9 years ago
c0b1ea189f
Merge pull request #958 from xfix/patch-1
...
Rename rnd to round in I.1
9 years ago
18e8e91745
Merge pull request #957 from eliaskosunen/master
...
Add braces to for loop in P.1 example
9 years ago
ba3bdb1f40
Merge pull request #949 from robert-andrzejuk/patch-2
...
Minor typo (I think)
9 years ago
7367e07598
Rename rnd to round in I.1
...
At first, I assumed that this is "rand" function, not "round" function,
and was confused why exactly is it a problem that this returns
different values. While it's easy to notice when actually reading the
code, this slows down the comprehension, and bad function naming is
not point of that particular guideline.
9 years ago
7763b97b52
Add braces to for loop in P.1 example
...
`for` with no `block-statement` as its `statement` is bad practice and should not be shown in an example. This example is meant to demonstrate code duplication and expessiveness, not to show poor usage of braces or lack thereof.
9 years ago
6907911089
Updating date
9 years ago
d5667c5f8a
Minor typo
...
I think a minor typo got itself in ... the second 'string_span' should be string_view.
9 years ago
974d6a2090
Fix link to constructor virtual
9 years ago
d4d48ec772
Fix tense, semantic error
9 years ago
fe9861d98a
New rule: I.27 Pimpl
9 years ago
906ae347f3
travis CI fixes
9 years ago
c355df948f
reorganize the lifetime profile description
9 years ago
11e92eb4c5
Fix Markdown rendering failure
...
Use of <iostream> without backticks causes the Markdown render to fail
from this point onwards on GitHub pages.
9 years ago
f3ff5bae6d
Clarify "unnecessary cast" by decomposing the class into identity casts and implicit casts.
9 years ago
9cc50836bd
Diverse style fixes
...
Remove whitespace at end of line
fix code indent
whitepsace between operators
align comments
add method name to fix syntax highlighting
typo: start with capital letter
Apply snake-case naming for unctions (for consistency)
9 years ago
520087569f
Merge pull request #943 from galik/fix_unique_target_case
...
Fix case of unique anchors to match others
9 years ago
d240b7611e
`#include`d instead of `#included`
9 years ago
3c867e5079
Final style changes
9 years ago
2ef544d4ad
Additional formatting
9 years ago
abd71982da
Another try with the linter
9 years ago
ca35984813
Try to make the linter happy
9 years ago
c7733a398a
Updating date
9 years ago
7cf5f01bad
Fix case if unique anchors to match others
...
SL.str.5, SL.str.10, SL.str.11, SL.str.12
9 years ago
07d2413d80
Merge pull request #939 from galik/fix_item_tags
...
Fix various item tags (missing colons)
9 years ago
fa50221dd0
Fix various item tags (missing colons)
...
I.2, C.10, A.1, A.2, A.4, NL.5
9 years ago
9e29780db6
Merge pull request #937 from ProgramMax/add-missing-period
...
Add missing period
9 years ago
ea50b4ea78
Add missing period
9 years ago
d816cc5705
travis CI fixes
9 years ago
2cd9993ae4
Revise cast guidance following upstream edits
9 years ago
9ef1d51c34
Merge from https://github.com/isocpp/CppCoreGuidelines
9 years ago
6c3620d1e8
minor cleanup
9 years ago
4dfe88b716
Fix broken links ( #935 )
9 years ago
531a8a5ebd
travis CI fixes and other typos
9 years ago
5f5d5d8ca6
Fixing link to C.146 to be valid, and a link to ??? to be unlinked ( #934 )
...
this fixes links and the issues discovered by travis CI
9 years ago
5975f4d5db
more bounds profile reorganization
9 years ago
df160f3654
Most of the bounds safety profile
9 years ago
9eb18fdf9e
vector exception to {} initializers
9 years ago
9d44e718eb
Reorganized the Type safety profile
9 years ago
c721b2c325
Merge pull request #931 from sizeofvoid/master
...
fix: unsigned int value comment
9 years ago
5da51a9a44
more work on anchors
9 years ago
9d283bc451
anchors for Type.*
9 years ago
986106c63c
more Type.* reorganization
9 years ago
e2719d035b
Reorganize Type.1-3
9 years ago
6e86c182f9
Don't detach, rename raii_thread to joining_thread
...
Addressing #925 . Please review carefully. #925 is tricky.
9 years ago
96a41a4a6e
travis CI fixes
9 years ago
a1f59395bb
modifications to C.43
...
Issue #544
9 years ago
85cb14703c
travis CI fixes
9 years ago
aabfe119d3
typo fix
9 years ago
a591b3c279
fix: unsigned int value comment
9 years ago
14ef2cde84
add rules against use of unsigned
...
addresses #571
9 years ago
50576c0144
issue #841
...
SF.10: Avoid dependencies on implicitly `#included` names
9 years ago
974fdf4661
improve I.11
...
as suggested in #552
9 years ago
fa1d0e5995
exceptionsand const
...
Added to E.15
9 years ago
81493f331c
Undid untentional change to C.85
9 years ago
7206b618a4
C.86 example accesses private members #541
...
fixed
9 years ago
9620ea8d43
I.30: Encapsulate rule violations
...
Fiexed #893 by moving the bad example from ES.28 to a new rule: I.30:
Encapsulate rule violations.
I may inadvertenly have invented a new suppression syntax
9 years ago
17ccab5836
Fix C.139
9 years ago
b10ffdf55f
Reversed order of Lifetime.1 and .2
9 years ago
ff9bce8035
Add Lifetime.1-3 rules so tools can refer to them
9 years ago
f1b348e0db
Additional guidance around casts:
...
- Warn on unnecessary casts
- Avoid casts on arithmetic types
- Add specializations of the rules for Pro-type-reinterpretcast
9 years ago
17715010a2
travis CI fixes and grammar fix from #920
9 years ago
b09b9ad8b9
Updating date & typos
9 years ago
bec67d690a
Merge pull request #914 from AndrewPardoe/issue911
...
Clarify I.11 with regards to recommending smart pointers/owner<T>.
9 years ago
52eca9a174
Merge pull request #917 from scraimer/master
...
C.148 adding Reason and Example
9 years ago
2e1d9c34d4
Merge pull request #920 from cubbimew/issue899
...
CP.111 more precise motivation and examples
9 years ago
d5ea1fcc4f
Merge pull request #922 from AndrewPardoe/issue-918
...
Fix anchors in C.147/148
9 years ago
52aa9ba997
Fix #903 .
9 years ago
e354279e0e
Fix anchors in C.147/148
9 years ago
ad6f863152
Added not about notation to Con.2
...
in response to #902
9 years ago
f41d36ff25
CP.111 more precise motivation and examples
9 years ago
7c90bdba50
Intended heading level?
...
Following the heading levels throughout the doc, it seems these are typos.
9 years ago
12f0954f66
Fixed the errors detected by Travis CI and @jwakely
9 years ago
cdf2e7e5ea
Fixed the errors detected by Travis CI and @jwakely
9 years ago
bdb5d27a10
Remove spaces before ptr-declarators in examples
9 years ago
1c53b29a3a
C.148 - Fixing Travis-reported errors discovered so far in the code example
9 years ago
b6132db539
C.148 adding Reason and Example
9 years ago
343f40792a
Clarify I.11 with regards to recommending smart pointers/owner<T>.
9 years ago
f0239407ad
travis fixes
9 years ago
03c2b4699d
Updating date
9 years ago
32d6313607
Improve example for ES.45
...
Fixes #895
9 years ago
a96fed9c99
Merge pull request #896 from tlanc007/master
...
ES.45/ES.46 renamed and reordered to match anchors found later in file
9 years ago
0ff5518dca
Merge pull request #905 from ewoudvc/es24_toc_rule_correction
...
ES.24: have TOC rule match body rule
9 years ago
b41bea68c1
Merge pull request #909 from tvaneerd/patch-2
...
Note -> Not, are -> is
9 years ago
f9f3422ac5
Fix C.183.
9 years ago
918a5695c7
Address C.128: say 'avoid'.
9 years ago
481996c849
Note -> Not, are -> is
9 years ago
e0de4df83b
added clarifying note for C.139
9 years ago
b3584cfa5f
added reference to C.137
9 years ago
a6a087dfc5
regular added to glossary
9 years ago
64622d5cca
testing
...
and fixing one "thinko"
9 years ago
caa86ae38b
GSL.assert: replace is by are ( #908 )
9 years ago
e3fe0c5b5e
Fix indentation of NR.1 example
9 years ago
10805fb7a1
ES.24: have TOC rule match body rule
9 years ago
94a7a3fd46
travis CI fixes, one more time
9 years ago
046d62c51e
minor improvements to SL.io
9 years ago
c99a366bba
travis CI fixes
9 years ago
4f9a6c89be
banning exception specifications
...
a bit more abut exceptions; the beginnings of I/O
9 years ago
1e38eb8ae7
ban longjmp
9 years ago
5397c9c5fe
very minor typo
...
testing
9 years ago
1b7d217cd1
nothing
9 years ago
5306795214
ES.45/ES.46: renamed and reordered to match jump tags
...
The anchors later in the file were using 46 for narrowing and 45 for
magic. Renamed and reordered the tags in the TOC to match.
9 years ago
2a098a2b39
travis CI fixes
9 years ago
df8a441dcf
fix bug in C.9 example
...
a real-world example would be an improvement
9 years ago
d1ff56d07e
date
9 years ago
cfa2fec1f2
C.137
9 years ago
6987bfd2f0
C.9 and C.133
9 years ago
05118054f6
NL.11 literals
9 years ago
e30bb60320
more xrefs
9 years ago
540c393501
Merge pull request #892 from lbrandy/master
...
Example of an inheritance hierarchy for C.120.
9 years ago
04537cdb11
travis CI fixes
9 years ago
74ab713700
travis CI and some typo fixes
...
had to drop runtime/printf from the checks because it bans strcpy
9 years ago
54f57d8d1b
more language feature xrefs
...
These xrefs are menat part as teasers to get language-feature obsessed
programmers to look at the guidelines and partly to cover topics that
appears in several places. They are not meant to be complete
9 years ago
6fa4cb32cd
more language feature xrefs
9 years ago
e144bd4f9b
minor
9 years ago
29fdd0d30c
Attempt to add an example (that is as non-controversial as possible) of an inheritance hierarchy to C.120
9 years ago
f1d3846300
updating date
9 years ago
0ff543fe19
Addresses #568
9 years ago
323912e609
A pass at improving F.52. Closes #884
9 years ago
6d01cfd99b
more language term examples
9 years ago
Jonathan Wakely
Breno Rodrigues Guimaraes
hsutter
Andrew Pardoe
Andrew Pardoe
Leonardo Perez Pulido
Florian Behrens
Oleg Artenii
Thomas Schaub
Eliyahu Ravuna
Mohit Jain
Martin Finke
Jonas Toth
Jonathan Wakely
Jay Bazuzi
Yogendra Singh
chili
luav
Seulgi Kim
Tom Isaacson
Franz Hollerer
Artem Golubikhin
Bjarne Stroustrup
Neil MacIntosh
Gabriel Dos Reis
Gabriel Dos Reis
Sebastian Valle
tg-m
Ivan Baidakou
Marzo Sette Torres Junior
Cleroth
TalLancaster
Björn Schäpers
Ben
Benoît Blanchon
Jonathan Bohren
jeanphilippeD
Abigail
michaelz85
Felix Kälberer
Will Wray
Vincas Dargis
Thibault Kruse
Rory Jaffe
Sergey Zubkov
Thibault Kruse
Jacob Taylor Hindle
Konrad Borowski
Elias Kosunen
Robert Andrzejuk
Florin
Zachary Henkel
Bledson Kivy
galik
Chris Blume
Malcolm Parsons
Shalom Craimer
Rafael Sadowski
Shalom Craimer
Tony Van Eerd
ewoudvc
Louis Brandy
Louis Brandy