dd683abae7
Fix typographical error (variable name) in example for C.30.
10 years ago
935a5ee325
Closed #485 .
10 years ago
e4f908093d
Closed #484 .
10 years ago
2d9c0582ad
Another minor grammar fix.
10 years ago
7ae316c605
Minor grammar fix.
10 years ago
6a39167b86
Declaring one name per declaration.
10 years ago
d653d5e89c
(Hopefully) editorial cleanup for Sec ES.
10 years ago
46f38a7917
Closed #388 .
10 years ago
2bea1b9d30
Closed #442 .
10 years ago
8758eabcbf
Folded duplicate C.6 into Con.2 and addressed PR #438 .
10 years ago
7cd72691e8
Improved R.3 note wording to help address PR #417 .
10 years ago
13c8df9abc
Applied suggestion in PR #414 .
10 years ago
41751f548c
Merge pull request #409 from agrygorenko/F-27-patch
...
F.27: Example fix
10 years ago
47a1405707
Applied suggestion in PR #343 .
10 years ago
f013c1b22d
Applied suggestion in PR #298 .
10 years ago
3586cf7d0e
Applied suggestion in PR #273 .
10 years ago
6c47693b58
Applied suggestion in PR #268 .
10 years ago
50e89327bb
Applied the suggestion in PR #238 .
10 years ago
12dd788e1d
Applied suggestion in PR #213 .
10 years ago
4b15a57f96
Applied the suggestion in PR #198 .
10 years ago
10d1d9dbc5
Addressed PR #140 .
10 years ago
c9e015ce1f
Addressed PR 52.
10 years ago
9c2aba298c
Closed #436 .
10 years ago
c6891262a7
Tweaked PR #481 .
10 years ago
3f99f673d4
Wording in Intro and Philosophy
10 years ago
9b9a71bf18
Merge pull request #439 from mpark/P1
...
P.1: Minor fixes to the examples.
10 years ago
7d99f7605a
Closed #478 .
10 years ago
238ffceb62
Closed #477.'
10 years ago
dc5cb14536
Closed #294 .
10 years ago
2d8377aab5
Closes #133 .
10 years ago
a26d6c98d5
P.1: Fixed incorrect use of `std::find`.
10 years ago
3b29134985
P.1: The index result of a `std::find`-like loop needs to be initialized to -1.
10 years ago
21b28d91ef
Merge pull request #465 from tituswinters/f.6
...
Clarify f.6 note on noexcept and allocation
10 years ago
d5cbcd23ec
Merge pull request #472 from Alexolut/patch-7
...
fixed typos
10 years ago
a1f7cdfc6e
Merge pull request #473 from mpark/C.61
...
C.61: Fixed example to use `new[]` instead to allocate an array.
10 years ago
3f51ca23fa
typos s/insigth/insight s/reders/readers s/psource/source
10 years ago
c07d9189d7
C.167: Use an operator for an operation with its conventional meaning
...
issue #290
10 years ago
b1c907387f
ES.65 Don't slice
10 years ago
afdaa1d110
Closed #437 .
10 years ago
f0e29f0492
Closed #423 .
10 years ago
9e0b9f435e
Closes #189 .
10 years ago
9c93ba6c5f
Closed #108 .
10 years ago
6156e95782
Closed #83 .
10 years ago
d78a1b81a0
C.61: Fixed example to use `new[]` instead to allocate an array.
10 years ago
26fc14cc8a
operator&
...
C.166 Overload unary `&` only as part of a system of smart pointers and
references
10 years ago
a6051b2058
fixed typos
10 years ago
fac322ee67
Merge pull request #471 from mpark/C.40
...
C.40: Fixed a couple of typos.
10 years ago
8916eddfa5
C.40: Fixed a couple of typos.
10 years ago
d423e855b5
C.ctor: Fixed typo.
10 years ago
b1f33a48a2
Merge pull request #469 from mpark/C.37
...
C.37: Added a note about implicit declaration of `noexcept` for destructors
10 years ago
f90b15dd7a
C.37: Added a note about implicit declaration of `noexcept` for destructors.
10 years ago
5f7432b131
C.36: Fixed a couple of typos.
10 years ago
26e006b148
Section C.over was marked as a chapter.
...
The chapter on templates T was also abbreviated as TPG and TCP.
Anchor names corrected.
Rule T.26 was designated as T.27.
Missing ) added.
added missing references
The rules T.12 and T.13 were designated as T.14 and T.15 in the summary.
10 years ago
d1abdd220c
C.30: Fixed a typo in the example.
10 years ago
023d60ce8b
Merge pull request #463 from tituswinters/f.4
...
Don't mix future runtime customization constexpr.
10 years ago
3918d16274
Revise according to GDRs suggestion in PR 463.
10 years ago
6de4da0793
Clarify f.6 note on noexcept and allocation
...
The bigger picture issue of "What context is your code executing in?"
and "What type of code are the core guidelines addressing?" should be
handled separately with text in the overview.
10 years ago
fea884184e
Blend new F.47 into existing text.
10 years ago
7615d3076d
Add F.47 - Assignment operators return T&
...
As discussed in
https://github.com/isocpp/CppCoreGuidelines/issues/422
10 years ago
60706af58d
Don't mix future runtime customization constexpr.
...
As discussed in https://github.com/isocpp/CppCoreGuidelines/issues/420
10 years ago
b831fedb4a
fixed typos
10 years ago
ef18df66e8
Update TOC in In.sec
10 years ago
0198926d53
Addressed issue #134
10 years ago
67f8609657
Merge pull request #458 from tkruse/fix-toc2
...
Fix item order in second Table of contents
10 years ago
c0a4d1a087
changed dot operator to arrow.
10 years ago
24df4ed549
Fix item order in second Table of contents
10 years ago
1356a6d046
Fixed a comment that looks like a Liquid tag
10 years ago
73915ab827
Update date
10 years ago
d33cfd97dd
Merge PR 425
10 years ago
ba6c91c8fc
Swapped the order between `F.50` and `F.46`.
10 years ago
b43ff9b63c
Merge pull request #453 from mpark/tabs
...
Removed tabs as specified in `CONTRIBUTING.md`
10 years ago
b4260e6fa9
Fix data member names
...
Rename `fx` to `x`, `fy` to `y`, `fz` to `z`, and `fe` to `e` to match
names used in the narative and other member function.
Fix pull request #456 .
10 years ago
782e070fcd
Merge pull request #451 from mpark/F.21
...
F.21: Fixed order of arguments to `make_tuple`.
10 years ago
e7833ab1fe
Merge pull request #450 from mpark/F.19
...
F.19: `s/T&&/TP&&/`
10 years ago
893d11e6f5
Fixed F.16 references to -consume
...
This replaces PR #452
10 years ago
72143e71ab
Merge pull request #454 from mpark/F.27
...
F.27: Fixed typo `s/treads/threads/` in example.
10 years ago
2107d2852e
Revert "Add header for gh-pages rendering"
...
This reverts commit 294b2495f1
10 years ago
294b2495f1
Add header for gh-pages rendering
10 years ago
642cec4555
F.27: Fixed typo `s/treads/threads/` in example.
10 years ago
704f6cc339
Add reference to s-const in index
10 years ago
06348247d9
Align comments that were aligned by tabs.
10 years ago
1a850815d3
Replaced all tab characters with 4 spaces.
10 years ago
9b61e8e324
F.21: Fixed order of arguments to `make_tuple`.
10 years ago
33e24fb389
F.19: `s/T&&/TP&&/`
10 years ago
b873f02285
Merge pull request #406 from Alexolut/patch-3
...
added spaces around operators.
10 years ago
e28faccbf3
Merge pull request #426 from ascherer/fix-const-ness
...
Fix `const`-ness consistency.
10 years ago
e1800948cb
Merge pull request #432 from pmalek/master
...
Small typo
10 years ago
e93771fdd4
Merge pull request #435 from Alexolut/patch-4
...
Fixed typos, made names consistent.
10 years ago
e7756aa5f2
Merge pull request #441 from mpark/P3
...
P.3: Fixed an inaccurate description of `for (const auto& x : v)`.
10 years ago
9955c0702f
Merge pull request #448 from mpark/rule
...
Consistently replaced `Rule S.N` with a more widely used `S.N`.
10 years ago
d314de001b
[fix] typo
10 years ago
1a2609391b
Merge pull request #447 from mpark/F.4
...
F.4: Fixed a trivial style issue.
10 years ago
4de7d427c2
Consistently replaced `Rule S.N` with a more widely used `S.N`.
10 years ago
3c33b1f925
F.4: Fixed a trivial style issue.
10 years ago
e1d61e4655
I.25: Marked `center` and `draw` as `const`.
10 years ago
6e39add6a6
P.3: Fixed an inaccurate description of `for (const auto& x : v)`.
10 years ago
ccacbd6d54
Closes #440
10 years ago
b8b88bf4ec
NL.5: Fixed typo `s/typename/template/`.
10 years ago
b4a0bd4310
Update date
10 years ago
58eef51608
Fixed typos, made names consistent.
10 years ago
f07be3e8fb
Fixed typo in T.81 - issue #434
10 years ago
08b9149086
Fix `const`-ness consistency.
...
The majority of `const`-ness have the code-word joined with a hyphen to
its 'ness'. Make two slightly different versions consistent with this.
10 years ago
bc3d47768a
typs: s/literated/littered s/likelyhood/likelihood
10 years ago
729db042f1
clarification of F.42
10 years ago
518304ed63
ES.33: another warning against macros
10 years ago
7c68566196
Small typo
10 years ago
a013348a7e
Calling delete on a FILE* created with fopen is ill-advised. Uses a
...
custom deleter.
10 years ago
ed59160a47
Merge pull request #430 from ascherer/fix-note-on-ranges
...
Fix note on ranges.
10 years ago
e7f76036f2
Merge pull request #429 from ascherer/consistent-enforcement
...
Consistent Enforcement paragraphs.
10 years ago
ef03d8b700
Merge pull request #428 from ascherer/typeset-NaN
...
Consistent formatting of 'NaN'.
10 years ago
9ca047b49e
Fix note on ranges.
10 years ago
37071453cb
Consistent Enforcement paragraphs.
10 years ago
5067b9789a
Consistent formatting of 'NaN'.
10 years ago
10aea497d7
Validate rendered HTML.
...
Replace 'illegal' characters in `<a>`nchors with more neutral items.
The Markdown code is put through `pandoc -s --smart ...`
and the resulting HTML is positively tested by the
[W3C validator](https://validator.w3.org/#validate_by_upload ).
10 years ago
87e3e47da7
Slightly better text for previous commit
10 years ago
3fa4b5623b
Added xref to Rf-out per issue #390
10 years ago
936d321266
Extended Type.8 enforcement per issue #348
10 years ago
b16ef02365
Extended Sd-factory example per issue #310
10 years ago
7e81a238e0
Updated Bounds.4 as suggested in issue #267
10 years ago
d81adf4a8e
Added guidance to make function objects cheap to copy and pass by value
10 years ago
fe7a9dfe48
Expanded F.19 enforcement to forward exactly once (issue 128)
10 years ago
247be64de6
Fixed invoke() example to not forward the functor, to reflect other discussion
10 years ago
ac773e44d4
Updated R.3 to refer to #Rf-out
10 years ago
ceaddf311e
Added comments to P.6 to address Issue 9
10 years ago
866df49181
Manually merged PR 145 for C.150 improvement
10 years ago
19ee5fc18f
Added suppression syntax note
10 years ago
ec9065bdfb
Updated C.134 to call out const and add more rationale (issue 302)
10 years ago
fbd4acd526
Added enforcement to not move from & parameters (issue 316)
10 years ago
c101fc7ac4
Updated C.35 to address Issue 375
10 years ago
4a9e41d766
Added smartptrconcepts as link to Lifetime paper (Issue 407)
10 years ago
49afa391e5
Added F.18 body and clarification from issue 398
10 years ago
41eb8f28e7
Identifiers in enum class can overlap.
...
Reverting Capitalization of Red/Purple/Blue in enum class example.
10 years ago
6228e99a51
Separated F.15 into F.15-21: in, inout, consume, forward, out, multi-out
10 years ago
08b83eaea0
Renumbered F.16-19 -> F.22-25
...
For better topical grouping and to make room to break up F.15 into
smaller items
10 years ago
1922e46ac7
Merged F.40 into F.15 (issue #1
10 years ago
9e7bd3d4c4
Merged F.25 into F.15 (issue #1 )
10 years ago
89bf79e00c
Merged F.24 into F.15 (issue #1 )
10 years ago
7d3ff3c0b1
Merged F.23 into F.15 (issue #1 )
10 years ago
59eacc8aad
Merged F.22 into F.15 (issue #1 )
10 years ago
7fb7db3f0d
Merged F.21 into F.15 (issue #1 )
10 years ago
65dc9e9c37
Merged F.20 into F.15 (issue #1 )
10 years ago
5990abead1
F.27: Example fix
...
It is usually a bad idea to share mutable objects between threads, which leads to a race condition or unnecessary thread contention.,
10 years ago
282a11de26
The vector was missing template arguments. Fixed
...
Thank you for the feedback in #402 .
char replaced with uint8_t.
10 years ago
76824f8d1d
added spaces around operators.
10 years ago
e238597f6c
fixed a typos because of zero-based indexing
...
Another misunderstanding: how container can be modified (side-effect in a call of `f(&v[i])` ) if we passing only an address to element, not a address to container?
10 years ago
66ca2b5f6a
Fix grammar in I.22
10 years ago
ac40133baa
fix typos
10 years ago
f211ce714c
Fix grammar in Appendix C...
...
Discussion: Make base class destructors public and virtual, or protected and nonvirtual
10 years ago
dda7a868b1
Suggested example for PER.4
10 years ago
4abbd0618f
Improved F.41
...
Added potential C++17 example based on EWG direction in Kona
10 years ago
de57702fdd
Merge pull request #386 from RicoAntonioFelix/master
...
Correction of minor errors...
10 years ago
3140dde428
Added missing capture clause in lambda expression and missing variable name from declaration of file object...
10 years ago
bbbb922dd0
Merge pull request #389 from darrnshn/master
...
Minor fixes to NL.8
10 years ago
0330fcb265
Merge pull request #394 from tituswinters/p.7
...
Don't ruin the complexity of your interface with checking.
10 years ago
549da18a72
Update CppCoreGuidelines.md
...
Typo in the clarification. Don't ruin the complexity of your thing with added checks. :)
10 years ago
2bd1f7a94d
Fix the "enum class" example (which was backwards and broken).
10 years ago
937488887f
Don't ruin the complexity of your interface with checking.
10 years ago
fe811ed63a
Merge pull request #393 from tituswinters/p.2
...
Add a little to the "Don't use non-standard extensions discussion."
10 years ago
b3e6c82ade
Add a little to the "Don't use non-standard extensions discussion."
10 years ago
21815d7ba0
Changes that seem editorial or (hopefully) non-controversial.
10 years ago
63e5e23e2c
Fix NL.8 typo
10 years ago
ca22f65232
Merge pull request #387 from darrnshn/master
...
Fix minor formatting issues
10 years ago
cc3ffb50af
Merge pull request #385 from timp3289/patch-1
...
Fixed typo
10 years ago
92458af3fa
Fix minor formatting
10 years ago
31016ad113
Fixed typo
10 years ago
f13a89539e
Fix F.16 (Use T* or owner<T*> to designate a single object) to use consistent variable name in the example provided.
10 years ago
f0091dbc56
typo: s/preformance/performance
10 years ago
5bb3b3f732
Updated description of *_view to reference span.
10 years ago
af48243d0a
Updated FAQ entry about string_span/string_view.
10 years ago
0a9cdd34b6
Grammar fixes after span rename.
10 years ago
0eaee02da9
Rename: array_view=>span, string_view=>string_span.
10 years ago
7df274bcbe
etc
...
just a few of my assignments; I'll get better at keeping track
10 years ago
98dd36e921
Merge pull request #369 from villasv/master
...
C.43: rewording and examples suggested in #344
10 years ago
ebd3a33d1d
C.43: rewording and examples suggested in #344
10 years ago
1dc02e15a7
Enforcement rule for I.3: Avoid singletons
...
Proposal revised as agreed in #266 .
10 years ago
8275f69ce3
Merge pull request #327 from ulilaube/fixcrossref
...
Fixcrossref
10 years ago
3e2aec11bf
Merge pull request #372 from wwalexander/patch-1
...
Fix misplaced end parenthesis in NL.17.Reason
10 years ago
ee793dfb38
Merge pull request #371 from drusk/es31_typos
...
Fixed some typos in section ES.31.
10 years ago
57b16ed800
Fix misplaced end parenthesis in NL.17.Reason
10 years ago
31d4985179
Fixed some typos in section ES.31.
10 years ago
d3dd1c683b
capitalize "resource acquisition is initialization"
10 years ago
6029fc813d
Replacing problematic code example in ES.41
10 years ago
bf306f81cb
Rules T.11 and T.124 used the same cross reference anchor Rt-std.
...
Rules SF.1 and SF.2 used the same cross reference anchor Rs-suffix.
There is no rule F.54 with anchor Rf-local-ref-ref (yet?). Broken reference removed.
Sections TPG.concepts and GSL.concepts used the same anchor SS-concepts.
Section C.ctor and its own subsection C.ctor.ctor used the same anchor SS-ctor.
10 years ago
792b831e7a
Merge pull request #341 from ascherer/fix-typos
...
Fix typos
10 years ago
a4b400e9eb
Merge pull request #349 from alrekr/master
...
Typo
10 years ago
2c72daaab7
Merge pull request #358 from khatharr/master
...
A few spelling and grammar fixes R.22 and ES.23
10 years ago
42bbbf6a2d
ES.23: two corrected typos in code example
10 years ago
d0ac3dc3bc
A few spelling and grammar fixes R.22 and ES.23
10 years ago
6d992f9b79
Typo
10 years ago
302b9848d4
Fix errors in Resource section.
10 years ago
ff623adc6b
Mismatching and missing quotes.
...
And other problems fixed.
10 years ago
4c55ed4662
Errors in enum section.
10 years ago
31ce56e75f
Three more bugs fixed.
10 years ago
545c7c40e3
Correct multiple problems in related sentences.
10 years ago
3e8dc12982
Several typos fixed.
...
Missing or superfluous characters corrected.
Rewording to avoid "problems requires tools".
...
10 years ago
69405d3d15
Remove in-text C++ comment sign.
10 years ago
7c25281c38
Fix singular/plural mismatches.
...
Either the rules eliminate, or the rule eliminates.
Multiple 'Date' classes have default dates.
...
10 years ago
6571ede5e7
Invert single occurrence of closing brace after comma.
10 years ago
41f1c30d1c
Add missing closing brace.
10 years ago
8221bd9016
Fix missing backticks for std-code.
10 years ago
Jeremy Voorhis
hsutter
Dima
Titus Winters
Andrew Pardoe
Gabriel Dos Reis
Michael Park
Sergey Zubkov
Bjarne Stroustrup
Alexolut
uli
Andrew Pardoe
Thibault Kruse
Gabriel Dos Reis
unknown
Kristoffel Pirard
Andreas Scherer
Patryk Małek
Rob Adams
Andriy Grygorenko
Eliyahu Ravuna
Matthias Kluwe
Jordan Harris
RicoAntonioFelix
Darren Shen
timp3289
Richard Holmes
Neil MacIntosh
Victor Villas
Will Alexander
drusk
Brett
Kalman Keri
Khatharr
Malthe Høj-Sunesen