how-to
/
CppCoreGuidelines
mirror of https://github.com/isocpp/CppCoreGuidelines.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
1,440 Commits
14 Branches
4 Tags
184 MiB
master
gh-pages
2170-hs
concrete-terminology
cast-to-void-cleanup
string_span-excision
For-1446
es23-updates
neilmacintosh-ES70-fix
hs-index
travis-errors
t84-example
revert-825-interfaces_non_trivial_fixes
H1
v0.7
v0.6
v0.1
v0.8
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'travis-errors'
${ noResults }
Commit Graph

1152 Commits (travis-errors)

Author SHA1 Message Date
michaelz85 e9b627f209 C.64 fixed typo (#987) 9 years ago
Jonathan Wakely 24b733f0b9 NL.17 fix typo 
Fixes #982
 9 years ago
Felix Kälberer d26dde2a4f Fix Fibonacci sequence 
A number sequence called `fib` should be the Fibonacci sequence or have a different name.

https://en.wikipedia.org/wiki/Fibonacci_number
 9 years ago
Andrew Pardoe f6ba91e90a update date 9 years ago
Will Wray 5ffabce718 Fix Inconsistent definition of czstring in comments 
Comments in sections  SL.str.3 and GSL.view disagree on whether czstring may be the nullptr.

This PR fixes the first comment definition in SL.str.3 that czstring `is a C-style string that is not the nullptr`

### SL.str.3: Use zstring or czstring to refer to a C-style, zero-terminated, sequence of characters
```
void f1(zstring s);     // s is a C-style string or the nullptr
void f1(czstring s);    // s is a C-style string that is not the nullptr
```
### GSL.view: Views
`zstring` // a `char*` supposed to be a C-style string; that is, a zero-terminated sequence of `char` or `nullptr`
`czstring` // a `const char*` supposed to be a C-style string; that is, a zero-terminated sequence of const `char` or `nullptr`
 9 years ago
Vincas Dargis 0b1b5bbac8 Fix if statement for checking error condition 
Example mentions that it handles error, and errors are commonly non-zero values.

Closes #970
 9 years ago
Andrew Pardoe 66fc5d4f5c Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines 9 years ago
Andrew Pardoe 7ba2317992 Updating date 9 years ago
Andrew Pardoe a3860f3cc2 Merge pull request #971 from tkruse/style-fixes2 
Style fixes for compile-time, run-time and similar
 9 years ago
Thibault Kruse d13bfcda64 Consistent hyphenation of ajectives like lock-free, well-defined, old-style,... 9 years ago
Thibault Kruse 015ee8df10 make 'non-' prefix spelling consistent 9 years ago
Thibault Kruse 9159315d8c make non-`const` spelling consistent 9 years ago
Thibault Kruse ba82be70bd make 'side effect' vs. 'side-effect' spelling consistent 9 years ago
Thibault Kruse 172520b570 make 'reuse' vs. 're-use' spelling consistent 9 years ago
Thibault Kruse d14067a5b4 make 'error-prone' usage consistent 9 years ago
Thibault Kruse 9aa9e8fc9f fix hyphenation of ...-allocated adcjectives 9 years ago
Thibault Kruse 95b001c0d8 fix hyphenation of open-source 9 years ago
Thibault Kruse 00f9e9ae50 fix bad hyphen for standard-library as adjective 9 years ago
Thibault Kruse d28a46983e Fix missing comma 9 years ago
Thibault Kruse b4c1e30743 Make usage of run-time, compile-time, lifetime, real-time and hard-real-time consistent 9 years ago
Thibault Kruse f70ca3ee9e Consistent formatting of interval ranges 9 years ago
Andrew Pardoe 69d2341c1e Fixing edit fail 9 years ago
Andrew Pardoe b3b329f937 Fixing up suggestions from Issues 505 and 496 9 years ago
Andrew Pardoe 2bd4a7c9ad Fix Enforcement for C.151 after PR #952 9 years ago
Andrew Pardoe 8c0f764b77 Merge pull request #952 from tkruse/code-fixes 
small issues found trying to compile examples
 9 years ago
Rory Jaffe 24fa6d4b00 Added break to each case in switch statement 9 years ago
Thibault Kruse b02eb91b84 code fixes 9 years ago
Sergey Zubkov 22c305fdee travis fixes and a typo 9 years ago
Thibault Kruse 70655d1131 Fix typos and change spellcheck call to not check URLs (#961) 9 years ago
Jacob Taylor Hindle e12e73e670 ES.34 Add alternative example. 9 years ago
Andrew Pardoe 03dc7d3f44 Updating date 9 years ago
Bjarne Stroustrup 9472111c6c Talk materials list 
Issue #929.
It would be nice to have more material, and I haven't yet uploaded all
slides.
 9 years ago
Bjarne Stroustrup 8cc76e2c38 Fix Enum.4 example 
Issue #716
 9 years ago
Bjarne Stroustrup 5393fab88f labels missing 
#938. I have inserted a temporary fix. We need to re-work the whole
discussions section
 9 years ago
Andrew Pardoe 5e2f9064b2 Merge pull request #927 from ZachHenkel/master 
Additional guidance around casts:
 9 years ago
Andrew Pardoe 19da9a1d03 Merge pull request #950 from cubbimew/pimpl 
New rule: I.27 Pimpl
 9 years ago
Sergey Zubkov 0048b15ead fix mismatch between title and toc for F.22 9 years ago
Andrew Pardoe 5205a4e567 updating date 9 years ago
Andrew Pardoe c0b1ea189f Merge pull request #958 from xfix/patch-1 
Rename rnd to round in I.1
 9 years ago
Andrew Pardoe 18e8e91745 Merge pull request #957 from eliaskosunen/master 
Add braces to for loop in P.1 example
 9 years ago
Andrew Pardoe ba3bdb1f40 Merge pull request #949 from robert-andrzejuk/patch-2 
Minor typo (I think)
 9 years ago
Konrad Borowski 7367e07598 Rename rnd to round in I.1 
At first, I assumed that this is "rand" function, not "round" function,
and was confused why exactly is it a problem that this returns
different values. While it's easy to notice when actually reading the
code, this slows down the comprehension, and bad function naming is
not point of that particular guideline.
 9 years ago
Elias Kosunen 7763b97b52 Add braces to for loop in P.1 example 
`for` with no `block-statement` as its `statement` is bad practice and should not be shown in an example. This example is meant to demonstrate code duplication and expessiveness, not to show poor usage of braces or lack thereof.
 9 years ago
Andrew Pardoe 6907911089 Updating date 9 years ago
Robert Andrzejuk d5667c5f8a Minor typo 
I think a minor typo got itself in ... the second 'string_span' should be string_view.
 9 years ago
Tom Isaacson 974d6a2090 Fix link to constructor virtual 9 years ago
Florin d4d48ec772 Fix tense, semantic error 9 years ago
Sergey Zubkov fe9861d98a New rule: I.27 Pimpl 9 years ago
Sergey Zubkov 906ae347f3 travis CI fixes 9 years ago
Bjarne Stroustrup c355df948f reorganize the lifetime profile description 9 years ago
Abigail 11e92eb4c5 Fix Markdown rendering failure 
Use of <iostream> without backticks causes the Markdown render to fail
from this point onwards on GitHub pages.
 9 years ago
Zachary Henkel f3ff5bae6d Clarify "unnecessary cast" by decomposing the class into identity casts and implicit casts. 9 years ago
Thibault Kruse 9cc50836bd Diverse style fixes 
Remove whitespace at end of line

fix code indent

whitepsace between operators

align comments

add method name to fix syntax highlighting

typo: start with capital letter

Apply snake-case naming for unctions (for consistency)
 9 years ago
Gabriel Dos Reis 520087569f Merge pull request #943 from galik/fix_unique_target_case 
Fix case of unique anchors to match others
 9 years ago
Bledson Kivy d240b7611e `#include`d instead of `#included` 9 years ago
Zachary Henkel 3c867e5079 Final style changes 9 years ago
Zachary Henkel 2ef544d4ad Additional formatting 9 years ago
Zachary Henkel abd71982da Another try with the linter 9 years ago
Zachary Henkel ca35984813 Try to make the linter happy 9 years ago
Andrew Pardoe c7733a398a Updating date 9 years ago
galik 7cf5f01bad Fix case if unique anchors to match others 
SL.str.5, SL.str.10, SL.str.11, SL.str.12
 9 years ago
Gabriel Dos Reis 07d2413d80 Merge pull request #939 from galik/fix_item_tags 
Fix various item tags (missing colons)
 9 years ago
galik fa50221dd0 Fix various item tags (missing colons) 
I.2, C.10, A.1, A.2, A.4, NL.5
 9 years ago
Gabriel Dos Reis 9e29780db6 Merge pull request #937 from ProgramMax/add-missing-period 
Add missing period
 9 years ago
Chris Blume ea50b4ea78 Add missing period 9 years ago
Sergey Zubkov d816cc5705 travis CI fixes 9 years ago
Zachary Henkel 2cd9993ae4 Revise cast guidance following upstream edits 9 years ago
Zachary Henkel 9ef1d51c34 Merge from https://github.com/isocpp/CppCoreGuidelines 9 years ago
Bjarne Stroustrup 6c3620d1e8 minor cleanup 9 years ago
Malcolm Parsons 4dfe88b716 Fix broken links (#935) 9 years ago
Sergey Zubkov 531a8a5ebd travis CI fixes and other typos 9 years ago
Shalom Craimer 5f5d5d8ca6 Fixing link to C.146 to be valid, and a link to ??? to be unlinked (#934) 
this fixes links and the issues discovered by travis CI
 9 years ago
Bjarne Stroustrup 5975f4d5db more bounds profile reorganization 9 years ago
Bjarne Stroustrup df160f3654 Most of the bounds safety profile 9 years ago
Bjarne Stroustrup 9eb18fdf9e vector exception to {} initializers 9 years ago
Bjarne Stroustrup 9d44e718eb Reorganized the Type safety profile 9 years ago
Andrew Pardoe c721b2c325 Merge pull request #931 from sizeofvoid/master 
fix: unsigned int value comment
 9 years ago
Bjarne Stroustrup 5da51a9a44 more work on anchors 9 years ago
Bjarne Stroustrup 9d283bc451 anchors for Type.* 9 years ago
Bjarne Stroustrup 986106c63c more Type.* reorganization 9 years ago
Bjarne Stroustrup e2719d035b Reorganize Type.1-3 9 years ago
Bjarne Stroustrup 6e86c182f9 Don't detach, rename raii_thread to joining_thread 
Addressing #925 . Please review carefully. #925 is tricky.
 9 years ago
Sergey Zubkov 96a41a4a6e travis CI fixes 9 years ago
Bjarne Stroustrup a1f59395bb modifications to C.43 
Issue #544
 9 years ago
Sergey Zubkov 85cb14703c travis CI fixes 9 years ago
Bjarne Stroustrup aabfe119d3 typo fix 9 years ago
Rafael Sadowski a591b3c279 fix: unsigned int value comment 9 years ago
Bjarne Stroustrup 14ef2cde84 add rules against use of unsigned 
addresses #571
 9 years ago
Bjarne Stroustrup 50576c0144 issue #841 
SF.10: Avoid dependencies on implicitly `#included` names
 9 years ago
Bjarne Stroustrup 974fdf4661 improve I.11 
as suggested in #552
 9 years ago
Bjarne Stroustrup fa1d0e5995 exceptionsand const 
Added to E.15
 9 years ago
Bjarne Stroustrup 81493f331c Undid untentional change to C.85 9 years ago
Bjarne Stroustrup 7206b618a4 C.86 example accesses private members #541 
fixed
 9 years ago
Bjarne Stroustrup 9620ea8d43 I.30: Encapsulate rule violations 
Fiexed #893 by moving the bad example from ES.28 to a new rule: I.30:
Encapsulate rule violations.

I may inadvertenly have invented a new suppression syntax
 9 years ago
Bjarne Stroustrup 17ccab5836 Fix C.139 9 years ago
hsutter b10ffdf55f Reversed order of Lifetime.1 and .2 9 years ago
hsutter ff9bce8035 Add Lifetime.1-3 rules so tools can refer to them 9 years ago
Zachary Henkel f1b348e0db Additional guidance around casts: 
- Warn on unnecessary casts
- Avoid casts on arithmetic types
- Add specializations of the rules for Pro-type-reinterpretcast
 9 years ago
Sergey Zubkov 17715010a2 travis CI fixes and grammar fix from #920 9 years ago
Andrew Pardoe b09b9ad8b9 Updating date & typos 9 years ago