Commit Graph

1903 Commits (string_span-excision)
 

Author SHA1 Message Date
apenn-msft f4c80921d6
Update CppCoreGuidelines.md 6 years ago
apenn-msft 4e61010c27
keep wording more consistent
.... if a bit more monotonous, but that's ok.
6 years ago
apenn-msft 426ac8747d
updated wording around use of <> for projects
make it more clear that using <> for external projects is just a typical example (and not the only use case for <> outside of standard headers)
6 years ago
apenn-msft bbc2f4dc5d
Merge branch 'master' into patch-1 6 years ago
Sergey Zubkov 986402298a travis CI fixes 6 years ago
Arthur O'Dwyer d45496ff5e
You should never =delete a destructor! (#1605) 6 years ago
apenn-msft 30ef5b8524
update code markdown for #include 6 years ago
apenn-msft 66792e4875
Update wording and examples for SF.12: Prefer the quoted form of `#include` for files relative
Updated wording, adjusted example, and provided a more verbose example of what can go wrong if using the wrong form.
6 years ago
apenn-msft e47463c14a
SF.12: Prefer the quoted form of `#include` for files relative to the including file
The current guidance on SF.12 can be over-applied and devolves into "always use <>" because all compilers support adding include directories to the <> search. In this case, even the current directory may be added and so it is always possible to use <> for every header. Applying the guidance then devolves into an undesirable state where <> is always used and include"" is never used.

Instead, the proposed guidance leverages and encourages the distinction between <> and "" to create an easy-to-understand rule that the original guidance hints at and that most developers already follow and understand: "" is for local headers and <> is for library and external headers.
6 years ago
Sergey Zubkov 9928c95f97 typos, wording, links (closes #1529) 6 years ago
hsutter b4bb11a833 Tweak to close #1588 6 years ago
shaneasd 040b141acf
Clarify ES.48 enforcement rule for void cast of [[nodiscard]] (#1588) 6 years ago
hsutter 1ca5545ce1 Followup to close #1586 6 years ago
Akash Mozumdar 6f01c706a8
Actually detect negative sizes by following ES.106 (#1586)
* Actually detect negative sizes by following ES.106

And don't use senseless one letter names

* fix grammar

Co-Authored-By: Johel Ernesto Guerrero Peña <johelegp@gmail.com>

Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
6 years ago
Sylwester Fraczek d2be4cba57
F.21 remove `;` in function definition (#1592) 6 years ago
Sergey Zubkov ab91388efd
fix mismatched anchors, closes #1569 (#1581) 6 years ago
Akash Mozumdar aea393c85c
C.180 example bugfix (#1587)
new[] needs delete[]
6 years ago
Adnn 2f0c2e5874
C.22 Fixes a mistake in the code example not making a deep copy (#1573) 6 years ago
hsutter fc383d6641 Updated #1570
Typo
6 years ago
Chris Guzak 63ceef65e3
Add SF.12, 3rd try (#1570)
* add SF.12

* add incscope to isocpp.dic to get the CI build to pass

* expand INCLUDES, update dictionary for the ci build to pass

* pr feedback

* in the same directory

* update based on feedback

* 3rd try

* PR feedback

* update lable

* Update CppCoreGuidelines.md

* Update CppCoreGuidelines.md
6 years ago
hsutter 6388b4d1ea Followup to PR 1564
Changed the two anchors back (anchors need to stay stable and don't
display visibly anyway)
Switched "non-public" back to hyphernated (to use hyphenation
consistently)
6 years ago
Hyuk Myeong ab0255b371
Add and remove hyphens to words that begin with non (#1564)
* Add hyphens to words that begins with a non

* Remove hyphens in nonpublic
6 years ago
roroberto 1429d9ec71
Added example to CP.61: Use an async() to spawn a concurrent task (#1557)
Added example to CP.61: Use an async() to spawn a concurrent task
6 years ago
Herb Sutter 6e72adc0fe
Casting away const isn't undefined behavior, but modifying a constant is (#1509)
* Casting away const isn't undefined behavior, but modifying a constant is

You can cast away `const` as much as you like, as long as you never write to variable.

* rewording for clarification
6 years ago
hsutter 2eb8ea9279 Tweaked #1516 one more time 6 years ago
hsutter fd857db583 Tweak to #1516 per editors call 6 years ago
kuzkry 745b0664c2
clarify that GSL semi-specification of some types does not reflect actual support of them (#1516) 6 years ago
hsutter dc8e49314f Tweaked PR #1553 per editors call 6 years ago
Kim Viggedal 153da17417
Merge I.2 and R.6 seem to address the same issue, (#1553)
thus I propose removing R.6 and moving some of its contents into I.2.
6 years ago
hsutter 9a4db6c1c4 Adopt the change suggested in PR #1556, just making the casing consistent the other way (lowercase) 6 years ago
hsutter b01d9e0d23 Updated MISRA entry with link, updating PR #1554 6 years ago
Mark Nelson 605a48ae03 Added two coding references (#1554)
* Added two commonly used coding guideline documents

* Update CppCoreGuidelines.md
6 years ago
hsutter f92c1c2eb3 Tweaked #1551
To adjust example comment and Enforcement per PR #1551 comments
6 years ago
Baptiste Thémine 164c0b3b5d Add code examples to CppCoreGuidelines ES.77 (#1551) 6 years ago
Hyuk Myeong 5c065f850c Fix typos (#1549)
* R.37 : it callees -> its callees
* ES.65 : a different part from the original paper
6 years ago
Sergey Zubkov c68a395830 [I.27] fix move ctor in the pimpl example (closes #1471) 6 years ago
Sergey Zubkov df94731290 update LLVM coding standards description, closes #1502 6 years ago
Bernd Ritter 778b44c2c9 Corrected link to noexcept anchor (#1559) 6 years ago
Sergey Zubkov 282ff88e57 fixes to pass travis checks 6 years ago
Sergey Zubkov 9e9950353a typos noted in comments to 2fdc696 6 years ago
shaneasd 1e371f7f86 Fix trivial recent typos (#1550) 6 years ago
Bjarne Stroustrup ad30d9ee16 Update CppCoreGuidelines.md
Clarified the enforcement of C.121 according to #1368
6 years ago
Bjarne Stroustrup 7db3ad84ff Update CppCoreGuidelines.md
REsolving #1500 with an explanatory note in the introduction.
6 years ago
Bjarne Stroustrup 2fdc6960b4 Update CppCoreGuidelines.md
Adding rule to resolve #1424
6 years ago
Bjarne Stroustrup a58ec3ee69 Update CppCoreGuidelines.md
To resolve #1356, cleaned up the text for non-rules, eliminating double negatives
6 years ago
Bjarne Stroustrup f370b1fa9e Update CppCoreGuidelines.md
Closed #1101
6 years ago
Bjarne Stroustrup b06e365c9f Modify ES.20 to address #1400 6 years ago
Bjarne Stroustrup 1fdd7e2869 testing
date change
6 years ago
Sergey Zubkov 93ab66d8da
[SF.9] singular/plural mismatch (closes #1545) 6 years ago
hsutter 3528dd91ef Updated Lifetime spec to 1.1
Major changes in R1:
- Added SharedOwner concept.
- Added “Diagnostic sensitivity options” section to define a way to
start with zero-false-positive warnings and increasingly opt into
additional diagnostics.
- Changed function annotation syntax to contract-like pre(cond) and
post(cond) syntax, and added that they are implicitly inherited by
virtual overrides.
- Renamed static to global to reduce confusion with the keyword.
- Refined default lifetimes semantics of Pointer-to-Pointer parameters.
6 years ago