Commit Graph

1430 Commits (es23-updates)

Author SHA1 Message Date
Amir Livneh b933b03329 Fix punctuation in ES.77 (#1363) 7 years ago
Amir Livneh 5750f1ee86 Fix typo in ES.86 example (#1362) 7 years ago
Amir Livneh 35db3bf123 Fix typo in ES.87 (#1361) 7 years ago
Martín Knoblauch Revuelta 4f97d37239 Fix args. of == and != operators in C.100 (#1359)
Obviously, the comparisons are intended to compare `Sorted_vector`s, not `T` values
7 years ago
Amir Livneh 5190ea51a3 Fix capitalization in ES.61 enforcement (#1350)
* Fix capitalization in ES.61 enforcement

* Fix grammar
7 years ago
Amir Livneh 2056a14da7 Fix grammar in ES.50 (#1352) 7 years ago
Amir Livneh a10668dc1d Fix spacing in ES.63 example (#1351) 7 years ago
Amir Livneh d6a6e7092a Remove superfluous word in ES.42 enforcement (#1347) 7 years ago
Amir Livneh 882e9539fa Fix grammar in ES.42 (#1346) 7 years ago
Amir Livneh c83acbc347 Fix comment grammar in ES.40 example (#1345) 7 years ago
Amir Livneh 9f0e9fe0a3 Fix grammar (#1344) 7 years ago
Amir Livneh edac03725a Remove unnecessary hyphenation (#1343) 7 years ago
Amir Livneh a95daa781e Fix comment stating incorrect assigned variable (#1342) 7 years ago
Amir Livneh 8c141fcfa5 Fix typo (#1341) 7 years ago
Amir Livneh feae4d6c15 Fix grammar (#1340) 7 years ago
Amir Livneh abad343557 Fix indentation in example (#1339) 7 years ago
Sergey Zubkov 358bef703e closes #1337 7 years ago
Matthew Dews 65aa7232e8 Fix typo (#1338) 7 years ago
Amir Livneh f2b517eac2 Fix grammar (#1336) 7 years ago
Amir Livneh ff8934c39b Fix grammar (#1335) 7 years ago
Amir Livneh e0830c7c3b Remove redundant word (#1334) 7 years ago
Amir Livneh 94eadbb7eb Fix grammar (#1333) 7 years ago
Amir Livneh 4797c26d4b Fix grammar (#1331) 7 years ago
Amir Livneh 1fd6ce78c2 Fix typo and grammar (#1329) 7 years ago
Amir Livneh c9f1066756 Fix grammar (#1327) 7 years ago
hsutter 684635eecd Closes #1322
Add an Enforcement rule for prefix inc/dec functions. Try to phrase it
to reduce noisiness.
7 years ago
Franz Hollerer f7ef39f0d6 issue #1236 - there is no reason to use the Hungarian notation in C (#1326) 7 years ago
hsutter fb1d4c9189 Closes #1319 7 years ago
mpherg cbbe6071ce Standardize example and note headers (minor) (#1318)
* Standardize example headings

Some example headings used "Example, [good,bad]" and others used
"Example; [good,bad]" (note the comma verses semicolon). The vast
majority of the headings used the comma version, so this commit
normalizes all example headings to use a comma instead of a semicolon.

* Standardize note heading level

Two of the "Note" headings were set to level four, but the rest are at
level 5. Fix the level fours to make them level fives.
7 years ago
hsutter b38d065e45 Cleaned up a code example comment 7 years ago
hsutter 373765b827 Closes #1317
Fixed section heading to match item
7 years ago
hsutter 4ed280b080 Closes #1315 7 years ago
Dave Smith 1805589141 Pro.bounds: Correct impact wording (minor) (#1316) 7 years ago
hsutter fd9c725549 Update for #1306 7 years ago
hsutter 88a9ba0640 Closes #1311 7 years ago
beinhaerter 4e8ab7ae86 F.21 wording changed to current status of the standard (#1313) 7 years ago
Mark Abraham e58bce6f6a Fix typo in ES.102 (#1312)
The value -2 is signed, so the word "unsigned" is clearly wrong.  The
text notes that negative subscripts are a source of surprises and
bugs, so the correction to "negative" seems to reflect Bjarne's
original intent.
7 years ago
Honggyu Kim 526f14f56a Prefer bullet points to a long sentence in SL section (#1310)
It'd be better to have bullet points than writing the points in a long
sentence even with description in parenthesis.
7 years ago
Max Bozzi dd8fc629d7 Remove claims that "constexpr functions are pure" (#1307)
F.4 and F.8 made this erroneous claim as parts of notes which are
entirely removed.
7 years ago
hsutter 714bec5010 Updated date 7 years ago
Marzo Sette Torres Junior f971ad2f17 Fixing tagged union example (#1301)
It did not compile previously due to missing type specifier on placement new.
7 years ago
Jonathan Wakely d822f80d5d Fix whitespace errors in code, to make Travis CI pass 7 years ago
Andriy Berestovskyy a7fc6f6d4e Fix a typo (#1300) 7 years ago
hsutter 0fe73c966d Fixed typo
Thanks @dalg24!
7 years ago
hsutter d6d7d749c3 Minor rewording 7 years ago
hsutter 334c902a13 Adding suggestion in #1283 comment thread
Thanks, Mike!
7 years ago
Sergey Zubkov 41b10255c4 date update 7 years ago
Herb Sutter 6e3d2d2c22 Closes #1297 7 years ago
Herb Sutter 4fa9d4019f Minor edits to #1291 7 years ago
Chris Guzak 407fcc0eac update to I.4: Make interfaces precisely and strongly typed (#1291)
* updates to I.4: Make interfaces precisely and strongly typed

* Update enforcement list

* address PR feedback from blakehawkins
7 years ago
Kyle 0181ab40a7 Fix example in C.51 (#1294)
The example looks like it previously used i to represent date, but now the variable is called d. I updated the use and related parameters to match.
7 years ago
Sergey Zubkov 50b9cefe39 travis CI and typo fixes 7 years ago
Bjarne Stroustrup dd67c99f1f made C.con a bit less incomplate
More will eventually come
7 years ago
Bjarne Stroustrup 1103509895 A philosophical rule/caution 7 years ago
Bjarne Stroustrup 0f61a4be4e typos 7 years ago
Bjarne Stroustrup 417d512fea clarifications for #1267
references to resource handles
7 years ago
Bjarne Stroustrup 11f58787b8 minor clarifications
for #1268 and #1267
7 years ago
Bjarne Stroustrup 2cfcd878c4 fiexed C.49
remover contradiction to C.45 (#1092) ) and mention string_view
7 years ago
Bjarne Stroustrup 8825798df6 clarify rules for {} initialization
in response to #1279
7 years ago
hsutter 61cdce115e Improved description of F.3 example
The example in F.3 is not really long, but it is complex
7 years ago
hsutter 3fbc0b35a4 Closes #1265, make the chaining exception more visible 7 years ago
Alexander Knorre 7733c326b2 No double deletion (#1278) 7 years ago
Martin 0b275097b6 Fixed a typo within ES.23 7 years ago
tcorbat e81d770bdc Fix broken link to Lifetime paper (#1274) 7 years ago
Sergey Zubkov 30a0e1bef7 closes #1239 7 years ago
Sergey Zubkov 8915f05950 travis CI fixes 7 years ago
hsutter fa7b1fe41f Fixed Lifetime.pdf link 7 years ago
hsutter f02b24a71a Update Lifetime profile to 1.0 7 years ago
hsutter ecfd61c8d8 Clarify C.128
Improved readability of primary paragraph.
Added Discussion section of the classes of errors being addressed.
7 years ago
hsutter 104cd63a37 Closes #1257
Fixed example
7 years ago
hsutter 60e19d76a4 Closes #1254 7 years ago
beinhaerter 5b372a99d8 Fixes Issue #1253: wrong link in SS-bounds to Res-simple (#1255)
Replaced Res-simple with Res-ptr.
7 years ago
Sergey Zubkov 1e12aba7af missing a return *this in a copy-assignment 7 years ago
Sergey Zubkov faad9d8b56 one more typo 7 years ago
Sergey Zubkov 73057d3b0b travis CI fixes and typos 7 years ago
Sergey Zubkov b16eb424e9 typo: funct1_tau -> func1_tau 7 years ago
Bjarne Stroustrup e75a7056c4 Resolving #1146
explaining SCARY and referencing the SCARY paper
7 years ago
Bjarne Stroustrup a0bc2d71ca resolving #1137
clarification
7 years ago
Bjarne Stroustrup 647aa80f0d applying #1139
more references to C++17
7 years ago
Bjarne Stroustrup 79a5b08ad9 resolve #1175
I added a note
7 years ago
Bjarne Stroustrup 5cabda84d7 resolve #1185
implicit operator functions
7 years ago
Bjarne Stroustrup d3c3e3aa98 resolve #1209, #814, and #167
noexcept and destructors
7 years ago
Bjarne Stroustrup f3e7dbac6e Resolution of #1228
explicitly discouraging the use of # and ##
7 years ago
Bjarne Stroustrup c11001f0a6 resolving #1238 about style
The caveat is added only to the subset of rules where it appears to be
relevant
7 years ago
Bjarne Stroustrup dd4cae0260 Resolve #1241 about returning T&& 7 years ago
hsutter e31a85dc2d Closes #1251 7 years ago
Neil MacIntosh 0c7a349342 Fix example for ES.70 (#1252)
As per #574, fixes the example in ES.70 to emphasize good use of a switch over a sequence of if-else-if statements.
7 years ago
hsutter d1def3290c Tweaked PR 1249 post-merge to cover copy assignment too 7 years ago
Andrzej Krzemieński 08f67de9fb Updated C.67 and C.130 (#1249)
* Updated C.67 and C.130

This addresses https://github.com/isocpp/CppCoreGuidelines/issues/1246.

* fixed typeos

* updated dictionary
7 years ago
Jonathan Wakely 42f8fa5f84 Use H3 heading for C.140 instead of H2
Fixes #1250
7 years ago
martysama0134 513a5fd624 Fix example good in ES.42, count to a.size() (#1245)
* Fix example good in ES.42, count to a.size()

* Fix typos in ES.64 and Con.1

* Fix Example bad in T.3, no value in subscript
8 years ago
jeffreylindsey 6dd14321c1 GSL grammar fix, added missing plurality in full name (#1243)
* Renamed all appropriate instances of "guideline support library" to "guidelines support library".

* Renamed additional instances of "guideline support library" to "guidelines support library" in remaining files.
8 years ago
jeffreyai 04b2fabb9b Change 'lifetime profile' to 'lifetime safety profile' and fix the bad/broken links (#1240)
'lifetime profile' is only used twice with bad/broken links. 'lifetime safety' and 'lifetime safety profile' are used more frequently, and make more sense.
8 years ago
Sergey Zubkov cb08aa24a4
s/more that two/more than two 8 years ago
hsutter e0ecfc83b7 Closes 1220 8 years ago
hsutter a488f1d8b5 Added F.48, closes #1219 8 years ago
hsutter c0a2efdfe8 Closes #1218 8 years ago
hsutter 1283da9afa Closes #1216 8 years ago
hsutter 28e9f02550 Let's =default to avoid an out of line definition question 8 years ago
hsutter aa645b0372 Closes #1214
Added virtual dtor to make the example standalone
8 years ago