From f7a24cc20aa0115b89c45b16f248e0ed41f73328 Mon Sep 17 00:00:00 2001
From: Vladimir nett00n Budylnikov <git@nett00n.org>
Date: Sun, 21 Apr 2024 18:15:39 +0400
Subject: [PATCH] add build arguments to compose

---
 README.md          | 10 ++++++++++
 docker-compose.yml | 10 +++++-----
 2 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/README.md b/README.md
index 66904b6..80aa84a 100644
--- a/README.md
+++ b/README.md
@@ -52,6 +52,16 @@ You can set environmental values in `.env` file
 
 ### Environment
 
+#### Build arguments
+
+- `ALPINE_VERSION` - alpine linux docker image tag
+- `NOVNC_VERSION` - version of noVNC. [Releases page](https://github.com/novnc/noVNC/releases)
+- `WEBSOCKIFY_VERSION` - Version of Websockify. [Releases page](https://github.com/novnc/websockify/releases)
+- `IMAGE_TAG` - name of building image tag
+- `BUILD_DATE` - date of building image
+
+#### Runtime environmental variables
+
 - `ALPINE_PASSWORD` - change password for user `alpine`
 - `PUBLIC_HTTP_PORT` - set port for access to novnc.
   `16080:6080` would publish novnc on `16080` port.
diff --git a/docker-compose.yml b/docker-compose.yml
index c0bcfac..ac8096b 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -4,11 +4,11 @@ services:
     build:
       context: .
       args:
-        ALPINE_VERSION: "3.19"
-        NOVNC_VERSION: "v1.4.0"
-        WEBSOCKIFY_VERSION: "v0.11.0"
-        IMAGE_TAG: "latest"
-        BUILD_DATE: "01.01.1970"
+        ALPINE_VERSION: "${ALPINE_VERSION:-3.19}"
+        NOVNC_VERSION: "${NOVNC_VERSION:-v1.4.0}"
+        WEBSOCKIFY_VERSION: "${WEBSOCKIFY_VERSION:-v0.11.0}"
+        IMAGE_TAG: "${IMAGE_TAG:-latest}"
+        BUILD_DATE: "${BUILD_DATE:-01.01.1970}"
     ports:
       - '${PUBLIC_HTTP_PORT:-6080:6080}'
     restart: always